LEAHI-SW-LDT-261-2 LEAHI-SW-LDT-261_

closed on 05 Jun

Author

Moderator

Reviewers

LEAHI-SW-LDT-261_

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 111

leahi-application 0
- Folder etc/reports 0
  - Folder alarms 0
    - File AlarmMapping.csv 0 Remove
    - File AlarmMapping.py 0 Remove
  - Folder cppcheck 0
    - File cppcheck.err 0 Remove
    - File cppcheck.log 0 Remove
- Folder sources 0
  - Folder canbus 0
    - File MessageGlobals.h 8 Remove
    - File MessageInterpreter.cpp 0 Remove
  - Folder cloudsync 0
    - File CloudSyncController.cpp 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder dialogs 0
        
        File DiagnosticsDialog.qml 0 Remove
      - Folder pages/settings 0
        
        File SettingsDeviceRegistration.qml 0 Remove
        
        File SettingsInformation.qml 0 Remove
      - File main.qml 0 Remove
    - File GuiGlobals.cpp 0 Remove
    - File GuiGlobals.h 11 Remove
  - Folder model 0
    - Folder dg/adjustment/settings 0
      - File MAdjustDDSerialNumberResponse.cpp 0 Remove
      - File MAdjustDDSerialNumberResponse.h 0 Remove
      - File MAdjustDDVersionsResponse.cpp 0 Remove
      - File MAdjustDDVersionsResponse.h 0 Remove
      - File MAdjustDGSerialNumberResponse.cpp 0 Remove
      - File MAdjustDGSerialNumberResponse.h 0 Remove
      - File MAdjustDGVersionsResponse.cpp 0 Remove
      - File MAdjustDGVersionsResponse.h 0 Remove
    - Folder hd 0
      - Folder adjustment/settings 0
        
        File MAdjustHDRequests.h 0 Remove
        
        File MAdjustHDSerialNumberResponse.cpp 0 Remove
        
        File MAdjustHDSerialNumberResponse.h 0 Remove
        
        File MAdjustHDVersionsRequest.cpp 0 Remove
        
        File MAdjustHDVersionsRequest.h 0 Remove
        
        File MAdjustHDVersionsResponse.cpp 0 Remove
        
        File MAdjustHDVersionsResponse.h 0 Remove
        
        File MAdjustTDSerialNumberResponse.cpp 0 Remove
        
        File MAdjustTDSerialNumberResponse.h 2 Remove
        
        File MAdjustTDVersionsRequest.cpp 0 Remove
        
        File MAdjustTDVersionsRequest.h 3 Remove
        
        File MAdjustTDVersionsResponse.cpp 0 Remove
        
        File MAdjustTDVersionsResponse.h 0 Remove
      - Folder alarm 0
        
        File MAlarmMapping.cpp 0 Remove
      - Folder data 0
        
        File MTDAirTrapData.cpp 3 Remove
        
        File MTDAirTrapData.h 9 Remove
        
        File MTDBatteryData.cpp 0 Remove
        
        File MTDBatteryData.h 3 Remove
        
        File MTDBloodPumpData.cpp 0 Remove
        
        File MTDBloodPumpData.h 0 Remove
        
        File MTDEjectorData.cpp 0 Remove
        
        File MTDEjectorData.h 0 Remove
        
        File MTDSwitchesData.cpp 0 Remove
        
        File MTDSwitchesData.h 0 Remove
        
        File MTDTemperatureData.cpp 0 Remove
        
        File MTDTemperatureData.h 0 Remove
        
        File MTDValvesData.cpp 0 Remove
        
        File MTDValvesData.h 0 Remove
        
        File MTDValvesDatacpp 0 Remove
        
        File MTDVoltageData.cpp 0 Remove
        
        File MTDVoltageData.h 0 Remove
    - File MModel.h 0 Remove
  - Folder storage 0
    - File Logger.cpp 2 Remove
    - File Logger.h 0 Remove
    - File TreatmentLog.cpp 0 Remove
  - Folder view 0
    - Folder hd/data 0
      - File VHDAirTrapData.cpp 0 Remove
      - File VHDAirTrapData.h 0 Remove
      - File VTDAirTrapData.cpp 0 Remove
      - File VTDAirTrapData.h 0 Remove
      - File VTDBatteryData.cpp 0 Remove
      - File VTDBatteryData.h 0 Remove
      - File VTDBloodPumpData.cpp 0 Remove
      - File VTDBloodPumpData.h 0 Remove
      - File VTDEjectorData.cpp 0 Remove
      - File VTDEjectorData.h 0 Remove
      - File VTDSwitchesData.cpp 0 Remove
      - File VTDSwitchesData.h 0 Remove
      - File VTDTemperatureData.cpp 0 Remove
      - File VTDTemperatureData.h 0 Remove
      - File VTDValvesData.cpp 0 Remove
      - File VTDValvesData.h 0 Remove
      - File VTDVoltageData.cpp 0 Remove
      - File VTDVoltageData.h 0 Remove
    - Folder settings 0
      - File VAdjustmentVersions.cpp 0 Remove
      - File VAdjustmentVersions.h 0 Remove
      - File VBluetooth.h 3 Remove
    - File VTreatmentCreate.cpp 0 Remove
    - File VTreatmentCreate.h 0 Remove
    - File VView.h 0 Remove
- File leahi.pro 0 Remove
- File leahi.pro.user 0 Remove
leahi-sw.plugins.sim 0
- Folder DD_Versions 0
  - File interface.ui 0 Remove
  - File loader.py 0 Remove
- Folder TD_AirTrap 0
  - Folder __pycache__ 0
    - File loader.cpython-38.pyc 0 Remove
  - File interface.ui 0 Remove
  - File loader.py 0 Remove
- Folder TD_Battery 0
  - Folder __pycache__ 0
    - File loader.cpython-38.pyc 0 Remove
  - File interface.ui 0 Remove
  - File loader.py 0 Remove
- Folder TD_BloodPump 0
  - Folder __pycache__ 0
    - File loader.cpython-38.pyc 0 Remove
  - File interface.ui 0 Remove
  - File loader.py 0 Remove
- Folder TD_Ejector 0
  - File interface.ui 0 Remove
  - File loader.py 0 Remove
- Folder TD_OpMode 0
  - Folder __pycache__ 0
    - File loader.cpython-38.pyc 0 Remove
  - File loader.py 0 Remove
- Folder TD_Switches 0
  - Folder __pycache__ 0
    - File loader.cpython-38.pyc 0 Remove
  - File interface.ui 0 Remove
  - File loader.py 0 Remove
- Folder TD_Temperatures 0
  - Folder __pycache__ 0
    - File loader.cpython-38.pyc 0 Remove
  - File interface.ui 0 Remove
  - File loader.py 0 Remove
- Folder TD_Valves 0
  - Folder __pycache__ 0
    - File loader.cpython-38.pyc 0 Remove
  - File interface.ui 0 Remove
  - File loader.py 0 Remove
- Folder TD_Versions 0
  - File interface.ui 0 Remove
  - File loader.py 0 Remove
- Folder TD_Voltages 0
  - Folder __pycache__ 0
    - File loader.cpython-38.pyc 0 Remove
  - File interface.ui 0 Remove
  - File loader.py 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Tiffany Mejia	Author & Moderator	57m	8	fixed!
Sean Nash	Reviewer - 0% reviewed
Michael Garthwaite	Reviewer - 0% reviewed	0m
Dara Navaei	Reviewer - Complete	1m
Behrouz NematiPour	Reviewer - Complete	3h 3m	36	RESOLVED
Daniel Ho	Reviewer - 0% reviewed
Vinayakam Mani	Reviewer - 0% reviewed
Total		4h 2m	44

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/sources/.../settings/MAdjustDGSerialNumberResponse.cpp Deleted

Click to load diff

/sources/.../settings/MAdjustDGSerialNumberResponse.h Deleted

Click to load diff

/sources/.../settings/MAdjustDGVersionsResponse.cpp Deleted

Click to load diff

/sources/.../settings/MAdjustDGVersionsResponse.h Deleted

Click to load diff

/sources/.../settings/MAdjustHDSerialNumberResponse.cpp Deleted

Click to load diff

/sources/.../settings/MAdjustHDSerialNumberResponse.h Deleted

Click to load diff

/sources/.../settings/MAdjustHDVersionsRequest.cpp Deleted

Click to load diff

/sources/.../settings/MAdjustHDVersionsRequest.h Deleted

Click to load diff

/sources/.../settings/MAdjustHDVersionsResponse.cpp Deleted

Click to load diff

/sources/.../settings/MAdjustHDVersionsResponse.h Deleted

Click to load diff

/sources/view/hd/data/VHDAirTrapData.cpp Deleted

Click to load diff

/TD_AirTrap/__pycache__/loader.cpython-38.pyc Deleted

Click to load diff

/TD_Battery/__pycache__/loader.cpython-38.pyc Deleted

Click to load diff

/TD_BloodPump/__pycache__/loader.cpython-38.pyc Deleted

Click to load diff

/TD_OpMode/__pycache__/loader.cpython-38.pyc Deleted

Click to load diff

/TD_Switches/__pycache__/loader.cpython-38.pyc Deleted

Click to load diff

/TD_Temperatures/__pycache__/loader.cpython-38.pyc Deleted

Click to load diff

/TD_Valves/__pycache__/loader.cpython-38.pyc Deleted

Click to load diff

/TD_Voltages/__pycache__/loader.cpython-38.pyc Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-SW-LDT-261-2

LEAHI-SW-LDT-261_

LEAHI-SW-LDT-261-2 44

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

LEAHI-SW-LDT-261_

LEAHI-SW-LDT-261-2 44

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time