· /leahi_dialin/fp/modules/valves.py

(-0, +28)

| History

| Source

| Diff

]]> Thu, 26 Mar 2026 18:29:24 -0700 Michael Garthwaite https://devapps.diality.us/changelog/leahi-dialin?cs=85af425612b38183f788af2120cec58b37cf9dc3 https://devapps.diality.us/changelog/leahi-dialin?cs=85af425612b38183f788af2120cec58b37cf9dc3 Michael Garthwaite committed 85af425 on branch LDT-3218-update-iofp-permeate-target-flow, develop in leahi-dialin LDT-3218: added valve recovery config method

· /leahi_dialin/fp/modules/valves.py

(-0, +28)

| History

| Source

| Diff

]]> Thu, 26 Mar 2026 12:16:59 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3218-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3218-1 Dara Navaei started review LEAHI-DIALIN-LDT-3218-1 ]]> Thu, 26 Mar 2026 11:16:40 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-696-1 LEAHI-DIALIN-LDT-696_[TC Implement] LVTC-13 ]]> Thu, 26 Mar 2026 10:30:02 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28137 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28137 Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-696-1

Added

Add a TODO comment to change the message once implemented in FW

removed duplicate

ROPump is repeated

RECOVERY_STATES

· /leahi_dialin/common/dd_defs_proxy.py	(-41, +41)	| History	| Source	| Diff
· /leahi_dialin/common/fp_defs.py	(-7, +47)	| History	| Source	| Diff
· /leahi_dialin/common/fp_defs_proxy.py	(-30, +33)	| History	| Source	| Diff
· /leahi_dialin/common/td_defs_proxy.py	(-39, +39)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/boost_pump.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/ro_pump.py	(-1, +1)	| History	| Source	| Diff

]]> Wed, 18 Mar 2026 13:27:23 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2 Michael Garthwaite and Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3629-2 LEAHI-DIALIN-LDT-3629_FP and DD valve_states_enum are one short of the full valve list ]]> Tue, 17 Mar 2026 07:05:16 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2/#c28079 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2/#c28079 Raghu Kallala commented on LEAHI-DIALIN-LDT-3629-2

update params

· /leahi_dialin/common/msg_ids.py	(-1, +4)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/valves.py	(-3, +3)	| History	| Source	| Diff

]]> Mon, 16 Mar 2026 12:06:59 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2 Dara Navaei started review LEAHI-DIALIN-LDT-3629-2 ]]> Mon, 16 Mar 2026 11:53:00 -0700 Zoltan Miskolci https://devapps.diality.us/changelog/leahi-dialin?cs=d089b54d2fde7f8c36acce41a47d7acee4ef5da6 https://devapps.diality.us/changelog/leahi-dialin?cs=d089b54d2fde7f8c36acce41a47d7acee4ef5da6 Zoltan Miskolci committed d089b54 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-3218-update-iofp-permeate-target-flow and 12 more in leahi-dialin renamed dict keys

· /leahi_dialin/dd/modules/heaters.py	(-1, +0)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/valves.py	(-3, +3)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/valves.py	(-3, +3)	| History	| Source	| Diff

]]> Mon, 16 Mar 2026 10:04:25 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1/#c28052 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1/#c28052 Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LDT-2655-1

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( conductivity sensors ).

· /leahi_dialin/fp/modules/valves.py

(-8, +8)

| History

| Source

| Diff

]]> Thu, 12 Mar 2026 14:32:23 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1 Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3629-1 ]]> Thu, 12 Mar 2026 14:12:47 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1 Michael Garthwaite and Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3629-1 LEAHI-DIALIN-LDT-3629_FP and DD valve_states_enum are one short of the full valve list ]]> Thu, 12 Mar 2026 14:10:07 -0700 Michael Garthwaite https://devapps.diality.us/changelog/leahi-dialin?cs=7af5202c29a5938f79a3ae8b210ae49e1c84963d https://devapps.diality.us/changelog/leahi-dialin?cs=7af5202c29a5938f79a3ae8b210ae49e1c84963d Michael Garthwaite committed 7af5202 on branch develop in leahi-dialin Merge branch 'LDT-2655-fix_conductivity_override' into develop

· /leahi_dialin/fp/modules/temperatures.py

(-4, +1)

| History

| Source

| Diff

]]> Thu, 12 Mar 2026 14:08:53 -0700 Michael Garthwaite https://devapps.diality.us/changelog/leahi-dialin?cs=21460e78e780dd07e083c3812c27f53507464786 https://devapps.diality.us/changelog/leahi-dialin?cs=21460e78e780dd07e083c3812c27f53507464786 Michael Garthwaite committed 21460e7 on branch LDT-2655-fix_conductivity_override, develop in leahi-dialin LDT-2655: updates to overrides for v1 and v2 sensors.

· /leahi_dialin/fp/modules/conductivity_sensors.py

(-3, +6)

| History

| Source

| Diff

]]> Thu, 12 Mar 2026 14:03:32 -0700 Michael Garthwaite https://devapps.diality.us/changelog/leahi-dialin?cs=20c66b3bb8286d87559830a84621489645c5249c https://devapps.diality.us/changelog/leahi-dialin?cs=20c66b3bb8286d87559830a84621489645c5249c Michael Garthwaite committed 20c66b3 on branch LDT-2655-fix_conductivity_override, develop in leahi-dialin Merge branch 'staging' into LDT-2655-fix_conductivity_override

· /leahi_dialin/common/__init__.py	(-4, +4)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/valves.py	(-134, +98)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/water_pumps.py	(-72, +40)	| History	| Source	| Diff
· /leahi_dialin/protocols/CAN.py	(-16, +0)	| History	| Source	| Diff
· /leahi_dialin/protocols/__init__.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/utils/__init__.py	(-1, +1)	| History	| Source	| Diff
· /tests/data_capture_helpers/fp_helpers.py	(-5, +8)	| History	| Source	| Diff

]]> Thu, 12 Mar 2026 11:50:16 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27939 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27939 Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-3629-1

Fixed

added Todo comment

· /leahi_dialin/fp/modules/fp_test_configs.py	(-2, +0)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/ro_pump.py	(-1, +0)	| History	| Source	| Diff
· /leahi_dialin/td/modules/pressure_sensors.py	(-0, +1)	| History	| Source	| Diff

]]>