Fisheye on leahi-dialin/leahi_dialin/fp/modules

LEAHI-DIALIN-LDT-3904-1: closed by Zoltan Miskolci

Zoltan Miskolci — Mon, 01 Jun 2026 16:20:43 -0700

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3904-1

leahi-dialin (develop): Merge branch 'LDT-3904-opmode-the-operation-mode-broad' into develop

Zoltan Miskolci — Mon, 01 Jun 2026 09:39:56 -0700

Zoltan Miskolci committed e45b20c on branch develop in leahi-dialin

Merge branch 'LDT-3904-opmode-the-operation-mode-broad' into develop

· /leahi_dialin/common/__init__.py

(-0, +1)

| History

| Source

| Diff

· /leahi_dialin/common/constants.py

(-0, +2)

| History

| Source

| Diff

· /leahi_dialin/common/msg_defs.py

(-8, +6)

| History

| Source

| Diff

· /leahi_dialin/common/msg_ids.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/common/override_templates.py

(-10, +10)

| History

| Source

| Diff

· /leahi_dialin/common/td_defs.py

(-82, +117)

| History

| Source

| Diff

· /leahi_dialin/common/test_config_defs.py

(-3, +2)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-46, +68)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/alarms.py

(-66, +56)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/balancing_chamber.py

(-35, +31)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-43, +40)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-69, +50)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-32, +29)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dd_test_configs.py

(-14, +22)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dialysate_pump.py

(-68, +45)

| History

| Source

| Diff

… 54 more files in changeset.

LEAHI-DIALIN-LDT-3904-1: reviewers finished

Mon, 01 Jun 2026 08:01:21 -0700

Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3904-1

LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes

LEAHI-DIALIN-LDT-3904-1: reviewers finished

Fri, 29 May 2026 10:05:00 -0700

Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-3904-1

LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes

LEAHI-DIALIN-LDT-3904-1: comment by Zoltan Miskolci "references to Denali has been removed"

Zoltan Miskolci — Thu, 21 May 2026 17:09:11 -0700

Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-3904-1

references to Denali has been removed

leahi-dialin (staging): Removed Denali reference

Zoltan Miskolci — Thu, 21 May 2026 11:31:31 -0700

Zoltan Miskolci committed 1f2bf6d on branch LDT-3904-opmode-the-operation-mode-broad, develop, staging in leahi-dialin

Removed Denali reference

· /CHANGELOG.md

(-2, +2)

| History

| Source

| Diff

· /README.md

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/common/msg_defs.py

(-3, +3)

| History

| Source

| Diff

· /leahi_dialin/common/override_templates.py

(-9, +9)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-12, +12)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/alarms.py

(-10, +10)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/balancing_chamber.py

(-9, +9)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-12, +12)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-11, +11)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-11, +11)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dd_test_configs.py

(-7, +7)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dialysate_pump.py

(-11, +11)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/drybicart.py

(-10, +10)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/events.py

(-5, +5)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/gen_dialysate.py

(-10, +10)

| History

| Source

| Diff

… 61 more files in changeset.

LEAHI-DIALIN-LDT-3904-1: comment by Raghu Kallala "Shouldn't we use Leahi instead of Denali?"

Raghu Kallala — Thu, 21 May 2026 07:44:38 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-3904-1

Shouldn't we use Leahi instead of Denali?

leahi-dialin (staging): Added missing data for conversion

Zoltan Miskolci — Thu, 07 May 2026 10:12:10 -0700

Zoltan Miskolci committed 22338b0 on branch LDT-3904-opmode-the-operation-mode-broad, develop, staging in leahi-dialin

Added missing data for conversion

· /leahi_dialin/dd/modules/events.py	(-8, +8)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/events.py	(-8, +8)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/events.py	(-8, +8)	\| History	\| Source	\| Diff

leahi-dialin (staging): Added desc

Zoltan Miskolci — Wed, 06 May 2026 17:51:18 -0700

Zoltan Miskolci committed 979d1b0 on branch LDT-3904-opmode-the-operation-mode-broad, develop, staging in leahi-dialin

Added desc

· /leahi_dialin/fp/modules/events.py

(-1, +11)

| History

| Source

| Diff

leahi-dialin (staging): - Updated FP events

Zoltan Miskolci — Wed, 06 May 2026 17:45:33 -0700

Zoltan Miskolci committed 9a4413f on branch LDT-3904-opmode-the-operation-mode-broad, develop, staging in leahi-dialin

- Updated FP events

· /leahi_dialin/fp/modules/events.py

(-94, +103)

| History

| Source

| Diff

leahi-dialin (staging): - Updated Event enum - Updated Datatypes enum - Added some debugging print to abstract class - Removed some init import ...

Zoltan Miskolci — Wed, 06 May 2026 16:07:39 -0700

Zoltan Miskolci committed 27cd8e0 on branch LDT-3904-opmode-the-operation-mode-broad, develop, staging in leahi-dialin

- Updated Event enum - Updated Datatypes enum - Added some debugging print to abstract class - Removed some init import to remove cyclic dependencies - Updated alarms

· /leahi_dialin/common/dd_defs.py	(-10, +11)	\| History	\| Source	\| Diff
· /leahi_dialin/common/fp_defs.py	(-1, +3)	\| History	\| Source	\| Diff
· /leahi_dialin/common/generic_defs.py	(-8, +10)	\| History	\| Source	\| Diff
· /leahi_dialin/common/test_config_defs.py	(-2, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/alarms.py	(-25, +15)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/alarms.py	(-25, +16)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/events.py	(-14, +13)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/permeate_tank.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/alarms.py	(-41, +29)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/events.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/td_test_configs.py	(-1, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/utils/__init__.py	(-28, +0)	\| History	\| Source	\| Diff
· /leahi_dialin/utils/abstract_classes.py	(-10, +39)	\| History	\| Source	\| Diff
· /leahi_dialin/utils/enums/__init__.py	(-23, +2)	\| History	\| Source	\| Diff

leahi-dialin (staging): - Updated events

Zoltan Miskolci — Tue, 05 May 2026 15:10:55 -0700

Zoltan Miskolci committed 75c9789 on branch LDT-3904-opmode-the-operation-mode-broad, develop, staging in leahi-dialin

- Updated events

· /leahi_dialin/common/generic_defs.py	(-2, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/events.py	(-18, +14)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/events.py	(-56, +35)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/events.py	(-57, +34)	\| History	\| Source	\| Diff

leahi-dialin (staging): - Updated DD and TD module - Updaterd TDValvePosition enum

Zoltan Miskolci — Tue, 05 May 2026 14:25:28 -0700

Zoltan Miskolci committed 34b64ff on branch LDT-3904-opmode-the-operation-mode-broad, develop, staging in leahi-dialin

- Updated DD and TD module - Updaterd TDValvePosition enum

· /leahi_dialin/common/td_defs.py

(-6, +8)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-8, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/balancing_chamber.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-27, +26)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-7, +6)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dialysate_pump.py

(-22, +21)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/drybicart.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/gen_dialysate.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/heaters.py

(-11, +10)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/levels.py

(-6, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/post_gen_dialysate.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pre_gen_dialysate.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pressure_sensors.py

(-7, +6)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/rinse_pump.py

(-1, +0)

| History

| Source

| Diff

… 40 more files in changeset.

LEAHI-DIALIN-LDT-3904-1: started by Dara Navaei

Dara Navaei — Mon, 04 May 2026 17:46:48 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-3904-1

leahi-dialin (staging): - DD refactor Changes in FP and TD module

Zoltan Miskolci — Mon, 04 May 2026 17:24:48 -0700

Zoltan Miskolci committed f03c9a3 on branch LDT-3904-opmode-the-operation-mode-broad, develop, staging in leahi-dialin

- DD refactor Changes in FP and TD module

· /leahi_dialin/fp/filtration_purification.py

(-1, +2)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/alarms.py

(-7, +8)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/boost_pump.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/conductivity_sensors.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/events.py

(-17, +17)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/flow_sensors.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/fp_test_configs.py

(-4, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/levels.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/permeate_tank.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/pressure_sensors.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/ro_pump.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/temperatures.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/valves.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/water_pumps.py

(-3, +3)

| History

| Source

| Diff

· /leahi_dialin/fp/proxies/dd_proxy.py

(-2, +2)

| History

| Source

| Diff

… 18 more files in changeset.

LEAHI-DIALIN-LDT-3984-1: closed by Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil — Thu, 30 Apr 2026 14:23:40 -0700

Vendor - TEL - Sameer Poyil Closed LEAHI-DIALIN-LDT-3984-1

leahi-dialin (LDT-3904-opmode-the-operation-mode-broad): LDT-3984 addressed review comments

Vendor - TEL - Sameer Poyil — Wed, 29 Apr 2026 12:05:18 -0700

Vendor - TEL - Sameer Poyil committed b0929a0 on branch LDT-3505-heparin-td-04-dev-feature-implemenation, LDT-3854-dd-bicarb-chamber-f-level-fix and 13 more in leahi-dialin

LDT-3984 addressed review comments

· /leahi_dialin/fp/modules/levels.py

(-1, +1)

| History

| Source

| Diff

LEAHI-DIALIN-LDT-3984-1: comment by Zoltan Miskolci "What's the point of this line if you overwrite ..."

Zoltan Miskolci — Tue, 28 Apr 2026 09:17:20 -0700

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-3984-1

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

LEAHI-DIALIN-LDT-3984-1: comment by Zoltan Miskolci "LAST_DD_LEVL is in FW not in dialin. In dialin..."

Zoltan Miskolci — Tue, 28 Apr 2026 09:25:40 -0700

Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-3984-1

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

LEAHI-DIALIN-LDT-3984-1: comment by Zoltan Miskolci "Why increment the number when you didn't add a ..."

Zoltan Miskolci — Tue, 28 Apr 2026 09:15:57 -0700

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-3984-1

Why increment the number when you didn't add a new sensor?

LEAHI-DIALIN-LDT-3984-1: comment by Raghu Kallala "This should be LAST_DD_LEVL not NUM_OF_LEVELS i..."

Raghu Kallala — Tue, 28 Apr 2026 09:01:04 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-3984-1

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

LEAHI-DIALIN-LDT-3984-1: comment by Raghu Kallala "LEVEL_OFFSET?"

Raghu Kallala — Tue, 28 Apr 2026 09:00:08 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-3984-1

LEVEL_OFFSET?

LEAHI-DIALIN-LDT-3984-1: reviewers resumed

Mon, 27 Apr 2026 20:46:21 -0700

Sean Nash and Raghu Kallala resumed reviewing LEAHI-DIALIN-LDT-3984-1

LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber

leahi-dialin (LDT-3904-opmode-the-operation-mode-broad): LDT-3984 fix for conductivie level sensors d46, d63,d98

Vendor - TEL - Sameer Poyil — Mon, 27 Apr 2026 20:44:56 -0700

Vendor - TEL - Sameer Poyil committed 03cf6f1 on branch LDT-3505-heparin-td-04-dev-feature-implemenation, LDT-3854-dd-bicarb-chamber-f-level-fix and 13 more in leahi-dialin

LDT-3984 fix for conductivie level sensors d46, d63,d98

· /leahi_dialin/common/dd_defs.py	(-5, +5)	\| History	\| Source	\| Diff
· /leahi_dialin/common/fp_defs.py	(-1, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/levels.py	(-3, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/levels.py	(-1, +3)	\| History	\| Source	\| Diff

leahi-dialin (LDT-3904-opmode-the-operation-mode-broad): LDT-3984 conductive level sensor dialin implementation

Vendor - TEL - Sameer Poyil — Fri, 24 Apr 2026 22:45:49 -0700

Vendor - TEL - Sameer Poyil committed 106e58f on branch LDT-3505-heparin-td-04-dev-feature-implemenation, LDT-3854-dd-bicarb-chamber-f-level-fix and 13 more in leahi-dialin

LDT-3984 conductive level sensor dialin implementation

· /leahi_dialin/common/msg_ids.py	(-1, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/levels.py	(-0, +27)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/levels.py	(-3, +5)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-3984-1: started by Dara Navaei

Dara Navaei — Thu, 23 Apr 2026 08:02:29 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-3984-1

LEAHI-DIALIN-LDT-696-1: closed by Zoltan Miskolci

Zoltan Miskolci — Mon, 30 Mar 2026 14:33:37 -0700

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-696-1

LEAHI-DIALIN-LDT-696-1: reviewers finished

Mon, 30 Mar 2026 11:30:47 -0700

Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-696-1

LEAHI-DIALIN-LDT-696_[TC Implement] LVTC-13

leahi-dialin (develop): Merge branch 'LDT-3218-update-iofp-permeate-target-flow' into develop

Michael Garthwaite — Thu, 26 Mar 2026 18:29:32 -0700

Michael Garthwaite committed 1b36df7 on branch develop in leahi-dialin

Merge branch 'LDT-3218-update-iofp-permeate-target-flow' into develop

· /leahi_dialin/fp/modules/valves.py

(-0, +28)

| History

| Source

| Diff

leahi-dialin (develop): LDT-3218: added valve recovery config method

Michael Garthwaite — Thu, 26 Mar 2026 18:29:24 -0700

Michael Garthwaite committed 85af425 on branch develop in leahi-dialin

LDT-3218: added valve recovery config method

· /leahi_dialin/fp/modules/valves.py

(-0, +28)

| History

| Source

| Diff