buttons.py

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-2300: Resolved code review comments

  1. … 40 more files in changeset.
Done - timestamps added to DD, FP, and TD

Done - timestamps added to DD, FP, and TD

Done

Done

Done

Done

Done

Done

I'm not sure I really understand the question here, but I do know that the DD Heaters data is being published with this handler: I've organized all heater data into a nested dictionary so that only...

I'm not sure I really understand the question here, but I do know that the DD Heaters data is being published with this handler: I've organized all heater data into a nested dictionary so that only one "variable" is being published. The same goes for the other publish functions before each handler. I will reorganize the order of the published variables so that timestamp is listed last.

No timestamp?

No timestamp?

I didn't see dbg variables in the publish list above.

I didn't see dbg variables in the publish list above.

Is msg_id_dd_heaters_data really being published here? Should it be? ** This comment applies to all classes as it appears you've done this everywhere. Also, I think we typically list the timestamp ...

Is msg_id_dd_heaters_data really being published here? Should it be? ** This comment applies to all classes as it appears you've done this everywhere.
Also, I think we typically list the timestamp last.

Replace "dg" with "dd".

Replace "dg" with "dd".

Replace "hd" with "dd".

Replace "hd" with "dd".

LDT-2300: Updated handlers in module classes and addressed Zoltan's comments

  1. … 4 more files in changeset.
LEAHI-DIALIN-LDT-2300_Dialin: Add a way for a Dialin user to identify what broadcast message is being received
LEAHI-DIALIN-LDT-2300_Dialin: Add a way for a Dialin user to identify what broadcast message is being received
File is reverse_osmosis.py. I actually don't like the file name. Prefer something like filtration_purification.py. Still ok with RO for folders and class names I think - though Jenna uses IOFP.

File is reverse_osmosis.py. I actually don't like the file name. Prefer something like filtration_purification.py. Still ok with RO for folders and class names I think - though Jenna uses IOFP.

Match DD op modes in f/w.

Match DD op modes in f/w.

DG to DD.

DG to DD.

Remove.

Remove.

Remove.

Remove.

Remove.

Remove.

Remove.

Remove.

Remove.

Remove.

Remove chem disinfect. Leahi not currently slated to have a chem disinfect.

Remove chem disinfect. Leahi not currently slated to have a chem disinfect.

Remove - we don't have this in Leahi yet.

Remove - we don't have this in Leahi yet.

DG to DD.

DG to DD.

Catch up with latest f/w.

Catch up with latest f/w.