leahi-dialin / leahi_dialin

td

Clone Tools

Stats

Commits this week: 7
Total Committers: 8
Last Commit: 09 Feb
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 09 Feb
4:20 pm

Sean Nash

10:34 am

Zoltan Miskolci

9:19 am

Michael Garthwaite

LDT-3287: Reworked the initial message to be a login command instead of a blank ACK message

Options
    • -10
    • +3
    ./treatment_delivery.py
  2. … 2 more files in changeset.
Saturday 07 Feb
4:46 pm

Dara Navaei

Friday 06 Feb
10:56 am

Vendor - TEL - Jashwant Gantyada

10:53 am

Zoltan Miskolci and Sean Nash

9:47 am

Vendor - TEL - Jashwant Gantyada

LDT-2316 fixed code review comments

Options
    • -2
    • +1
    ./modules/air_pump.py
9:32 am

Vendor - TEL - Jashwant Gantyada

Done.

Done.

9:31 am

Vendor - TEL - Jashwant Gantyada

LDT-2316 addressed review comments

Options
    • -2
    • +4
    ./modules/air_pump.py
9:26 am

Sean Nash

Can we make 255 a constant with a name like MAX_AIR_PUMP_POWER_LEVEL to make it clear what we're doing here?

Can we make 255 a constant with a name like MAX_AIR_PUMP_POWER_LEVEL to make it clear what we're doing here?

9:25 am

Zoltan Miskolci

We agreed to change back the enums into the static variation. Why would that cover a class that has been implemented to mask the enums from direct access, so if they need to be changed to dynamic o...

We agreed to change back the enums into the static variation.
Why would that cover a class that has been implemented to mask the enums from direct access, so if they need to be changed to dynamic or renamed or anything, the other repositories that are using them through this class won't be affected or need any update.

9:02 am

Dara Navaei

LEAHI-DIALIN-LDT-2316_Max allowed H12 power needs to be updated
LEAHI-DIALIN-LDT-2316_Max allowed H12 power needs to be updated
9:00 am

Vendor - TEL - Jashwant Gantyada

LDT-2316-added fix to accept duty cycle

Options
    • -3
    • +8
    ./modules/air_pump.py
Thursday 05 Feb
3:38 pm

Dara Navaei

Did we not decide to revert all the changes back and the redesign the whole concept again?

Did we not decide to revert all the changes back and the redesign the whole concept again?

3:35 pm

Behrouz NematiPour

1:26 pm

Michael Garthwaite

WIP on develop

LDT-3287: added message sent for TD. trimmed documentation

Options
    • -0
    • +10
    ./treatment_delivery.py
  2. … 2 more files in changeset.
11:32 am

Dara Navaei

LEAHI-DIALIN-LDT-3287_Dialin ability to pull B1.9 IOFP variable data has changed from B1.0
LEAHI-DIALIN-LDT-3287_Dialin ability to pull B1.9 IOFP variable data has changed from B1.0
Wednesday 04 Feb
3:05 pm

Zoltan Miskolci

- Removed ignore and _str_list from base class, added empty _str_list to all childs to not throw an error when from_str is called on them

Options
    • -0
    • +1
    ./modules/alarms.py
  2. … 7 more files in changeset.
Tuesday 03 Feb
3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

3:54 pm

Behrouz NematiPour

This design is incorrect, For common codes, a proxy or a wrapper class should have been implemented. We will keep it for now to unblock the rest of the team.

This design is incorrect,
For common codes, a proxy or a wrapper class should have been implemented.
We will keep it for now to unblock the rest of the team.

3:54 pm

Behrouz NematiPour

This is incorrect. We should not create many objects for all the Enum classes in an API, and we should not use memory that may not even be in use. We will keep it for now to unblock the rest of the...

This is incorrect.
We should not create many objects for all the Enum classes in an API, and we should not use memory that may not even be in use.
We will keep it for now to unblock the rest of the team.

2:27 pm

Zoltan Miskolci

When building locally without all the parameters the generated name throws an error during python pip install. So this ensures that if no parameter is added, it uses the default name which is compa...

When building locally without all the parameters the generated name throws an error during python pip install.
So this ensures that if no parameter is added, it uses the default name which is compatible with pip install.
The " -+. " sequence is throwing an error.

2:25 pm

Zoltan Miskolci

removed commented out line

removed commented out line

2:24 pm

Zoltan Miskolci

removed

Options
    • -1
    • +0
    ./modules/events.py
2:20 pm

Zoltan Miskolci

It's a class containing all the enums of the def file. Yes we need them as many other Framework and huge amount of code are using them.

It's a class containing all the enums of the def file.
Yes we need them as many other Framework and huge amount of code are using them.

2:20 pm

Zoltan Miskolci

Obviously not. You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

Obviously not.
You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

2:15 pm

Zoltan Miskolci

Yes, they are aliases that are used for example in Dialin's temperature sensor module to decide which msg id to use for the override. Updating an alias's value when adding new entries to the enum i...

Yes, they are aliases that are used for example in Dialin's temperature sensor module to decide which msg id to use for the override.
Updating an alias's value when adding new entries to the enum is easier then changing the last or first sensor type across Dialin modules, which could be forgotten or missed.