leahi-fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
No, its deleted

No, its deleted

I do not see TD use case in any of the PI controller functions. so do we need TD here ?

I do not see TD use case in any of the PI controller functions. so do we need TD here ?

LDT-2004 dry bicarb closed loop control

LDT-2004 Dry bicarb closed loop tuning

Merge branch 'LDT-3218-update-iofp-permeate-target-flow-CLEAN' into develop

LDT-3218: fixes for previous err overshooting first control loop

LDT-3218: integration fixes.

LDT-3218: Added PID controller temporary to mitigate RO flow control reaction to new behavior of D3 opening and closing.

    • -0
    • +398
    /PIDControllers.c
LDT-2004 dry bicarb and acid closed loop control

LDT-2004 dry bicarb and acid cosed loop control

LDT-2004 bicarb closed loop control

LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)
LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LDT-3352 latest from staging

Merge branch 'LDT-1195-dd-is-balancing-chamber-switching' into develop

LDT-3352 heater control update

LDT-3352 dialysate temp control update

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Merge branch 'staging' into LDT-2004-dialysate-composition-dosing-control--dd

Why do we have a local sub state variable that we don't do anything with?

Why do we have a local sub state variable that we don't do anything with?

This is to avoid compilation warning

This is to avoid compilation warning

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

I don't think these coefficient access functions need to be public. Consider making them private.

I don't think these coefficient access functions need to be public. Consider making them private.

These seem more like concentrate doses, not dialysate doses. Consider renaming.

These seem more like concentrate doses, not dialysate doses. Consider renaming.

What is this?

What is this?

Add blank line after declarations.

Add blank line after declarations.

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

else TD ?

else TD ?

This is a structure, not an enumeration.

This is a structure, not an enumeration.