Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-5575 Service - SW - 01- Calibration - Hydraulics - R&I - 03: DEV - Feature Implementation & Code Document [& Diagnostics]

added isntrucitons for hydraulics deaeration

LEAHI-APPLICATION-LDT-5572_Service - SW - 01- Calibration - Hydraulics - R&I
LEAHI-APPLICATION-LDT-5572_Service - SW - 01- Calibration - Hydraulics - R&I
updated

updated

APPROVED.

APPROVED.

RESOLVED. Added another comment regarding the same.

RESOLVED.
Added another comment regarding the same.

Nicholas Ramirez Thanks for the change to the ok and result. *To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the fun...

Nicholas Ramirez
Thanks for the change to the ok and result.

  • To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the function itself has ok as the parameter name.
  • Also move the:
    ; if ( ! ok ) { goto invalid; }
    

    on the "same line" and "aligned" as the evaluating parameter, to keep the code clean.

APPROVED

APPROVED

updated

updated

updated

updated

updated

updated

remove the ok and just check result and if any fails goto invalid

remove the ok and just check result and if any fails goto invalid

see if you can use payloadLen from MessageGlobals.h

see if you can use payloadLen from MessageGlobals.h

double check

double check

more udpatres to isntrucitons

more usabliltiy updateds

push update instrucityons

usavnilty changee

  1. … 1 more file in changeset.
removedin https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-5331-1CFR-87504

removedin https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-5331-1CFR-87504

update config

add usability updates

  1. … 3 more files in changeset.
remove from prime // priming - TODO check if needed. may not need

remove from prime // priming - TODO check if needed. may not need

LDT-5448 End of Treatment - SW - 01- Notification - R&I - 03: DEV - Feature Implementation & Code Document [& Diagnostics]

updated pre and post tx step images

    • binary
    ./Substitution_1.png
    • binary
    ./Substitution_2.png
  1. … 1 more file in changeset.
LDT-5448 End of Treatment - SW - 01- Notification - R&I - 03: DEV - Feature Implementation & Code Document [& Diagnostics]

add updated instrucitons and end tx alarms

  1. … 1 more file in changeset.
LEAHI-APPLICATION-LDT-5445_End of Treatment - SW - 01- Notification - R&I
LEAHI-APPLICATION-LDT-5445_End of Treatment - SW - 01- Notification - R&I
LEAHI-APPLICATION-LDT-5158_SW Misc & Enhc - SW - 01 - SW Integration - Calibration - R&I
LEAHI-APPLICATION-LDT-5158_SW Misc & Enhc - SW - 01 - SW Integration - Calibration - R&I