LEAHI-APPLICATION-LDT-4193-1 LEAHI-APPLICATION-LDT-4193_NON-FEATURE: SW Misc & Enhc - SW - 01 - Water/Dialysate Sample - R&I

closed on 22 May

Author

Moderator

Reviewers

LEAHI-APPLICATION-LDT-4193_NON-FEATURE: SW Misc & Enhc - SW - 01 -...

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 99

leahi-application 0
- Folder SDDs 0
  - File WaterSample.png 0 Remove
  - File WaterSample.puml 3 Remove
  - File WaterSampleDialog.puml 0 Remove
- Folder sources 0
  - Folder canbus 0
    - File MessageDispatcher.cpp 0 Remove
    - File MessageDispatcher.h 0 Remove
    - File MessageGlobals.h 0 Remove
    - File MessageInterpreter.cpp 9 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File BaseSwitch.qml 0 Remove
        
        File HeaderBar.qml 0 Remove
        
        File Line.qml 0 Remove
        
        File NotificationBar.qml 0 Remove
        
        File ProgressBar.qml 0 Remove
        
        File RangeSlider.qml 0 Remove
        
        File RangedValue.qml 0 Remove
        
        File ScrollBar.qml 0 Remove
      - Folder compounds 0
        
        File AutoStepController.qml 0 Remove
        
        File InstructionView.qml 0 Remove
      - Folder dialogs 0
        
        Folder diagnostics 0
        
        File DiagnosticsDD.qml 3 Remove
        
        File DiagnosticsFP.qml 0 Remove
        
        Folder headerbar 0
        
        File HeaderbarSettings.qml 9 Remove
        
        Folder watersample 0
        
        File WaterSampleDialog.qml 0 Remove
        
        File WaterSampleDialysatePage.qml 0 Remove
        
        File WaterSamplePage.qml 0 Remove
        
        File AlarmDialog.qml 0 Remove
        
        File AlarmListDialog.qml 0 Remove
      - Folder globals 0
        
        File Colors.qml 6 Remove
        
        File Variables.qml 0 Remove
      - Folder pages 0
        
        Folder posttreatment 0
        
        File PostTreatmentReview.qml 0 Remove
        
        Folder settings 0
        
        File SettingsDeviceRegistration.qml 0 Remove
        
        File SettingsROInput.qml 0 Remove
        
        File SettingsStack.qml 0 Remove
        
        Folder treatment 0
        
        Folder adjustments 0
        
        File TreatmentAdjustmentIsolatedUFDurationEdit.qml 0 Remove
        
        Folder sections 0
        
        File TreatmentFlows.qml 0 Remove
        
        File TreatmentHDF.qml 0 Remove
        
        File TreatmentHeparin.qml 0 Remove
        
        File TreatmentTrends.qml 0 Remove
      - File main.qml 0 Remove
    - File GuiGlobals.cpp 0 Remove
    - File GuiGlobals.h 0 Remove
  - Folder model 0
    - Folder dd/data 0
      - File MDDGenDialysateData.cpp 0 Remove
      - File MDDGenDialysateData.h 0 Remove
      - File MDDOperationModeData.cpp 0 Remove
      - File MDDOperationModeData.h 0 Remove
    - Folder dg/data 0
      - File MDGOperationModeData.cpp 0 Remove
      - File MDGOperationModeData.h 0 Remove
    - Folder fp/data 0
      - File MFPRORejectionPercentageData.cpp 0 Remove
      - File MFPRORejectionPercentageData.h 0 Remove
    - Folder hd/adjustment/pretreatment 0
      - File MPreTreatmentAdjustRequests.h 0 Remove
      - File MPreTreatmentAdjustWaterSampleResponse.cpp 0 Remove
      - File MPreTreatmentAdjustWaterSampleResponse.h 0 Remove
    - Folder td 0
      - Folder adjustment/pretreatment 0
        
        File MPreTreatmentAdjustWaterSampleResponse.cpp 0 Remove
        
        File MPreTreatmentAdjustWaterSampleResponse.h 0 Remove
        
        File MPreTreatmentAdjustWaterSampleResultResponse.cpp 0 Remove
        
        File MPreTreatmentAdjustWaterSampleResultResponse.h 0 Remove
      - Folder data 0
        
        File MWaterSampleData.cpp 0 Remove
        
        File MWaterSampleData.h 0 Remove
    - File MModel.h 0 Remove
  - Folder view 0
    - Folder dd/data 0
      - File VDDConductivityData.cpp 0 Remove
      - File VDDGenDialysateData.cpp 0 Remove
      - File VDDGenDialysateData.h 0 Remove
      - File VDDOperationModeData.cpp 0 Remove
      - File VDDOperationModeData.h 0 Remove
    - Folder dg/data 0
      - File VDGOperationModeData.cpp 0 Remove
      - File VDGOperationModeData.h 0 Remove
    - Folder fp/data 0
      - File VFPRORejectionPercentageData.cpp 0 Remove
      - File VFPRORejectionPercentageData.h 0 Remove
    - Folder hd 0
      - Folder adjustment/pretreatment 0
        
        File VPreTreatmentAdjustmentWaterSample.cpp 0 Remove
        
        File VPreTreatmentAdjustmentWaterSample.h 0 Remove
      - Folder data/pretreatment 0
        
        File VPreTreatmentStatesData.cpp 0 Remove
        
        File VPreTreatmentStatesData.h 0 Remove
    - Folder settings 0
      - File VDuetRoWaterDG.cpp 0 Remove
      - File VSettings.cpp 0 Remove
      - File VSettings.h 0 Remove
    - Folder td 0
      - Folder adjustment/pretreatment 0
        
        File VPreTreatmentAdjustmentWaterSample.cpp 0 Remove
        
        File VPreTreatmentAdjustmentWaterSample.h 0 Remove
      - Folder data 0
        
        Folder treatment 0
        
        File VTreatmentTrends.cpp 0 Remove
        
        File VTreatmentRanges.cpp 0 Remove
        
        File VTreatmentRanges.h 0 Remove
        
        File VWaterSampleData.cpp 0 Remove
        
        File VWaterSampleData.h 3 Remove
    - File VHeaderbarModel.cpp 0 Remove
    - File VHeaderbarModel.h 0 Remove
    - File VListModel.cpp 0 Remove
    - File VListModel.h 3 Remove
    - File VTreatmentCreate.h 0 Remove
    - File VView.h 0 Remove
    - File VWaterSampleModel.cpp 0 Remove
    - File VWaterSampleModel.h 0 Remove
- File leahi.pro 0 Remove
- File leahi.qrc 0 Remove
leahi-sw.config 0
- Folder configurations 0
  - Folder Instructions 0
    - File Instructions.conf 0 Remove
    - File Water_Sample_1.png 0 Remove
  - Folder Parameters 0
    - File DataList.conf 0 Remove
  - Folder Settings 0
    - File System.conf 0 Remove
leahi-sw.resources 0
- Folder images 0
  - File carbon_filter_1.png 0 Remove
  - File carbon_filter_2.png 0 Remove
  - File help.png 0 Remove
  - File moon.png 0 Remove
  - File sun.png 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Nicholas Ramirez	Author & Moderator	1h 26m	36	BN aoorives
Vendor - TEL - Sivvanarayana Kurapati	Reviewer - 0% reviewed
Dara Navaei	Reviewer - 0% reviewed	0m
Stephen Quong	Reviewer - Complete	21m
Tiffany Mejia	Reviewer - 0% reviewed
Zoltan Miskolci	Reviewer - 0% reviewed
Michael Garthwaite	Reviewer - 0% reviewed
Raghu Kallala	Reviewer - 0% reviewed
Behrouz NematiPour	Reviewer - Complete	5m
Vinayakam Mani	Reviewer - 0% reviewed
Total		1h 52m	36

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/sources/.../data/MDGOperationModeData.cpp Deleted

Click to load diff

/sources/model/.../data/MDGOperationModeData.h Deleted

Click to load diff

/sources/.../pretreatment/MPreTreatmentAdjustWaterSampleResponse.cpp Deleted

Click to load diff

/sources/.../pretreatment/MPreTreatmentAdjustWaterSampleResponse.h Deleted

Click to load diff

/sources/.../pretreatment/MPreTreatmentAdjustWaterSampleResponse.cpp Deleted

Click to load diff

/sources/.../pretreatment/MPreTreatmentAdjustWaterSampleResponse.h Deleted

Click to load diff

/sources/.../data/VDGOperationModeData.cpp Deleted

Click to load diff

/sources/view/.../data/VDGOperationModeData.h Deleted

Click to load diff

/sources/.../pretreatment/VPreTreatmentAdjustmentWaterSample.cpp Deleted

Click to load diff

/sources/.../pretreatment/VPreTreatmentAdjustmentWaterSample.h Deleted

Click to load diff

/configurations/Instructions/Water_Sample_1.png Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-APPLICATION-LDT-4193-1

LEAHI-APPLICATION-LDT-4193_NON-FEATURE: SW Misc & Enhc - SW - 01 -...

LEAHI-APPLICATION-LDT-4193-1 36

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

LEAHI-APPLICATION-LDT-4193_NON-FEATURE: SW Misc & Enhc - SW - 01 -...

LEAHI-APPLICATION-LDT-4193-1 36

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time