ro-firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 6
Last Commit: 24 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 18 Nov
12:58 pm

Raghu Kallala

LDT-2116 RO RR and duty cycle to start with has been updated

Options
    • -10
    • +23
    /firmware/App/Modes/ModeGenPermeate.c
    • -4
    • +4
    /firmware/App/Monitors/Conductivity.c
12:57 pm

Michael Garthwaite

LDT-2116: pushed new closed loop coefficients for tgt flow of 750mL

Options
    • -2
    • +2
    /firmware/App/Controllers/ROPump.c
Thursday 13 Nov
11:52 am

Raghu Kallala

LDT-2116 Added code for RO rejection ratio broadcast and dialin overrides.

Options
    • -4
    • +2
    /firmware/App/Modes/ModeGenPermeate.c
    • -2
    • +190
    /firmware/App/Monitors/Conductivity.c
    • -0
    • +18
    /firmware/App/Monitors/Conductivity.h
    • -1
    • +3
    /firmware/App/Services/Messaging.c
Monday 10 Nov
1:30 pm

Raghu Kallala

LDT-2116 changed Gen logic to go open loop for 3 sec and transition to closed loop.

Options
    • -2
    • +2
    /firmware/App/Controllers/PermeateTank.c
    • -1
    • +105
    /firmware/App/Modes/ModeGenPermeate.c
Wednesday 05 Nov
9:07 am

Michael Garthwaite

LDT-2116: removed manual level control out of pre gen mode. Permeate tank control will be sub mode specific. implemented in permeate flush to prevent overfill

Options
    • -0
    • +13
    /firmware/App/Modes/FlushPermeate.c
    • -14
    • +1
    /firmware/App/Modes/ModePreGenPermeate.c
Monday 03 Nov
9:13 am

Michael Garthwaite

LDT-1773: code review comments.

Options
    • -1
    • +1
    /firmware/App/Controllers/Valves.c
9:10 am

Michael Garthwaite

LDT-2116: code review updates. Change target flow rate from 700 to 750 per system spec. Reverted debugging broadcast for RO Pump.

Options
    • -1
    • +1
    /firmware/App/Controllers/PermeateTank.c
    • -10
    • +10
    /firmware/App/Controllers/ROPump.c
    • -2
    • +3
    /firmware/App/Modes/FlushConcentrate.c
    • -1
    • +1
    /firmware/App/Modes/ModeGenPermeate.c
    • -1
    • +1
    /firmware/App/Modes/ModePreGenPermeate.c
Friday 31 Oct
8:50 am

Michael Garthwaite

LDT-2116: fixed handle function call where it shouldnt have been called.

Options
    • -1
    • +1
    /firmware/App/Modes/FlushConcentrate.c
8:49 am

Raghu Kallala

LDT-2116 added private def for RO pump target flow

Options
    • -1
    • +2
    /firmware/App/Controllers/PermeateTank.c
Thursday 30 Oct
1:54 pm

Michael Garthwaite

LDT-2116: Updates to pre gen tank control such that it does not recirculate water while in the op mode.

Options
    • -1
    • +2
    /firmware/App/Modes/FPModeStandby.c
    • -1
    • +1
    /firmware/App/Modes/FlushConcentrate.c
    • -2
    • +0
    /firmware/App/Modes/FlushPermeate.c
    • -1
    • +15
    /firmware/App/Modes/ModePreGenPermeate.c
Wednesday 29 Oct
8:43 am

Michael Garthwaite

LDT-2116: Added concentrate flush changes to keep the permeate tank full in pre-gen

Options
    • -16
    • +57
    /firmware/App/Modes/FlushConcentrate.c
    • -1
    • +1
    /firmware/App/Modes/ModePreGenPermeate.c
Tuesday 21 Oct
9:46 am

Michael Garthwaite

LDT-2116: possible fix for open loop to target flow transition.

Options
    • -1
    • +2
    /firmware/App/Controllers/ROPump.c
Monday 20 Oct
8:35 pm

Michael Garthwaite

LDT-2116: updates to ro pump coefficients. updates to permeate tank control while P39 is closed.

Options
    • -2
    • +5
    /firmware/App/Controllers/PermeateTank.c
    • -15
    • +13
    /firmware/App/Controllers/ROPump.c
    • -1
    • +1
    /firmware/App/Drivers/FluidPump.c
Monday 29 Sep
2:14 pm

Michael Garthwaite

LDT-1773: updated comments for fpga interface. changed valve pwm period to correct value

Options
    • -5
    • +5
    /firmware/App/Controllers/Valves.c
    • -5
    • +43
    /firmware/App/Services/FpgaFP.c
    • -1
    • +1
    /firmware/App/Services/FpgaFP.h
Friday 19 Sep
8:58 am

Michael Garthwaite

LDT-1773: implemented FPGA interface for valve PWM. implemented in valves module

Options
    • -0
    • +12
    /firmware/App/Controllers/Valves.c
    • -0
    • +33
    /firmware/App/Services/FpgaFP.c
    • -0
    • +5
    /firmware/App/Services/FpgaFP.h
Thursday 04 Sep
1:32 pm

Dara Navaei

Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/FPCommon.h
1:27 pm

Raghu Kallala

LDT-1809 merge into staging

Options
1:19 pm

Raghu Kallala

LDT-1809 Resolved conflicts while merging staging

Options
    • -16
    • +35
    /firmware/App/Controllers/ROPump.c
    • -2
    • +2
    /firmware/App/Modes/FlushConcentrate.c
    • -2
    • +2
    /firmware/App/Modes/FlushPermeate.c
    • -1
    • +1
    /firmware/App/Modes/ModePreGenPermeate.c
9:06 am

Dara Navaei

Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/FPCommon.h
9:01 am

Michael Garthwaite

Merge branch 'LDT-1242-iofp-finalize-permeate-tank' into staging

Options
Wednesday 03 Sep
3:26 pm

Dara Navaei

Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/FPCommon.h
3:21 pm

Michael Garthwaite

Merge branch 'LDT-1242-iofp-finalize-permeate-tank' into develop

Options
3:16 pm

Michael Garthwaite

Merge branch 'staging' into LDT-1242-iofp-finalize-permeate-tank

Options
2:48 pm

Dara Navaei

Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/FPCommon.h
2:33 pm

Shyam Kumar Mathamala <ven.smathamala@diality.com>

Merged LDT-1735 to staging.

Options
2:28 pm

Shyam Kumar Mathamala <ven.smathamala@diality.com>

LDT-1735: fixed merge conflicts.

Options
    • -0
    • +368
    /firmware/App/Modes/InletPressureCheck.c
    • -0
    • +3
    /firmware/App/Services/Messaging.c
9:47 am

Dara Navaei

Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/FPCommon.h
9:46 am

Michael Garthwaite

Merge branch 'LDT-1242-iofp-finalize-permeate-tank' into develop

Options
9:44 am

Michael Garthwaite

LDT-1242: code review comments. comment aligning. fix ro pump control calling set pwm pct when it should have been pwm cnt

Options
    • -8
    • +11
    /firmware/App/Controllers/PermeateTank.c
    • -11
    • +11
    /firmware/App/Controllers/ROPump.c
    • -2
    • +2
    /firmware/App/Modes/FlushPermeate.c
    • -0
    • +1
    /firmware/App/Modes/InletPressureCheck.c
    • -1
    • +1
    /firmware/App/Modes/ModePreGenPermeate.c
8:50 am

Dara Navaei

Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/FPCommon.h