ro-firmware / firmware / App / Modes

ModeGenPermeate.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 3
Last Commit: 24 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 22 Nov
12:42 pm

Raghu Kallala

LDT-2116 addressed review comment

Options
    • -3
    • +3
    ./ModeGenPermeate.c
  2. … 1 more file in changeset.
12:28 pm

Raghu Kallala

LDT-2116 moved ro rejection check to waterQualityMonitors

Options
    • -8
    • +2
    ./ModeGenPermeate.c
  2. … 2 more files in changeset.
Thursday 20 Nov
2:43 pm

Raghu Kallala

Fixed reset during fill and full. Adjusted samples for duty cycle average calculation.

Options
    • -6
    • +3
    ./ModeGenPermeate.c
  2. … 1 more file in changeset.
Tuesday 18 Nov
12:58 pm

Raghu Kallala

LDT-2116 RO RR and duty cycle to start with has been updated

Options
    • -10
    • +23
    ./ModeGenPermeate.c
  2. … 1 more file in changeset.
Thursday 13 Nov
11:52 am

Raghu Kallala

LDT-2116 Added code for RO rejection ratio broadcast and dialin overrides.

Options
    • -4
    • +2
    ./ModeGenPermeate.c
  2. … 3 more files in changeset.
Monday 10 Nov
1:30 pm

Raghu Kallala

LDT-2116 changed Gen logic to go open loop for 3 sec and transition to closed loop.

Options
    • -1
    • +105
    ./ModeGenPermeate.c
  2. … 1 more file in changeset.
Monday 03 Nov
9:10 am

Michael Garthwaite

LDT-2116: code review updates. Change target flow rate from 700 to 750 per system spec. Reverted debugging broadcast for RO Pump.

Options
    • -1
    • +1
    ./ModeGenPermeate.c
  2. … 4 more files in changeset.
Tuesday 26 Aug
10:37 am

Raghu Kallala

Fixed the issue to set targets to zero when a firmware call is made for set functions per review comments.

Options
    • -1
    • +1
    ./ModeGenPermeate.c
  2. … 5 more files in changeset.
Wednesday 30 Jul
1:30 pm

Michael Garthwaite

LDT-566: code review comments.

Options
    • -30
    • +13
    ./ModeGenPermeate.c
  2. … 19 more files in changeset.
11:24 am

Michael Garthwaite

LDT-566: Permeate tank implementation. Changed RO control from pressure to flow for various sub modes. Alarm state and clear alarm overrides. Reworked temperature monitor to only publish.

Options
    • -123
    • +11
    ./ModeGenPermeate.c
  2. … 20 more files in changeset.
Tuesday 29 Jul
1:05 pm

Michael Garthwaite

LDT-566: Implemented FP fault mode. Removed math includes from flush modes.

Options
    • -5
    • +5
    ./ModeGenPermeate.c
  2. … 7 more files in changeset.
9:58 am

Michael Garthwaite

WIP on develop

LDT-566: code review comments. updated common naming to have a FP prefix.

Options
    • -2
    • +2
    ./ModeGenPermeate.c
  2. … 39 more files in changeset.
Friday 25 Jul
8:28 am

Michael Garthwaite

LDT-566: partial rework of alarm monitoring for water quality based on code review. updated valves to be in sync with latest HDD

Options
    • -0
    • +7
    ./ModeGenPermeate.c
  2. … 20 more files in changeset.
Tuesday 22 Jul
2:51 pm

Michael Garthwaite

WIP on develop

LDT-566: LDT-676: Removed M7 and P20 valves.

Options
    • -2
    • +0
    ./ModeGenPermeate.c
  2. … 3 more files in changeset.
Thursday 17 Jul
3:47 pm

Michael Garthwaite

LDT-566: removed unneeded defines. Added percentage values for pwm to RO and boost broadcasts. Removed X5 from pressure sensors. Fixed Pre-Generate mode rushing through sub states.

Options
    • -17
    • +12
    ./ModeGenPermeate.c
  2. … 12 more files in changeset.
Tuesday 15 Jul
4:31 pm

Michael Garthwaite

LDT-566: Implemented hard stop commands for water pumps. Added valve actuation for RO recovery settings in gen permeate, set to med.

Options
    • -4
    • +10
    ./ModeGenPermeate.c
  2. … 7 more files in changeset.
3:54 pm

Michael Garthwaite

LDT-566: transitioning to standby mode and fault mode will now shut off pumps and close valves. updates in naming. fixed pre-gen transitioning. removed some checks for when gen water request it received.

Options
    • -12
    • +23
    ./ModeGenPermeate.c
  2. … 13 more files in changeset.
Wednesday 09 Jul
2:14 pm

Michael Garthwaite

LDT-566: generate water modes both defeatured and ro featured

Options
    • -21
    • +121
    ./ModeGenPermeate.c
  2. … 28 more files in changeset.
Wednesday 02 Jul
12:04 pm

Michael Garthwaite

LDT-566: updated naming across the project. Renamed files some fits to fit naming. Filter flush and permeate flush implemented.

Options
    • -0
    • +332
    ./ModeGenPermeate.c
  2. … 70 more files in changeset.
Thursday 17 Apr
1:20 pm

Michael Garthwaite

LDT-332: init file commit. reworked Generate Permeate to Generate water. Naming has been changed.

Options
    • -326
    • +0
    ./ModeGenPermeate.c
  2. … 9 more files in changeset.
Tuesday 25 Mar
9:28 am

Michael Garthwaite

LEAHI-273: code review comments

Options
    • -2
    • +0
    ./ModeGenPermeate.c
  2. … 2 more files in changeset.
Thursday 13 Mar
2:33 pm

Michael Garthwaite

LEAHI-273: code review comments.

Options
    • -4
    • +8
    ./ModeGenPermeate.c
  2. … 2 more files in changeset.
Tuesday 11 Mar
10:04 am

Michael Garthwaite

LEAHI-273: code review comments. Swapped level enums to be a more intuitive

Options
    • -10
    • +5
    ./ModeGenPermeate.c
  2. … 2 more files in changeset.
9:37 am

Michael Garthwaite

LEAHI-273: removed boost pump include from gen permeate.

Options
    • -2
    • +1
    ./ModeGenPermeate.c
9:33 am

Michael Garthwaite

LEAHI-273: changed RO request from an override variable to U32. Added fault id for GENP invalid state.

Options
    • -4
    • +4
    ./ModeGenPermeate.c
  2. … 2 more files in changeset.
9:29 am

Michael Garthwaite

LEAHI-273: code review comments

Options
    • -2
    • +2
    ./ModeGenPermeate.c
  2. … 1 more file in changeset.
9:17 am

Michael Garthwaite

LEAHI-273: code review comments.

Options
    • -57
    • +44
    ./ModeGenPermeate.c
  2. … 2 more files in changeset.
Thursday 06 Mar
11:37 am

Michael Garthwaite

LEAHI-273: basic path of permeate tank control

Options
    • -4
    • +86
    ./ModeGenPermeate.c
  2. … 2 more files in changeset.
Wednesday 05 Mar
8:21 am

Michael Garthwaite

LEAHI-273: various fixes found in code review.

Options
    • -9
    • +5
    ./ModeGenPermeate.c
  2. … 8 more files in changeset.
Tuesday 04 Mar
1:21 pm

Michael Garthwaite

Init commit for generate water

created DD interface, and mode gen permeate. Tank Switching logic is in progress.

Options
    • -0
    • +265
    ./ModeGenPermeate.c
  2. … 8 more files in changeset.