This is for alpha

Is this code for alpha or beta? getCurrentOperationMode() will only return DD modes in beta.

roRRAvg is an input.

roRejectionRatioTankFill is an input.

roRejectionRatio is an input.

roRRTankFillAvg is an input.

Update inputs/outputs.

Add message for Reject Ratio data.

Update inputs/outputs.

Update inputs/outputs.

Update inputs/outputs.

We have an alarm in this function. Should note it in function header.

fixed. thanks!

· /firmware/App/Controllers/PermeateTank.c	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/ROPump.c	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Drivers/FluidPump.c	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Modes/FPModeStandby.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Modes/FlushFilter.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Modes/FlushPermeate.c	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenPermeate.c	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.h	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Monitors/WaterQualityMonitor.c	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Monitors/WaterQualityMonitor.h	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-5, +5)	| History	| Source	| Diff

]]> Thu, 18 Dec 2025 10:58:24 -0800 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=bea0e00df103bb3b9a3f45113a8654ee5b8130e5 https://devapps.diality.us/changelog/ro-firmware?cs=bea0e00df103bb3b9a3f45113a8654ee5b8130e5 Michael Garthwaite committed bea0e00 on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware LDT-2116: code review comments

· /firmware/App/Monitors/Conductivity.h

(-5, +5)

| History

| Source

| Diff

]]> Thu, 18 Dec 2025 10:30:29 -0800 Dara Navaei https://devapps.diality.us/changelog/ro-firmware?cs=3450e7d1de68096365b3d05e693a1101172f2d78 https://devapps.diality.us/changelog/ro-firmware?cs=3450e7d1de68096365b3d05e693a1101172f2d78 Dara Navaei committed 3450e7d on branch LDT-2116-iofp-evaluate-closing-p39, staging in ro-firmware Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

· /firmware/App/FPCommon.h

(-4, +4)

| History

| Source

| Diff

]]> Thu, 18 Dec 2025 10:27:26 -0800 Dara Navaei https://devapps.diality.us/changelog/ro-firmware?cs=ca95dc70d5ef02c5c40b67d095e9a4d56783d967 https://devapps.diality.us/changelog/ro-firmware?cs=ca95dc70d5ef02c5c40b67d095e9a4d56783d967 Dara Navaei committed ca95dc7 on branch LDT-2116-iofp-evaluate-closing-p39, staging in ro-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BoostPump.c	(-6, +6)	| History	| Source	| Diff
· /firmware/App/Controllers/BoostPump.h	(-6, +6)	| History	| Source	| Diff
· /firmware/App/Controllers/PermeateTank.c	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/PermeateTank.h	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/ROPump.c	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Controllers/ROPump.h	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.h	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivitySensor.c	(-6, +6)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivitySensor.h	(-6, +6)	| History	| Source	| Diff
· /firmware/App/Drivers/FlowSensor.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Drivers/FlowSensor.h	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Drivers/FluidPump.c	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Drivers/FluidPump.h	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Drivers/InternalADC.c	(-0, +16)	| History	| Source	| Diff
… 67 more files in changeset.

]]> Thu, 18 Dec 2025 10:14:20 -0800 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1773-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1773-1 Michael Garthwaite Closed LEAHI-RO-FIRMWARE-LDT-1773-1 ]]> Mon, 08 Dec 2025 18:46:11 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1/#c25642 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1/#c25642 Vendor - TEL - Sameer Poyil commented on LEAHI-RO-FIRMWARE-LDT-2116-1

comments should start with capital letter

Once Dara enable the copyright script, that will handle it

Structure packing statement missing. add it even if not required

is this year correct ?

Resolved Thanks

· /firmware/App/Services/Messaging.c

(-1, +16)

| History

| Source

| Diff

]]> Mon, 24 Nov 2025 10:08:26 -0800 Raghu Kallala https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1/#c25257 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1/#c25257 Raghu Kallala replied to Vendor - TEL - Sameer Poyil in LEAHI-RO-FIRMWARE-LDT-2116-1

Will fix on Beta branch to avoid changes to Dialin

· /firmware/App/Controllers/PermeateTank.c	(-5, +3)	| History	| Source	| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-1, +0)	| History	| Source	| Diff
· /firmware/App/Modes/FlushFilter.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-1, +2)	| History	| Source	| Diff

]]> Sat, 22 Nov 2025 12:52:48 -0800 Raghu Kallala https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1/#c25255 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1/#c25255 Raghu Kallala replied to Sean Nash in LEAHI-RO-FIRMWARE-LDT-2116-1

Fixed. Thanks

Fixed. Thanks

· /firmware/App/Modes/ModeGenPermeate.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-1, +1)	| History	| Source	| Diff

]]>