td-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3505: Hardcoded Force Sensor Calibration Data

    • -17
    • +26
    /firmware/App/Controllers/SyringePump.c
Added

Added

Updated

Updated

Updated

Updated

Yes, removed

Yes, removed

Yes, moved to different place

Yes, moved to different place

Yes, updated

Yes, updated

Used in handle function

Used in handle function

added

added

Yes added

Yes added

LDT-4033-patient-vitals-fw-implementation

LDT-4033-patient-vitals-fw-implementation

    • -35
    • +196
    /firmware/App/Controllers/BPModule.c
    • -40
    • +106
    /firmware/App/Drivers/BPDriver.c
I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

Use OVERRIDE_RESET for .override instead of 0.

Use OVERRIDE_RESET for .override instead of 0.

We can rename priorState to previousInstallState. Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

We can rename priorState to previousInstallState.
Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

LDT-1886: Add send event

SW fault here?

SW fault here?

Do we need this state if all it's doing is going to IDLE?

Do we need this state if all it's doing is going to IDLE?

Might have to wait for module to not be busy before getting the data.

Might have to wait for module to not be busy before getting the data.

I think we may need to give a get data command here.

I think we may need to give a get data command here.

Look for request flag to give measure command and transition to measure state.

Look for request flag to give measure command and transition to measure state.

Write private handle functions for each state and call them in each case.

Write private handle functions for each state and call them in each case.

Should we also check whether bpMeasurementReady is TRUE?

Should we also check whether bpMeasurementReady is TRUE?

Same.

Same.

Same. Set a request flag to TRUE (for Peds this time) and let the state machine do the rest.

Same. Set a request flag to TRUE (for Peds this time) and let the state machine do the rest.

Don't change state from outside signal. We should just set a requestBPMeasurement flag to TRUE in this function (if current state is IDLE) and then when the state machine runs next, the IDLE state ...

Don't change state from outside signal. We should just set a requestBPMeasurement flag to TRUE in this function (if current state is IDLE) and then when the state machine runs next, the IDLE state should look for this flag to be TRUE and transition to MEASURE state (by doing all of these things you have here in this function).

Change comment to "Number of BP driver states."

Change comment to "Number of BP driver states."

LDT-4033-patient-vitals-fw-implementation