td-firmware

Clone Tools

Stats

Commits this week: 31
Total Committers: 18
Last Commit: 22 Jul
Commits this week: 31

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 22 Jul
1:19 pm

Vendor - TEL - Praneeth Bunne

LDT-4040: Address CR comments

Options
    • -2
    • +2
    /firmware/App/Modes/ModeTreatment.h
    • -9
    • +9
    /firmware/App/Modes/StateTxRinseback.c
11:32 am

Sean Nash

Swap order of == for these 2 if statements - put constant on left side.

Swap order of == for these 2 if statements - put constant on left side.

11:19 am

Sean Nash

Why?

Why?

11:16 am

Sean Nash

Why is UF volume being added here? If we add it, we need to change DD f/w too. But it is not clear to me why DD f/w needs to know the UF volume.

Why is UF volume being added here? If we add it, we need to change DD f/w too. But it is not clear to me why DD f/w needs to know the UF volume.

11:14 am

Sean Nash

Use ternary operator to explicitly set to TRUE or FALSE.

Use ternary operator to explicitly set to TRUE or FALSE.

10:53 am

suresh

LDT:4049- addressed review comments

Options
    • -2
    • +0
    /firmware/App/Drivers/RotaryValve.h
    • -5
    • +7
    /firmware/App/Modes/ModeInitPOST.c
    • -1
    • +1
    /firmware/App/Modes/ModeInitPOST.h
    • -11
    • +13
    /firmware/App/Modes/ModeStandby.c
    • -1
    • +3
    /firmware/App/Services/DDInterface.c
    • -1
    • +1
    /firmware/App/Services/DDInterface.h
    • -8
    • +0
    /firmware/App/Services/Messaging.h
9:31 am

Sean Nash

Our TODO comments are all CAPs.

Our TODO comments are all CAPs.

9:25 am

Sean Nash

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

9:21 am

Sean Nash

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

9:19 am

Sean Nash

Should return T/F. Change comment to "TRUE if DD f/w is compatible with TD f/w, FALSE if not.".

Should return T/F. Change comment to "TRUE if DD f/w is compatible with TD f/w, FALSE if not.".

9:18 am

Sean Nash

Should return a BOOL (that is what ModeStandby is expecting).

Should return a BOOL (that is what ModeStandby is expecting).

9:18 am

Sean Nash

Fix isDDCompatible() function so that it returns a T/F instead of a compatibility revision.

Fix isDDCompatible() function so that it returns a T/F instead of a compatibility revision.

9:16 am

Sean Nash

Align comment.

Align comment.

9:15 am

Sean Nash

Why are these added? And why commented out. H13 and H20 are not rotary valves - they are 3 way valves. They do not belong here.

Why are these added? And why commented out. H13 and H20 are not rotary valves - they are 3 way valves. They do not belong here.

Tuesday 21 Jul
10:13 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Messaging ID configuration

Options
    • -0
    • +1
    /firmware/App/Controllers/AirPump.h
    • -0
    • +1
    /firmware/App/Services/Messaging.c
9:15 pm

suresh

LDT:4072-addressed review comments

Options
    • -4
    • +8
    /firmware/App/Drivers/BatteryDriver.c
    • -2
    • +2
    /firmware/App/Drivers/BatteryDriver.h
    • -10
    • +17
    /firmware/App/Monitors/Battery.c
8:48 pm

suresh

LDT:4049 Addressed review comments

Options
    • -317
    • +11
    /firmware/App/Modes/ModeStandby.c
6:18 pm

Sean Nash

Should we handle blood sitting timer before publish? Are we publishing anything re: blood sitting?

Should we handle blood sitting timer before publish? Are we publishing anything re: blood sitting?

6:07 pm

Sean Nash

Add TODO to these comments.

Add TODO to these comments.

5:45 pm

Sean Nash

I think ( setTxDur - preStop ) should be changed to ( preStop ). Also, I think preStop should be renamed to hepDurMin.

I think ( setTxDur - preStop ) should be changed to ( preStop ).
Also, I think preStop should be renamed to hepDurMin.

5:14 pm

Sean Nash

Add comments to right.

Add comments to right.

5:13 pm

Sean Nash

2 blank lines before and after.

2 blank lines before and after.

5:09 pm

Sean Nash

Move declarations into this if scope.

Move declarations into this if scope.

5:08 pm

Sean Nash

Remove blank line.

Remove blank line.

5:07 pm

Sean Nash

Remove (void)

Remove (void)

5:06 pm

Sean Nash

Library includes should come first and they should be in <>. Also add comment listing math functions you're using in this unit.

Library includes should come first and they should be in <>. Also add comment listing math functions you're using in this unit.

4:55 pm

Sean Nash

Change INPROGRESS to OPEN (because you're going to remove INPROGRESS).

Change INPROGRESS to OPEN (because you're going to remove INPROGRESS).

4:32 pm

Sean Nash

You can do this sendMessage just once after else.

You can do this sendMessage just once after else.

3:57 pm

suresh

LDT:4063- Addressed review comments

Options
    • -0
    • +4
    /firmware/App/Modes/ModeInitPOST.c
    • -32
    • +44
    /firmware/App/Modes/OperationModes.c
    • -8
    • +10
    /firmware/App/Monitors/Buttons.c
    • -1
    • +3
    /firmware/App/Services/Messaging.c
    • -7
    • +0
    /firmware/App/Services/Messaging.h
2:13 pm

Sean Nash

Should this be the "Load Syringe" alarm that you just added? Also, does this alarm show the user how much heparin to load into the syringe? I wasn't expecting this to be an alarm.

Should this be the "Load Syringe" alarm that you just added?
Also, does this alarm show the user how much heparin to load into the syringe? I wasn't expecting this to be an alarm.