td-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Changes

I think we should have handle functions that return next state for each of these cases (just like mode state machines).

I think we should have handle functions that return next state for each of these cases (just like mode state machines).

Remove extra blank lines and comment.

Remove extra blank lines and comment.

Remove extra blank lines.

Remove extra blank lines.

Changes

    • -26
    • +42
    /firmware/App/Controllers/Valves.c
Remove this comment?

Remove this comment?

Just have a comment here that says "Ok - do nothing."

Just have a comment here that says "Ok - do nothing."

If we don't need this code, remove it.

If we don't need this code, remove it.

Remove extra blank line.

Remove extra blank line.

Add a TODO comment to restore this when Noe fixes FPGA

Add a TODO comment to restore this when Noe fixes FPGA

Remove blank line.

Remove blank line.

Why commented out?

Why commented out?

Missing /// comment.

Missing /// comment.

Use /// comment.

Use /// comment.

Use a /// comment so doxygen sees it.

Use a /// comment so doxygen sees it.

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

not homed state.

not homed state.

Remove obsolete states from switch statement.

Remove obsolete states from switch statement.

Why is home command commented out?

Why is home command commented out?

We should initialize your new driver here.

We should initialize your new driver here.

The driver is already included in Valves.h, so we don't need it here.

The driver is already included in Valves.h, so we don't need it here.

Changes

Add a blank line between declarations and code.

Add a blank line between declarations and code.

Changes in Controller

Move details down to its own line.

Move details down to its own line.

Remove extra blank line.

Remove extra blank line.

Fix comment. Should say "in mL/min."

Fix comment. Should say "in mL/min."

Should this be the "Load Syringe" alarm that you just added?

Should this be the "Load Syringe" alarm that you just added?