Activity td-firmware/

3 mins ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3992-7
commented on review

Why are we commenting this out?

4 mins ago

Dara Navaei

More
0f2c8cb
changed 1 file
develop

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

- -1
- +1
/firmware/App/TDCommon.h
- History
- Source
- Diff
/firmware/App/TDCommon.h

5 mins ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3992-7
commented on review

Magic number. Make a #define. Should this command be sent here or in transition function of pre-tx mode?

Magic number. Make a #define.
Should this command be sent here or in transition function of pre-tx mode?

5 mins ago

Vendor - TEL - Varshini Nagabooshanam

More
b5bdf76
changed 8 files
develop

Merge Conflicts

- -35
- +63
/firmware/App/Modes/ModePreTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.c
- -4
- +4
/firmware/App/Modes/ModePreTreat.h
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.h
- -0
- +1
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c
- -1
- +1
/firmware/App/Modes/StatePreTxRecirculate.c
- History
- Source
- Diff
/firmware/App/.../StatePreTxRecirculate.c
- -14
- +4
/firmware/App/Services/DDInterface.c
- History
- Source
- Diff
/firmware/App/Services/DDInterface.c
- -2
- +2
/firmware/App/Services/DDInterface.h
- History
- Source
- Diff
/firmware/App/Services/DDInterface.h
- -2
- +3
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c
- -2
- +2
/firmware/App/TDCommon.h
- History
- Source
- Diff
/firmware/App/TDCommon.h

46 mins ago

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

More
c124da1
changed 4 files
LDT-4036-end-of-treatment---fw-implement LEAHI-TD-FIRMWARE-LDT-4036-1

Final changes

- -19
- +15
/firmware/App/Modes/ModeTreatment.c
- History
- Source
- Diff
/firmware/App/Modes/ModeTreatment.c
- -102
- +53
/firmware/App/Modes/TreatmentEnd.c
- History
- Source
- Diff
/firmware/App/Modes/TreatmentEnd.c
- -0
- +6
/firmware/App/Services/Messaging.h
- History
- Source
- Diff
/firmware/App/Services/Messaging.h
- -5
- +0
/firmware/App/Services/TxParams.c
- History
- Source
- Diff
/firmware/App/Services/TxParams.c

52 mins ago

Vendor - TEL - Varshini Nagabooshanam

1 hr ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3992-7
commented on review

Why are we ending air trap control here?

1 hr ago

Dara Navaei

More
3e4642a
changed 1 file
LDT-5613-disposable-tube-self-test-fw-implementation, staging

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

- -1
- +1
/firmware/App/TDCommon.h
- History
- Source
- Diff
/firmware/App/TDCommon.h

1 hr ago

Dara Navaei

More
ef261ee
changed 12 files
LDT-5613-disposable-tube-self-test-fw-implementation, staging

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
/firmware/App/Controllers/Valves.c
- History
- Source
- Diff
/firmware/App/Controllers/Valves.c
- -1
- +1
/firmware/App/Drivers/PinchValve.c
- History
- Source
- Diff
/firmware/App/Drivers/PinchValve.c
- -2
- +2
/firmware/App/Modes/ModePreTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.c
- -2
- +2
/firmware/App/Modes/ModePreTreat.h
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.h
- -2
- +2
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c
- -2
- +2
/firmware/App/Services/AlarmMgmtSWFaults.h
- History
- Source
- Diff
/firmware/App/.../AlarmMgmtSWFaults.h
- -1
- +1
/firmware/App/Services/DDInterface.c
- History
- Source
- Diff
/firmware/App/Services/DDInterface.c
- -1
- +1
/firmware/App/Services/FpgaTD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaTD.c
- -1
- +1
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c
- -2
- +2
/firmware/App/Services/StateServices/DrySelfTests.c
- History
- Source
- Diff
/firmware/App/.../DrySelfTests.c
- -2
- +2
/firmware/App/Services/StateServices/DrySelfTests.h
- History
- Source
- Diff
/firmware/App/.../DrySelfTests.h
- -1
- +1
/firmware/App/TDCommon.h
- History
- Source
- Diff
/firmware/App/TDCommon.h

1 hr ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3992-7
commented on review

Why is this commented out?

1 hr ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3992-7
commented on review

Add one more blank line before test support banner.

1 hr ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3992-7
commented on review

Remove these blank lines.

2 hrs ago

Vendor - TEL - Suresh Dharnala

More
00f98c3
changed 5 files
LDT-4050-post-treatment---fw-implementat LEAHI-TD-FIRMWARE-LDT-4050-1

LDT-4050: addressed comments

- -110
- +175
/firmware/App/Modes/ModePostTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePostTreat.c
- -4
- +4
/firmware/App/Modes/ModePostTreat.h
- History
- Source
- Diff
/firmware/App/Modes/ModePostTreat.h
- -104
- +168
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c
- -94
- +0
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c
- -2
- +6
/firmware/App/Services/Messaging.h
- History
- Source
- Diff
/firmware/App/Services/Messaging.h

10:59 pm

Michael Garthwaite

More
a89b071
changed 10 files
LDT-4611-hdf-fw-implementation-5-4 LEAHI-TD-FIRMWARE-LDT-4611-4

Merge branch 'staging' into LDT-4611-hdf-fw-implementation-5-4

- -44
- +398
/firmware/App/Modes/ModePreTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.c
- -88
- +200
/firmware/App/Modes/ModeTreatment.c
- History
- Source
- Diff
/firmware/App/Modes/ModeTreatment.c
- -1
- +2
/firmware/App/Modes/StateTxDialysis.c
- History
- Source
- Diff
/firmware/App/Modes/StateTxDialysis.c
- -33
- +19
/firmware/App/Modes/StateTxPaused.c
- History
- Source
- Diff
/firmware/App/Modes/StateTxPaused.c
- -2
- +9
/firmware/App/Services/AlarmMgmtSWFaults.h
- History
- Source
- Diff
/firmware/App/.../AlarmMgmtSWFaults.h
- -3
- +34
/firmware/App/Services/DDInterface.c
- History
- Source
- Diff
/firmware/App/Services/DDInterface.c
- -2
- +3
/firmware/App/Services/DDInterface.h
- History
- Source
- Diff
/firmware/App/Services/DDInterface.h
- -21
- +174
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c
- -1
- +28
/firmware/App/Services/StateServices/TubeSetInstall.c
- History
- Source
- Diff
/firmware/App/.../TubeSetInstall.c
- -3
- +11
/firmware/App/Tasks/TaskGeneral.c
- History
- Source
- Diff
/firmware/App/Tasks/TaskGeneral.c

4:38 pm

Michael Garthwaite and Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-2240-1
finished reviewing

3:39 pm

Vendor - TEL - Praneeth Bunne

More
e846784
changed 1 file
LDT-3992-disposable-tube-set-auto-priming LEAHI-TD-FIRMWARE-LDT-3992-7

LDT-3992: Fixed issues

- -6
- +5
/firmware/App/Services/StateServices/Prime.c
- History
- Source
- Diff
/firmware/App/.../StateServices/Prime.c

3:25 pm

Vendor - TEL - Praneeth Bunne

3:06 pm

Vendor - TEL - Varshini Nagabooshanam

More
a698184
changed 2 files
LDT-2240-disposable-tube-set-self-test, LDT-5613-disposable-tube-self-test-fw-implementation and 2 more LEAHI-TD-FIRMWARE-LDT-2240-1

Changes

- -0
- +1
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c
- -2
- +2
/firmware/App/Services/StateServices/DrySelfTests.c
- History
- Source
- Diff
/firmware/App/.../DrySelfTests.c

2:57 pm

Vendor - TEL - Varshini Nagabooshanam

More
4919e98
changed 1 file
LDT-2240-disposable-tube-set-self-test, LDT-5613-disposable-tube-self-test-fw-implementation and 2 more LEAHI-TD-FIRMWARE-LDT-2240-1

Changes

- -2
- +2
/firmware/App/TDCommon.h
- History
- Source
- Diff
/firmware/App/TDCommon.h

2:40 pm

Vendor - TEL - Varshini Nagabooshanam

More
398966c
changed 1 file
LDT-2240-disposable-tube-set-self-test, LDT-5613-disposable-tube-self-test-fw-implementation and 2 more LEAHI-TD-FIRMWARE-LDT-2240-1

Changes

- -2
- +3
/firmware/App/Drivers/PinchValve.c
- History
- Source
- Diff
/firmware/App/Drivers/PinchValve.c

2:33 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-2240-1
replied to Vendor - TEL - Varshini Nagabooshanam

Doesn't look fixed. 717 and 732 are swapped (and so out of order). This array should be in order by rank.

2:20 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

2:19 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

2:18 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

2:18 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, Fixed

2:18 pm

Vendor - TEL - Varshini Nagabooshanam

Agree Fixed

2:15 pm

Vendor - TEL - Varshini Nagabooshanam

More
b5fdf61
changed 6 files
LDT-2240-disposable-tube-set-self-test, LDT-5613-disposable-tube-self-test-fw-implementation and 2 more LEAHI-TD-FIRMWARE-LDT-2240-1

Changes

- -3
- +3
/firmware/App/Drivers/PinchValve.c
- History
- Source
- Diff
/firmware/App/Drivers/PinchValve.c
- -2
- +1
/firmware/App/Modes/ModePreTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.c
- -3
- +3
/firmware/App/Modes/ModePreTreat.h
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.h
- -3
- +3
/firmware/App/Services/DDInterface.c
- History
- Source
- Diff
/firmware/App/Services/DDInterface.c
- -0
- +1
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c
- -3
- +0
/firmware/App/Services/StateServices/DrySelfTests.c
- History
- Source
- Diff
/firmware/App/.../DrySelfTests.c

2:13 pm

Vendor - TEL - Varshini Nagabooshanam

No fixed

2:12 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

2:11 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

td-firmware

Stats

Commits this week: 79

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Sean Nash

Dara Navaei

Sean Nash

Vendor - TEL - Varshini Nagabooshanam

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Vendor - TEL - Varshini Nagabooshanam

Sean Nash

Dara Navaei

Dara Navaei

Sean Nash

Sean Nash

Sean Nash

Vendor - TEL - Suresh Dharnala

Michael Garthwaite

Michael Garthwaite and Sean Nash

Vendor - TEL - Praneeth Bunne

Vendor - TEL - Praneeth Bunne

Vendor - TEL - Varshini Nagabooshanam

Vendor - TEL - Varshini Nagabooshanam

Vendor - TEL - Varshini Nagabooshanam

Sean Nash

Vendor - TEL - Varshini Nagabooshanam

Vendor - TEL - Varshini Nagabooshanam

Vendor - TEL - Varshini Nagabooshanam

Vendor - TEL - Varshini Nagabooshanam

Vendor - TEL - Varshini Nagabooshanam

Vendor - TEL - Varshini Nagabooshanam

Vendor - TEL - Varshini Nagabooshanam

Vendor - TEL - Varshini Nagabooshanam

Vendor - TEL - Varshini Nagabooshanam