td-firmware / firmware / App / Controllers

Valves.c

Clone Tools

Stats

Commits this week: 3
Total Committers: 3
Last Commit: 11 Dec
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 11 Dec
10:15 am

Vendor - TEL - Sameer Poyil

move static function after public function

move static function after public function

10:14 am

Vendor - TEL - Sameer Poyil

let public function on top

let public function on top

10:11 am

Vendor - TEL - Sameer Poyil

Let all public functions come on top for all files

Let all public functions come on top for all files

Tuesday 09 Dec
9:48 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Valves.c
  2. … 3 more files in changeset.
9:45 am

Dara Navaei

Merge branch 'LDT-1886-blood-set-auto-load-and-auto-eject-implement-ejector-sensor' into develop

Options
    • -11
    • +3
    ./Valves.c
  2. … 3 more files in changeset.
Friday 05 Dec
2:55 pm

Sean Nash

Should we comment this out before merging?

Should we comment this out before merging?

2:11 pm

Sean Nash

2:10 pm

Dara Navaei

LDT-1886 updated the ejector and valves modules after testing

Options
    • -11
    • +3
    ./Valves.c
  2. … 2 more files in changeset.
Wednesday 03 Dec
10:15 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Valves.c
  2. … 7 more files in changeset.
10:13 am

Dara Navaei

Merge branch 'LDT-1886-blood-set-auto-load-and-auto-eject-implement-ejector-sensor' into develop

Options
    • -100
    • +47
    ./Valves.c
  2. … 7 more files in changeset.
10:12 am

Dara Navaei

LDT-1886 addressed the code review comments

Options
    • -1
    • +1
    ./Valves.c
  2. … 3 more files in changeset.
Tuesday 02 Dec
9:50 am

Dara Navaei

Done

Done

9:49 am

Dara Navaei

Done

Done

9:16 am

Sean Nash

Align =

Align =

9:14 am

Sean Nash

Should be 2 blank lines above/below test banner.

Should be 2 blank lines above/below test banner.

Monday 01 Dec
2:31 pm

Dara Navaei

LDT-1886 updated the pinch valves homing sequence

Options
    • -100
    • +47
    ./Valves.c
  2. … 5 more files in changeset.
9:44 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -5
    • +5
    ./Valves.c
  2. … 95 more files in changeset.
9:43 am

Dara Navaei

Done

Done

9:11 am

Sean Nash

Should we initialize to inactive (and use #define)?

Should we initialize to inactive (and use #define)?

Wednesday 26 Nov
8:58 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -0
    • +16
    ./Valves.c
8:50 pm

Dara Navaei

Cleared the copyright

Options
    • -16
    • +1
    ./Valves.c
8:35 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -5
    • +5
    ./Valves.c
  2. … 90 more files in changeset.
Tuesday 25 Nov
4:01 pm

Dara Navaei

Took note that the FPGA interface is at the driver level.

Took note that the FPGA interface is at the driver level.

4:01 pm

Dara Navaei

Done

Done

1:56 pm

Sean Nash

Should this be an enum at driver level? Driver get would return enum so controller doesn't have to figure out what it means.

Should this be an enum at driver level? Driver get would return enum so controller doesn't have to figure out what it means.

1:48 pm

Sean Nash

Use U32 unless there is a good reason to use U08.

Use U32 unless there is a good reason to use U08.

1:46 pm

Sean Nash

Why bypassing driver here?

Why bypassing driver here?

1:45 pm

Sean Nash

Why are we bypassing driver here?

Why are we bypassing driver here?

1:24 pm

Sean Nash

Then your doxygen return comment looks backward.

Then your doxygen return comment looks backward.

1:23 pm

Sean Nash

Why is controller bypassing driver to get to fpga?

Why is controller bypassing driver to get to fpga?