td-firmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 6
Total Committers: 13
Last Commit: 09 Jul
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 09 Jul
2:07 pm

Sean Nash

What alarm is this? It doesn't look like you've added a new alarm. This is one of the reserved (unused) alarms that UI s/w might use.

What alarm is this? It doesn't look like you've added a new alarm. This is one of the reserved (unused) alarms that UI s/w might use.

1:36 pm

Sean Nash

Do we really need these setup functions for each state? They all look very simple - just 1 or 2 lines of code.

Do we really need these setup functions for each state? They all look very simple - just 1 or 2 lines of code.

1:33 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4040_Rinseback - FW Implementation - 3/10:
LEAHI-TD-FIRMWARE-LDT-4040_Rinseback - FW Implementation - 3/10:
1:32 pm

Sean Nash

I believe the SyringePump controller will trigger this alarm at end of seek operation.

I believe the SyringePump controller will trigger this alarm at end of seek operation.

1:28 pm

Sean Nash

Syringe pump should already be stopped if preload is done. Do we need to call this here?

Syringe pump should already be stopped if preload is done. Do we need to call this here?

1:24 pm

Sean Nash

This is called from preload state. Not needed here I think.

This is called from preload state. Not needed here I think.

1:22 pm

Sean Nash

Don't put comments on function prototypes. Doxygen gets details of functions from the function header.

Don't put comments on function prototypes. Doxygen gets details of functions from the function header.

1:20 pm

Sean Nash

Why (void)?

Why (void)?

1:16 pm

Sean Nash

Where is this being called? Should be called from pre-treatment init I think.

Where is this being called? Should be called from pre-treatment init I think.

1:13 pm

Sean Nash

Confirmation signal sounds like a message handler from UI. Message handlers must accept a message as parameter and return BOOL. They must also be added to the message handler table in Messaging.c.

Confirmation signal sounds like a message handler from UI. Message handlers must accept a message as parameter and return BOOL. They must also be added to the message handler table in Messaging.c.

1:11 pm

Sean Nash

Why are we signaling syringe load confirmed here?

Why are we signaling syringe load confirmed here?

1:11 pm

Sean Nash

Do these states need to be public?

Do these states need to be public?

1:08 pm

Sean Nash

Move up one row to alphabetize.

Move up one row to alphabetize.

Tuesday 07 Jul
3:16 pm

Sean Nash

3:16 pm

Sean Nash

Monday 06 Jul
1:07 pm

Sean Nash

I would keep blank line between library includes and regular includes.

I would keep blank line between library includes and regular includes.

1:05 pm

Sean Nash

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added. I think you should just remove this new alarm 196...

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added.
I think you should just remove this new alarm 196 that you've added here.

10:56 am

Vendor - TEL - Praneeth Bunne

Thursday 02 Jul
3:06 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

2:42 pm

Sean Nash

Align =

Align =

2:41 pm

Sean Nash

Should modality be an enum type?

Should modality be an enum type?

2:41 pm

Sean Nash

Align =

Align =

2:40 pm

Sean Nash

Should this be an enum type?

Should this be an enum type?

1:47 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4029_Pre-Treatment - FW Implementation - 4/6:
LEAHI-TD-FIRMWARE-LDT-4029_Pre-Treatment - FW Implementation - 4/6:
10:10 am

Sean Nash

10:05 am

Vendor - TEL - Varshini Nagabooshanam

Wednesday 01 Jul
10:28 pm

Dara Navaei

1:36 pm

Sean Nash

What is the 3rd modality?

What is the 3rd modality?

1:26 pm

Sean Nash

Return type should be an enum (TREATMENT_TYPE_T).

Return type should be an enum (TREATMENT_TYPE_T).

1:24 pm

Sean Nash

Return type should be an enum (FLUID_BOLUS_MEDIUM_T).

Return type should be an enum (FLUID_BOLUS_MEDIUM_T).