td-firmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 17
Total Committers: 13
Last Commit: 04 Aug
Commits this week: 17

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
24 mins ago

Sean Nash

Tuesday 04 Aug
2:16 pm

Vendor - TEL - Jashwant Gantyada

updated

updated

2:16 pm

Vendor - TEL - Jashwant Gantyada

updated

updated

2:15 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

2:15 pm

Vendor - TEL - Jashwant Gantyada

updated

updated

2:14 pm

Vendor - TEL - Jashwant Gantyada

removed.

removed.

2:13 pm

Vendor - TEL - Praneeth Bunne

LDT-4040: Resolve CR comments, merge latest staging & resolve merge conflicts

Options
    • -17
    • +14
    ./ModeTreatment.c
    • -3
    • +3
    ./StateTxBloodPrime.c
    • -17
    • +30
    ./StateTxPaused.c
    • -5
    • +17
    ./StateTxRecirc.c
    • -39
    • +65
    ./StateTxRinseback.c
  6. … 7 more files in changeset.
1:52 pm

Vendor - TEL - Jashwant Gantyada

LDT-4009 addressed code review comments

Options
    • -1
    • +0
    ./ModeTreatment.c
    • -1
    • +1
    ./StateTxIsolatedUF.c
  3. … 1 more file in changeset.
1:14 pm

Vendor - TEL - Praneeth Bunne

initialized using resetRinsebackFlags()

initialized using resetRinsebackFlags()

1:03 pm

Vendor - TEL - Praneeth Bunne

those are initialized in resetTreatmentRecircFlags() and that is called in init

those are initialized in resetTreatmentRecircFlags() and that is called in init

12:23 pm

Sean Nash and Vendor - TEL - Arpita Srivastava

11:16 am

Vendor - TEL - Arpita Srivastava

align comment

align comment

11:11 am

suresh

LDT-4063: Addressed review comments

Options
    • -1
    • +3
    ./OperationModes.c
  2. … 1 more file in changeset.
11:02 am

Vendor - TEL - Varshini Nagabooshanam

Merge conflicts

Options
    • -4
    • +4
    ./ModeTreatment.c
  2. … 3 more files in changeset.
10:22 am

Vendor - TEL - Varshini Nagabooshanam

Changes

Options
    • -1
    • +0
    ./ModeStandby.c
  2. … 3 more files in changeset.
10:13 am

Vendor - TEL - Arpita Srivastava

When we send any message to UI, usually add the message id in the doxygen header like this. @details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the function s...

When we send any message to UI, usually add the message id in the doxygen header like this.

@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE

Please refer to the function sendTreatmentParamsResponse()

10:05 am

Vendor - TEL - Arpita Srivastava

When we send any message to UI, usually add the message id in the doxygen header like this. *@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the functi...

When we send any message to UI, usually add the message id in the doxygen header like this.

  • @details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE


Please refer to the function sendTreatmentParamsResponse()

10:05 am

Vendor - TEL - Arpita Srivastava

When we send any message to UI, usually add the message id in the doxygen header like this. *@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the functi...

When we send any message to UI, usually add the message id in the doxygen header like this.

  • @details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE


Please refer to the function sendTreatmentParamsResponse()

9:55 am

Vendor - TEL - Arpita Srivastava

It looks like the rows may be misaligned with the alarm ID declarations. For example, ALARM_ID_TD_SAFETY_SHUTDOWN_POST_TEST_FAILED is declared as 207.

It looks like the rows may be misaligned with the alarm ID declarations.
For example, ALARM_ID_TD_SAFETY_SHUTDOWN_POST_TEST_FAILED is declared as 207.

9:53 am

Vendor - TEL - Arpita Srivastava

Should Instructions part be this? A problem was detected with the hemodialysis device.

Should Instructions part be this?

A problem was detected with the hemodialysis device.

9:50 am

Vendor - TEL - Arpita Srivastava

Please confirm if the source is DD?

Please confirm if the source is DD?

Monday 03 Aug
3:01 pm

suresh

LDT-4063: Addressed review comments

Options
    • -1
    • +1
    ./ModeInitPOST.c
2:32 pm

Sean Nash

2:31 pm

suresh

LDT-4063: Addressed review comments

Options
    • -78
    • +61
    ./ModeInitPOST.c
    • -9
    • +18
    ./OperationModes.c
  3. … 6 more files in changeset.
Friday 31 Jul
7:09 pm

Vendor - TEL - Vijay Pamula

LDT-4031:Addressed review comments

Options
    • -6
    • +6
    ./ModePreTreat.c
7:06 pm

Vendor - TEL - Vijay Pamula

LDT-4029:Addressed review comments

Options
    • -3
    • +3
    ./StatePreTxHeparinSetup.c
4:24 pm

Vendor - TEL - Vijay Pamula

LDT-4029:Addressed review comments

Options
    • -2
    • +3
    ./StatePreTxHeparinSetup.c
4:16 pm

Vendor - TEL - Vijay Pamula

LDT-4031:Addressed review comments

Options
    • -7
    • +10
    ./ModePreTreat.c
11:10 am

Vendor - TEL - Arpita Srivastava

While you are updating this file, can please break this line?

While you are updating this file, can please break this line?

11:08 am

Vendor - TEL - Arpita Srivastava

Can we align like this result = u32BroadcastIntervalOverride( message, &preTreatmentStatePublishInterval, TASK_GENERAL_INTERVAL );

Can we align like this
result = u32BroadcastIntervalOverride( message,
&preTreatmentStatePublishInterval,
TASK_GENERAL_INTERVAL );