td-firmware / firmware / App / Monitors

Battery.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 1
Last Commit: 16:24
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
6 hrs ago

suresh

LDT-4072: Address code review comments

Options
    • -0
    • +92
    ./Battery.h
  2. … 9 more files in changeset.
Friday 15 May
6:12 pm

Sean Nash

Call the init for the battery driver here.

Call the init for the battery driver here.

6:11 pm

Sean Nash

INVALID_BATTERY

INVALID_BATTERY

5:52 pm

Sean Nash

Remove repeating entries.

Remove repeating entries.

5:49 pm

Sean Nash

remove extra blank line.

remove extra blank line.

5:48 pm

Sean Nash

Remove this comment.

Remove this comment.

5:48 pm

Sean Nash

Remove blank line.

Remove blank line.

5:47 pm

Sean Nash

initialize all of these in init function.

initialize all of these in init function.

5:47 pm

Sean Nash

Missing doxygen group

Missing doxygen group

5:46 pm

Sean Nash

These should be in alphabetical order.

These should be in alphabetical order.

5:45 pm

Sean Nash

Update all function headers to Leahi format (e.g. input and output have a \b to make them bold).

Update all function headers to Leahi format (e.g. input and output have a \b to make them bold).

5:21 pm

Sean Nash

Add blank line after banner

Add blank line after banner

5:20 pm

Sean Nash

Add blank line after banner

Add blank line after banner

5:17 pm

Sean Nash

Add a blank line after banner. Initialize in init function instead of here.

Add a blank line after banner.

Initialize in init function instead of here.

5:17 pm

Sean Nash

Move all but I2CBatteryStatus override functions to the battery monitor.

Move all but I2CBatteryStatus override functions to the battery monitor.

5:15 pm

Sean Nash

Move definitions to top (above functions).

Move definitions to top (above functions).

5:12 pm

Sean Nash

BatteryDriver

BatteryDriver

5:12 pm

Sean Nash

Use Leahi function format and helper functions for overrides.

Use Leahi function format and helper functions for overrides.

5:10 pm

Sean Nash

Should have a doxygen group (like driver does).

Should have a doxygen group (like driver does).

5:10 pm

Sean Nash

Should be BatteryDriver?

Should be BatteryDriver?

5:09 pm

Sean Nash

should be below and use "" instead of <>

should be below and use "" instead of <>

Thursday 07 May
9:07 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4072_Power Loss - FW Implementation - 2/3:
LEAHI-TD-FIRMWARE-LDT-4072_Power Loss - FW Implementation - 2/3: