td-firmware / firmware / App / Services

DDInterface.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 3
Last Commit: 11 Dec
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 09 Dec
9:58 am

Sean Nash

I didn't see this in header file.

I didn't see this in header file.

9:57 am

Sean Nash

I don't see these Lower/Upper Range Limit functions declared in the header file.

I don't see these Lower/Upper Range Limit functions declared in the header file.

9:33 am

Sean Nash

Need to delete this unit (ModeTxParams.c/.h). Also need to remove the mode from the modes enumeration and from OperationModes.c.

Need to delete this unit (ModeTxParams.c/.h). Also need to remove the mode from the modes enumeration and from OperationModes.c.

9:32 am

Sean Nash

I don't think we need this signal function since this is not a mode anymore. Is this function being called somewhere?

I don't think we need this signal function since this is not a mode anymore. Is this function being called somewhere?

Monday 08 Dec
1:11 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

1:11 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

1:11 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

11:17 am

Sean Nash

I don't see an isTreatmentParamInRange function. I think we need to copy from the ModeTxParams.c.

I don't see an isTreatmentParamInRange function. I think we need to copy from the ModeTxParams.c.

11:16 am

Sean Nash

I don't see any get functions. I think we need to copy from ModeTxParams.c. Let's make sure we've copied all needed functions from ModeTxParams.c and then don't forget to delete ModeTxParams.c/.h.

I don't see any get functions. I think we need to copy from ModeTxParams.c.
Let's make sure we've copied all needed functions from ModeTxParams.c and then don't forget to delete ModeTxParams.c/.h.

11:14 am

Sean Nash

Missing return statement.

Missing return statement.

11:14 am

Sean Nash

Add a blank line between declaration and if statement.

Add a blank line between declaration and if statement.

10:58 am

Sean Nash

Message handler functions must have a single parameter (message). The payload of the message will have the param and value in it and this function needs to parse them out of the payload. Also need ...

Message handler functions must have a single parameter (message). The payload of the message will have the param and value in it and this function needs to parse them out of the payload. Also need to check payload length first.
We need a new message ID in MsgDefs.h for Dialin to send us this message and we need to add an entry in the message/handler table in Messaging.c.

10:53 am

Sean Nash

Add one more blank line above test support banner.

Add one more blank line above test support banner.

Friday 05 Dec
1:33 pm

Sean Nash

Do we need a Dialin Tx param set message and message handling function (like HD in Denali had)?

Do we need a Dialin Tx param set message and message handling function (like HD in Denali had)?

12:12 pm

Vendor - TEL - Varshini Nagabooshanam

Removed and Updated

Removed and Updated

12:11 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:11 pm

Vendor - TEL - Varshini Nagabooshanam

By mistake, I forget to remove

By mistake, I forget to remove

12:09 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

12:08 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:07 pm

Vendor - TEL - Varshini Nagabooshanam

handleRxState should stay private. I removed the prototype from the header and kept a static prototype in ModePreTreat.c only, so the function remains internal to this unit.

handleRxState should stay private. I removed the prototype from the header and kept a static prototype in ModePreTreat.c only, so the function remains internal to this unit.

9:20 am

Sean Nash

I guess my point was, we don't need the "APP_SERVICES" part in the name.

I guess my point was, we don't need the "APP_SERVICES" part in the name.

9:17 am

Sean Nash

Why was this moved to header file?

Why was this moved to header file?

9:16 am

Sean Nash

Doesn't make sense to have a static function prototyped in the header file. Static suggests the function is private. Prototyping in header file suggests function is public. I suspect this function ...

Doesn't make sense to have a static function prototyped in the header file. Static suggests the function is private. Prototyping in header file suggests function is public. I suspect this function should be private, so keep that static but move this prototype inside the .c file.

Tuesday 02 Dec
1:14 pm

Sean Nash

I think we need 2 public get functions that takes a dialyzer type (enum) parameter and return a blood volume or dialysate volume from this look-up table.

I think we need 2 public get functions that takes a dialyzer type (enum) parameter and return a blood volume or dialysate volume from this look-up table.

1:10 pm

Sean Nash

Missing param line in function header.

Missing param line in function header.

1:10 pm

Sean Nash

Missing param line in function header.

Missing param line in function header.

1:07 pm

Sean Nash

Missing param line in function header.

Missing param line in function header.

10:21 am

Vendor - TEL - Varshini Nagabooshanam

Thanks for catching that. Yes, this was an accidental change on my part. I’ll revert it and proceed with deleting ModeTxParams.c and the related header files as suggested.

Thanks for catching that. Yes, this was an accidental change on my part. I’ll revert it and proceed with deleting ModeTxParams.c and the related header files as suggested.

9:59 am

Sean Nash

Get function for rejected is not needed?

Get function for rejected is not needed?

9:58 am

Sean Nash

treatParamsConfirmed is an input.

treatParamsConfirmed is an input.