LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV -...

Activity

LEAHI-TD-FIRMWARE-LDT-473-1 69

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 5h 20m 22 Updated.
    Reviewer - 0% reviewed 5m    
    Reviewer - 0% reviewed 0m    
    Reviewer - 0% reviewed      
    Reviewer - 99% reviewed 18m    
    Reviewer - Complete 2h 38m 47 Does OperationModes.c need to include TxParams.h? TxParam...
    Reviewer - 7% reviewed 21m    
    Reviewer - Complete 1h 10m    
    Reviewer - 0% reviewed 0m    
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Total   9h 56m 69  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /TDDefs.h Changed 2
    Open in IDE #permalink
    /firmware/App/Controllers/BloodFlow.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModePreTreat.c Changed 14
    Open in IDE #permalink
    /firmware/App/Modes/ModePreTreat.h Changed 2
    Open in IDE #permalink
    /firmware/App/Modes/ModeStandby.c Changed 2
    Open in IDE #permalink
    /firmware/App/Modes/ModeTreatment.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeTxParams.c Deleted 6
    Open in IDE #permalink
    /firmware/App/Modes/ModeTxParams.h Deleted
    Open in IDE #permalink
    /firmware/App/Modes/OperationModes.c Changed 4
    Open in IDE #permalink
    /firmware/App/Modes/StateTxDialysis.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/StateTxPaused.c Changed
    Open in IDE #permalink
    /firmware/App/Services/AlarmMgmtSWFaults.h Changed
    Open in IDE #permalink
    /firmware/App/Services/DDInterface.c Changed
    Open in IDE #permalink
    /firmware/App/Services/Messaging.c Changed
    Open in IDE #permalink
    /firmware/App/Services/TxParams.c Added 27
    Open in IDE #permalink
    /firmware/App/Services/TxParams.h Added 12
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time