StateServices

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-4013-1: Addressed CR comments

  1. … 1 more file in changeset.
Thank you for the clarification!

Thank you for the clarification!

break into two lines

break into two lines

Add alarm ALARM_ID_TD_EMPTY_SALINE_BAG

Add alarm ALARM_ID_TD_EMPTY_SALINE_BAG

Add newAlarmIndicateStop to output

Add newAlarmIndicateStop to output

Add newAlarmIndicateStop to input and output.

Add newAlarmIndicateStop to input and output.

Arpita, we don't want to use doxygen style comments for function prototypes since we cover functions with the function headers. so this is the proper type of comments.

Arpita, we don't want to use doxygen style comments for function prototypes since we cover functions with the function headers. so this is the proper type of comments.

Bubble status, Low and high level level sensors.

Bubble status, Low and high level level sensors.

Input : Blood pump door status?

Input : Blood pump door status?

To be restored?

To be restored?

Are these being initialized in the init function?

Are these being initialized in the init function?

Need to resolve the merge issues?

Need to resolve the merge issues?

pauseBolusResumeState is input

pauseBolusResumeState is input

add alarm

add alarm

Replace // to ///< for line 56 to 60

Replace // to ///< for line 56 to 60

LDT-4103-1: Addressed CR comments

LDT-4103-1: Addressed CR comments

  1. … 1 more file in changeset.
Use // comments for function prototypes.

Use // comments for function prototypes.

Either no comment or // comment for function prototypes since doxygen captures function details from function headers.

Either no comment or // comment for function prototypes since doxygen captures function details from function headers.

These were fine (and preferred) as // because doxygen gets function details from function headers in the .c file.

These were fine (and preferred) as // because doxygen gets function details from function headers in the .c file.

Fixes

LDT-4013-1: Addressed CR comments

  1. … 2 more files in changeset.
Fixed the implementation

  1. … 2 more files in changeset.
Should we be looking at tubing set type instead of modality here?

Should we be looking at tubing set type instead of modality here?

Can we not determine this now? Why TODO?

Can we not determine this now? Why TODO?

Shouldn't we be checking tubing set type instead of modality here?

Shouldn't we be checking tubing set type instead of modality here?

verify given type is valid (< NUM_OF_TUBE_SET_TYPES) and trigger s/w fault if invalid.

verify given type is valid (< NUM_OF_TUBE_SET_TYPES) and trigger s/w fault if invalid.

Initialize to UNKNOWN type. Remove TODO.

Initialize to UNKNOWN type. Remove TODO.