Fisheye on td-firmware/firmware/App/Services https://devapps.diality.us/changelog/td-firmware/firmware/App/Services Recent activity in "td-firmware" under directory /firmware/App/Services LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "I don't see you changing the GoalL. Recommend ..." Tue, 05 May 2026 18:21:50 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28937 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28937 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

I don't see you changing the GoalL. Recommend you use local presUFVolumeMl instead.

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "2 lines above/below banner" Tue, 05 May 2026 18:52:58 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28943 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28943 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

2 lines above/below banner

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "remove blank line." Tue, 05 May 2026 18:48:29 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28942 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28942 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

remove blank line.

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "use response.x for these." Tue, 05 May 2026 18:25:58 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28940 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28940 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

use response.x for these.

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "use response.duration." Tue, 05 May 2026 18:25:43 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28939 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28939 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

use response.duration.

]]> LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "Already set this above." Tue, 05 May 2026 18:24:49 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28938 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28938 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Already set this above.

]]> td-firmware (LDT-1886-blood-set-auto-load-and-auto-ej): LDT-1886: Addressed code review comments Tue, 05 May 2026 16:37:42 -0700 Vendor - TEL - Praneeth Bunne https://devapps.diality.us/changelog/td-firmware?cs=253979e460b82c6d038e0a566f3be8c6df0a28c9 https://devapps.diality.us/changelog/td-firmware?cs=253979e460b82c6d038e0a566f3be8c6df0a28c9 Vendor - TEL - Praneeth Bunne committed 253979e on branch LDT-1886-blood-set-auto-load-and-auto-ej in td-firmware LDT-1886: Addressed code review comments

· /firmware/App/Modes/ModePostTreat.c (-21, +21) | History | Source | Diff
· /firmware/App/Modes/ModePreTreat.c (-29, +29) | History | Source | Diff
· /firmware/App/Modes/ModePreTreat.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-9, +11) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-4, +2) | History | Source | Diff
· /firmware/App/Services/StateServices/TubeSetAutoEject.c (-21, +42) | History | Source | Diff
· /firmware/App/Services/StateServices/TubeSetAutoEject.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/StateServices/TubeSetInstall.c (-17, +32) | History | Source | Diff
]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "no need to respond." Tue, 05 May 2026 15:58:48 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28924 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28924 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

no need to respond.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "don't need response to a response." Tue, 05 May 2026 15:58:39 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28923 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28923 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

don't need response to a response.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "don't need this if statement either and don't n..." Tue, 05 May 2026 15:54:59 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28917 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28917 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

don't need this if statement either and don't need what's inside the if.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Don't need this if statement or flag." Tue, 05 May 2026 15:49:47 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28916 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28916 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Don't need this if statement or flag.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "use separate time than stability (even if same ..." Tue, 05 May 2026 15:46:47 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28915 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28915 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

use separate time than stability (even if same right now).

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Move to transition function and remove this if ..." Tue, 05 May 2026 15:42:22 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28914 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28914 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Move to transition function and remove this if statement.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "do 2 data with the p1 and p2 pressures." Tue, 05 May 2026 15:40:59 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28913 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28913 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

do 2 data with the p1 and p2 pressures.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Remove extra blank line." Tue, 05 May 2026 15:36:03 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28910 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28910 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Remove extra blank line.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Remove if statement. Always set valve to pos A." Tue, 05 May 2026 15:35:20 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28909 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28909 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Remove if statement. Always set valve to pos A.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Want to stop air pump, not end air trap control..." Tue, 05 May 2026 15:32:27 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28908 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28908 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Want to stop air pump, not end air trap control.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Don't want to start air trap control. Want to ..." Tue, 05 May 2026 15:26:52 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28904 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28904 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Don't want to start air trap control. Want to turn on the air pump at max power (100.0%)

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Put this stuff in transition function for this ..." Tue, 05 May 2026 15:24:54 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28903 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28903 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Put this stuff in transition function for this state. Remove venousSetupStateEntered flag.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "change flag to tubeSetLeakChecksStarted" Tue, 05 May 2026 15:21:12 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28902 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28902 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

change flag to tubeSetLeakChecksStarted

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Shouldn't this be the pressure sensor normal se..." Tue, 05 May 2026 15:12:54 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28896 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28896 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Shouldn't this be the pressure sensor normal setup state?

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "initialize start time for next state. Should w..." Tue, 05 May 2026 14:54:07 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28892 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28892 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

initialize start time for next state. Should we set a flag indicating we completed the tube set checks?

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Call your transition function for new state her..." Tue, 05 May 2026 15:03:53 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28894 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28894 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Call your transition function for new state here.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "state removed." Tue, 05 May 2026 14:56:12 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28893 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28893 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

state removed.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Don't need this flag or this if statement." Tue, 05 May 2026 14:36:36 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28891 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28891 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Don't need this flag or this if statement.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Think about including data." Tue, 05 May 2026 14:28:41 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28890 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28890 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Think about including data.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Needed?" Tue, 05 May 2026 14:27:17 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28889 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28889 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Needed?

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Still need cmd to barcode reader to scan." Tue, 05 May 2026 14:25:34 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28888 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28888 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Still need cmd to barcode reader to scan.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Not a CAN msg to UI. It's a command to barcode..." Tue, 05 May 2026 14:24:10 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28887 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28887 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Not a CAN msg to UI. It's a command to barcode reader via fpga. Not implement yet, so TODO comment.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "remove if statement. No occlusion sensor" Tue, 05 May 2026 14:23:05 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28886 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28886 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

remove if statement. No occlusion sensor

]]>