td-firmware / firmware

App

Clone Tools

Stats

Commits this week: 68
Total Committers: 18
Last Commit: 18:32
Commits this week: 68

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
4 hrs ago

Vendor - TEL - Praneeth Bunne

LDT-5624: Addressed CR comments

Options
    • -25
    • +10
    ./Modes/StateTxRinseback.c
    • -5
    • +1
    ./Services/StateServices/FluidBolus.c
5 hrs ago

Vendor - TEL - Vijay Pamula

LDT-5472: Barcode Reader Implementation

Options
    • -0
    • +456
    ./Drivers/BarcodeReader.c
    • -0
    • +59
    ./Drivers/BarcodeReader.h
    • -0
    • +125
    ./Services/FpgaTD.c
    • -0
    • +10
    ./Services/FpgaTD.h
    • -0
    • +2
    ./Services/Messaging.c
    • -0
    • +4
    ./Tasks/TaskPriority.c
  7. … 1 more file in changeset.
6 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Yes,

Yes,

6 hrs ago

Vendor - TEL - Varshini Nagabooshanam

In pre-treatment

In pre-treatment

6 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

6 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Yes, fixed

Yes, fixed

6 hrs ago

Vendor - TEL - Varshini Nagabooshanam

LDT-5613: Changes in Pressure self test

Options
    • -8
    • +25
    ./Services/StateServices/DrySelfTests.c
8 hrs ago

Sean Nash

Add a command to turn air pump off here in this state (since we aren't doing that in transition anymore to prevent large pressure drop).

Add a command to turn air pump off here in this state (since we aren't doing that in transition anymore to prevent large pressure drop).

8 hrs ago

Sean Nash

Don't turn off air pump here - looks like we lose too much air pressure when we do that. Move this command to the stabilize state handler (I'll add a comment there).

Don't turn off air pump here - looks like we lose too much air pressure when we do that. Move this command to the stabilize state handler (I'll add a comment there).

10 hrs ago

Sean Nash

You removed it here, but where did it go? I expected to see it in next case below.

You removed it here, but where did it go? I expected to see it in next case below.

10 hrs ago

Sean Nash

Align "="

Align "="

10 hrs ago

Sean Nash

Add comment to right.

Add comment to right.

11 hrs ago

Sean Nash

Better to say != TRUE here.

Better to say != TRUE here.

11 hrs ago

Sean Nash

Add TODO comment as to whether we should trigger an alarm/fault here.

Add TODO comment as to whether we should trigger an alarm/fault here.

11 hrs ago

Sean Nash

Add blank line after declaration. Fix indent.

Add blank line after declaration.
Fix indent.

11 hrs ago

Sean Nash

We can un-comment syringe pump stop now.

We can un-comment syringe pump stop now.

12 hrs ago

Sean Nash

I think this function should be private (called by public message handler).

I think this function should be private (called by public message handler).

12 hrs ago

Sean Nash

Should this be static (private)?

Should this be static (private)?

12 hrs ago

Vendor - TEL - Varshini Nagabooshanam

LDT-5613: Changes in Pressure self test

Options
    • -301
    • +53
    ./Services/StateServices/DrySelfTests.c
12 hrs ago

Vendor - TEL - Suresh Dharnala

LDT-4050:updated DD goto postgen and standby call

Options
    • -52
    • +25
    ./Modes/ModePostTreat.c
    • -84
    • +81
    ./Modes/ModeStandby.c
Friday 21 Aug
6:02 pm

Vendor - TEL - Praneeth Bunne

LDT-3992: Merge latest staging & reolve merge conflicts

Options
    • -94
    • +325
    ./Modes/ModePreTreat.c
    • -2
    • +7
    ./Modes/ModePreTreat.h
    • -120
    • +246
    ./Modes/ModeStandby.c
    • -15
    • +45
    ./Modes/StatePreTxRecirculate.c
    • -8
    • +11
    ./Services/AlarmMgmtSWFaults.h
    • -2
    • +33
    ./Services/DDInterface.c
    • -2
    • +3
    ./Services/DDInterface.h
    • -6
    • +4
    ./Services/Messaging.c
5:58 pm

Sean Nash

I don't have a good option. If we're going to change it to pull approach later, can't we just ignore rate changes when doing fluid bolus with sub fluid until you implement the pull approach? Are we...

I don't have a good option. If we're going to change it to pull approach later, can't we just ignore rate changes when doing fluid bolus with sub fluid until you implement the pull approach? Are we even able to do sub fluid bolus yet? Do we have HDF tube sets?

5:48 pm

Vendor - TEL - Praneeth Bunne

Sure

Sure

5:44 pm

Vendor - TEL - Praneeth Bunne

I'll implement the pull approach later, this is temporary fix. We need to run Sub pump at Qb rate, if Qb is updated, how can we increase Qsub?

I'll implement the pull approach later, this is temporary fix.
We need to run Sub pump at Qb rate, if Qb is updated, how can we increase Qsub?

5:37 pm

Sean Nash

Should we check to see if blood sitting timer has not exceeded time limit before we resume (similar to what we do from rinseback stop state before we start an additional)?

Should we check to see if blood sitting timer has not exceeded time limit before we resume (similar to what we do from rinseback stop state before we start an additional)?

5:30 pm

Sean Nash

So we will command BP every 50ms for saline (okay, but not the pull approach we talked about) and send DD Qsub commands every 50ms for sub fluid (probably not a good idea)?

So we will command BP every 50ms for saline (okay, but not the pull approach we talked about) and send DD Qsub commands every 50ms for sub fluid (probably not a good idea)?

5:06 pm

Vendor - TEL - Praneeth Bunne

LDT-5624: Fixed rinseback & fluid bolus related bugs

Options
    • -0
    • +4
    ./Modes/ModeTreatment.c
    • -0
    • +6
    ./Modes/StateTxDialysis.c
    • -58
    • +64
    ./Modes/StateTxRinseback.c
    • -4
    • +13
    ./Services/StateServices/FluidBolus.c
10:26 am

Vendor - TEL - Varshini Nagabooshanam

Those transitions to send the pressure result event. That was carried over from the previous implementation. Since the state changes are already reported through the common sub-state/operation-stat...

Those transitions to send the pressure result event. That was carried over from the previous implementation. Since the state changes are already reported through the common sub-state/operation-status events, I'll remove the pressure result event from those individual transitions for consistency.

9:53 am

Michael Garthwaite

Need the TDDef.h changes that include the enum naming updates

Need the TDDef.h changes that include the enum naming updates

9:49 am

Vendor - TEL - Suresh Dharnala

LDT-4050:Added one single command to DD disinfection options

Options
    • -13
    • +40
    ./Modes/ModePostTreat.c
    • -21
    • +16
    ./Modes/ModeStandby.c
    • -10
    • +45
    ./Services/DDInterface.c
    • -1
    • +3
    ./Services/DDInterface.h
    • -0
    • +1
    ./Services/Messaging.c