Activity td-firmware/firmware

Tree
Accordion

Stats

Commits this week: 28

Total Committers:	18
Last Commit:	16:28
Commits this week:	28

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Thursday 23 Jul

11:27 am

Sean Nash

LDT-4149: more changes.

- -1
- +24
./App/Drivers/PinchValve.c
- History
- Source
- Diff
./App/Drivers/PinchValve.c

11:23 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

please update the alarm id reservation sheet.

please update the alarm id reservation sheet.

11:20 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Why is MSG_ID_DD_SUBSTITUTION_PUMP_DATA commented out? Line 214 and 215 are using tabs instead of whitespace characters because of which the alignment is off.

Why is MSG_ID_DD_SUBSTITUTION_PUMP_DATA commented out?
Line 214 and 215 are using tabs instead of whitespace characters because of which the alignment is off.

11:15 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this line : one variable per line will be easy to read.

break this line : one variable per line will be easy to read.

11:13 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

StateTxRecirc should be above StateTxRinseback

StateTxRecirc should be above StateTxRinseback

11:07 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Add @Alarm ALARM_ID_TD_SALINE_BAG_VOLUME_LOW_ALARM

Add @Alarm ALARM_ID_TD_SALINE_BAG_VOLUME_LOW_ALARM

11:05 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this line

break this line

11:05 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this line

break this line

11:04 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Add rinsebackPublishTimerCtr to outputs

Add rinsebackPublishTimerCtr to outputs

10:55 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

add rinsebackPublishTimerCtr to outputs

add rinsebackPublishTimerCtr to outputs

10:55 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this line

break this line

10:55 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

add rinsebackPublishTimerCtr to outputs

add rinsebackPublishTimerCtr to outputs

10:54 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this line

break this line

10:52 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this into two or more lines

break this into two or more lines

10:52 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break the comment in two lines

break the comment in two lines

10:50 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Do we need the alarm?

Do we need the alarm?

10:49 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Add fluidType to inputs

Add fluidType to inputs

10:49 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Update spelling of cummulativeRinsebackVolume_mL

Update spelling of cummulativeRinsebackVolume_mL

10:48 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break into two lines

break into two lines

10:46 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break into two lines

break into two lines

10:46 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break into two lines

break into two lines

10:46 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Add isRecircAllowed to inputs

Add isRecircAllowed to inputs

10:44 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Remove Alarm

Remove Alarm

10:44 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Remove bloodSittingTimerCtr

Remove bloodSittingTimerCtr

10:44 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

outputs is none.

outputs is none.

10:42 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Add fluidType to inputs

Add fluidType to inputs

10:42 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Outputs: Add targetRinsebackVolumePlusAdditional_mL Update spelling for :cummulativeRinsebackVolume_mL

Outputs:
Add targetRinsebackVolumePlusAdditional_mL
Update spelling for :cummulativeRinsebackVolume_mL

10:39 am

Sean Nash

More
8c14bdf
changed 4 files
LDT-4149-pinch-valves-fw-implementation LEAHI-TD-FIRMWARE-LDT-4149-1

LDT-4149: More changes.

- -3
- +0
./App/Controllers/Valves.c
- History
- Source
- Diff
./App/Controllers/Valves.c
- -12
- +0
./App/Controllers/Valves.h
- History
- Source
- Diff
./App/Controllers/Valves.h
- -56
- +48
./App/Drivers/PinchValve.c
- History
- Source
- Diff
./App/Drivers/PinchValve.c
- -0
- +10
./App/Drivers/PinchValve.h
- History
- Source
- Diff
./App/Drivers/PinchValve.h

10:35 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this line

break this line

10:34 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Add @Alarms

Add @Alarms

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-07-24 16:48 -0700