Fisheye on dialin/tests/test_hd_dg_fans.py

DIALIN-DENBUG-280-4: closed by Michael Garthwaite

Michael Garthwaite — Wed, 06 Nov 2024 15:20:04 -0800

Michael Garthwaite Closed DIALIN-DENBUG-280-4

DIALIN-DENBUG-280-1: closed by Michael Garthwaite

Michael Garthwaite — Wed, 06 Nov 2024 15:19:54 -0800

Michael Garthwaite Closed DIALIN-DENBUG-280-1

DIALIN-DENBUG-280-4: reviewers finished

Mon, 04 Nov 2024 10:29:29 -0800

Sean Nash finished reviewing DIALIN-DENBUG-280-4

DIALIN-DENBUG-280_Issues With HD Broadcast P1

DIALIN-DENBUG-280-4: started by Dara Navaei

Dara Navaei — Sat, 02 Nov 2024 16:01:22 -0700

Dara Navaei started review DIALIN-DENBUG-280-4

DIALIN-DENBUG-280-1: reviewers joined DIALIN-DENBUG-280_Issues With HD Broadcast P1B

Thu, 31 Oct 2024 11:03:43 -0700

Dara Navaei joined DIALIN-DENBUG-280-1

DIALIN-DENBUG-280_Issues With HD Broadcast P1B

DIALIN-DENBUG-280-1: reviewers removed from DIALIN-DENBUG-280_Issues With HD Broadcast P1B

Thu, 31 Oct 2024 11:03:43 -0700

Dara Navaei removed Michael Garthwaite from DIALIN-DENBUG-280-1

DIALIN-DENBUG-280_Issues With HD Broadcast P1B

DIALIN-DENBUG-280-1: started by Dara Navaei

Dara Navaei — Thu, 31 Oct 2024 11:02:51 -0700

Dara Navaei started review DIALIN-DENBUG-280-1

DIALIN-DIAL-299-1: closed by Michael Garthwaite

Michael Garthwaite — Mon, 01 Jul 2024 10:16:48 -0700

Michael Garthwaite Closed DIALIN-DIAL-299-1

DIALIN-DIAL-299-1: comment by Michael Garthwaite "This CR should be closed due to bad branching. ..."

Michael Garthwaite — Mon, 01 Jul 2024 10:16:33 -0700

Michael Garthwaite commented on DIALIN-DIAL-299-1

This CR should be closed due to bad branching. Should have been branched out of p1_staging.

DIALIN-DIAL-299-1: started by Dara Navaei

Dara Navaei — Wed, 26 Jun 2024 12:01:20 -0700

Dara Navaei started review DIALIN-DIAL-299-1

DIALIN-UCOMMITS-16: closed by Sean Nash

Sean Nash — Thu, 03 Aug 2023 13:19:58 -0700

Sean Nash Closed DIALIN-UCOMMITS-16

DIALIN-UCOMMITS-16: reviewers finished

Thu, 03 Aug 2023 10:36:41 -0700

Dara Navaei finished reviewing DIALIN-UCOMMITS-16

DIALIN Staging Unreviewed Commits

DIALIN-UCOMMITS-16: reviewers finished

Wed, 02 Aug 2023 17:38:50 -0700

Sean Nash finished reviewing DIALIN-UCOMMITS-16

DIALIN Staging Unreviewed Commits

DIALIN-UCOMMITS-16: started by Dara Navaei

Dara Navaei — Mon, 08 May 2023 11:01:43 -0700

Dara Navaei started review DIALIN-UCOMMITS-16

DIALIN-DEN-11750-1: closed by Dara Navaei

Dara Navaei — Thu, 03 Mar 2022 16:50:52 -0800

Dara Navaei Closed DIALIN-DEN-11750-1

dialin (DEN-12358-sw_dev-sprint-67_mg): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 03 Mar 2022 15:28:36 -0800

Dara Navaei committed 88b4967 on branch DEN-11928-dg-conductivity-update, DEN-12121-sw_dev-sprint-65 and 195 more in dialin

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /dialin/dg/alarms.py

(-2, +2)

| History

| Source

| Diff

· /dialin/dg/calibration_record.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/dialysate_generator.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/fans.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/ro_pump.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/sw_configs.py

(-0, +15)

| History

| Source

| Diff

· /dialin/dg/temperatures.py

(-1, +1)

| History

| Source

| Diff

· /dialin/hd/alarms.py

(-1, +1)

| History

| Source

| Diff

· /dialin/hd/calibration_record.py

(-1, +1)

| History

| Source

| Diff

· /dialin/hd/fans.py

(-1, +1)

| History

| Source

| Diff

· /dialin/hd/hemodialysis_device.py

(-2, +2)

| History

| Source

| Diff

· /dialin/hd/sw_configs.py

(-0, +15)

| History

| Source

| Diff

· /dialin/hd/syringe_pump.py

(-2, +2)

| History

| Source

| Diff

· /dialin/hd/temperatures.py

(-1, +1)

| History

| Source

| Diff

· /dialin/hd/treatment.py

(-1, +1)

| History

| Source

| Diff

… 13 more files in changeset.

DIALIN-DEN-11750-1: reviewers finished

Wed, 02 Mar 2022 12:39:44 -0800

Michael Garthwaite and Sean Nash finished reviewing DIALIN-DEN-11750-1

DIALIN-DEN-11750_DG Dev Dialysate Temperature Control Tune Up

DIALIN-DEN-11750-1: comment by Michael Garthwaite "RESOLVED."

Michael Garthwaite — Tue, 01 Mar 2022 13:06:04 -0800

Michael Garthwaite replied to Dara Navaei in DIALIN-DEN-11750-1

RESOLVED.

DIALIN-DEN-11750-1: comment by Dara Navaei "This variable was very temporary. I deleted it."

Dara Navaei — Tue, 01 Mar 2022 12:56:02 -0800

Dara Navaei replied to Michael Garthwaite in DIALIN-DEN-11750-1

This variable was very temporary. I deleted it.

DIALIN-DEN-11750-1: comment by Michael Garthwaite "I don't have an issue with temporary features o..."

Michael Garthwaite — Tue, 01 Mar 2022 10:35:42 -0800

Michael Garthwaite commented on DIALIN-DEN-11750-1

I don't have an issue with temporary features or variables being merged into staging but could we not name them so vaguely? Ex: calc_rpm_start_time_removable or calc_rpm_start_time_temporary?

DIALIN-DEN-11750-1: comment by Michael Garthwaite "RESOLVED."

Michael Garthwaite — Wed, 23 Feb 2022 12:55:45 -0800

Michael Garthwaite replied to Dara Navaei in DIALIN-DEN-11750-1

RESOLVED.

DIALIN-DEN-11750-1: comment by Michael Garthwaite "RESOLVED."

Michael Garthwaite — Wed, 23 Feb 2022 12:55:33 -0800

Michael Garthwaite replied to Dara Navaei in DIALIN-DEN-11750-1

RESOLVED.

DIALIN-DEN-11750-1: comment by Michael Garthwaite "RESOLVED."

Michael Garthwaite — Wed, 23 Feb 2022 12:55:05 -0800

Michael Garthwaite replied to Dara Navaei in DIALIN-DEN-11750-1

RESOLVED.

DIALIN-DEN-11750-1: comment by Michael Garthwaite "RESOLVED."

Michael Garthwaite — Wed, 23 Feb 2022 12:53:48 -0800

Michael Garthwaite replied to Dara Navaei in DIALIN-DEN-11750-1

RESOLVED.

DIALIN-DEN-11750-1: comment by Michael Garthwaite "RESOLVED."

Michael Garthwaite — Wed, 23 Feb 2022 12:53:32 -0800

Michael Garthwaite replied to Dara Navaei in DIALIN-DEN-11750-1

RESOLVED.

DIALIN-DEN-11750-1: comment by Michael Garthwaite "RESOLVED."

Michael Garthwaite — Wed, 23 Feb 2022 12:53:18 -0800

Michael Garthwaite replied to Dara Navaei in DIALIN-DEN-11750-1

RESOLVED.

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-11750 addressed the code review comments

Dara Navaei — Wed, 23 Feb 2022 11:27:42 -0800

Dara Navaei committed 936963d on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update and 196 more in dialin

DEN-11750 addressed the code review comments

· /dialin/dg/alarms.py	(-4, +4)	\| History	\| Source	\| Diff
· /dialin/dg/calibration_record.py	(-5, +8)	\| History	\| Source	\| Diff
· /dialin/dg/ro_pump.py	(-1, +1)	\| History	\| Source	\| Diff
· /dialin/dg/sw_config.py	(-4, +6)	\| History	\| Source	\| Diff
· /dialin/dg/temperatures.py	(-19, +19)	\| History	\| Source	\| Diff
· /dialin/hd/calibration_record.py	(-7, +10)	\| History	\| Source	\| Diff
· /dialin/hd/sw_config.py	(-4, +6)	\| History	\| Source	\| Diff
· /dialin/utils/nv_ops_utils.py	(-1, +1)	\| History	\| Source	\| Diff
· /tests/hd_blood_leak_data.py	(-39, +0)	\| History	\| Source	\| Diff
· /tests/test_hd_dg_fans.py	(-24, +1)	\| History	\| Source	\| Diff

DIALIN-DEN-11750-1: comment by Dara Navaei "I made it like HD."

Dara Navaei — Wed, 23 Feb 2022 11:24:38 -0800

Dara Navaei replied to Michael Garthwaite in DIALIN-DEN-11750-1

I made it like HD.

DIALIN-DEN-11750-1: comment by Dara Navaei "Done."

Dara Navaei — Wed, 23 Feb 2022 11:18:22 -0800

Dara Navaei replied to Michael Garthwaite in DIALIN-DEN-11750-1

Done.

DIALIN-DEN-11750-1: comment by Dara Navaei "Agreed. I will clean them up gradually. Removed..."

Dara Navaei — Wed, 23 Feb 2022 11:16:23 -0800

Dara Navaei replied to Michael Garthwaite in DIALIN-DEN-11750-1

Agreed. I will clean them up gradually. Removed the commented code.