Algin "=" to be consistent with those below.

Add blank line after declarations.

Add blank line after declarations.

Align comment.

Is it time to restore?

Remove extra space after "=".

Are we going to restore this or not?

Are we going to restore this or not?

Are we going to restore this or not?

Remove this.

Remove this.

Remove spaces before "=" or align "=".

Fix comment alignment.

Why are we commenting this out?

Is it time to restore now?

Can we remove these 2 lines of code?

Remove extra blank lines.

This "s" looks out of place.

But this is a f/w shared unit (so both TD and DD f/w include this unit in their build) and we may add a case later. Because it's a common unit, we should design it to work for both f/w builds.

No, its deleted

I do not see TD use case in any of the PI controller functions. so do we need TD here ?

· /firmware/App/Controllers/BalancingChamber.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-5, +7)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-7, +6)	| History	| Source	| Diff

]]> Thu, 26 Mar 2026 07:46:51 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=f8a9855f80d7f8f10a4e2468d18ee825ef8a5e72 https://devapps.diality.us/changelog/dd-firmware?cs=f8a9855f80d7f8f10a4e2468d18ee825ef8a5e72 Vendor - TEL - Sameer Poyil committed f8a9855 on branch LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, develop in dd-firmware LDT-2004 acid bicarb closed loop control

· /firmware/App/Controllers/BalancingChamber.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-10, +24)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-3, +6)	| History	| Source	| Diff

]]> Wed, 25 Mar 2026 13:35:37 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=40d8f8f053e42c5ba32b65ca210238a25b15ec80 https://devapps.diality.us/changelog/dd-firmware?cs=40d8f8f053e42c5ba32b65ca210238a25b15ec80 Vendor - TEL - Sameer Poyil committed 40d8f8f on branch LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, develop in dd-firmware LDT-2004 bicarb closed loop control

· /firmware/App/Controllers/DryBiCart.c

(-5, +5)

| History

| Source

| Diff

]]> Wed, 25 Mar 2026 10:43:01 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=deba34e5074da9ac97d8bcbe995f554eec5c70ed https://devapps.diality.us/changelog/dd-firmware?cs=deba34e5074da9ac97d8bcbe995f554eec5c70ed Vendor - TEL - Sameer Poyil committed deba34e on branch LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, develop in dd-firmware LDT-2004 Dry bicarb closed loop control

· /firmware/App/Controllers/BalancingChamber.c	(-11, +35)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-54, +858)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-0, +53)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.c	(-4, +6)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-0, +5)	| History	| Source	| Diff

]]> Wed, 25 Mar 2026 04:01:46 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-13 ]]> Thu, 19 Mar 2026 15:47:06 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-11 ]]> Thu, 19 Mar 2026 09:00:55 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28122 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28122 Sean Nash replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-2004-9

Why do we have a local sub state variable that we don't do anything with?

This is to avoid compilation warning

I don't think these coefficient access functions need to be public. Consider making them private.