This is being repeated.

Please add comment. if it is not being used, delete it.

Can this be reused from ConcentratePumps.h?

Add a space after and before parenthesis.

This comment is same as previous lines comment, update something similar to 'Maximum pressure allowed at bicart fill during supply process/state"

Add comment. is this the pressure offset for 11 PSI, if so, this offset supposed to be 1?

Please update this value with high resolution ( for example, 0.67 to 0.666666667 and 1.15 to 1.146666667? ).

So I think this compiler will give you 64 bit if you ask for long. Did you intend it to be 64 bit? If not, you can just use the BIT_BY_POS macro above.

Removing it now. will introduce it later if required

will finalize it when ocean spray logic is tested

dryBicartState is top level state machine which is different data type. removed dryBicartSubstate

removed

This is not extra blank line its a line for TASK_GENERAL_INTERVAL )

a macro used to create a contiguous bitmask starting at bit position l (low) and ending at bit position h

nr means short form of bit 'number', unsigned long is portable, 32bit for 32-bit cpu and 64 bits for 64bit cpu whereas unsigned int is always 32 bits regardless of architecture.

Remove this blank line.

Put () around each of the 2 conditions being ANDed.

Remove blank line.

Remove blank line.

Add a blank line after declarations.

Remove blank line.

Should we remove this else if or is it going to be restored later?

Remove extra blank lines.

Shouldn't we be assigning dryBicartState instead of dryBicartSubstate in all of these cases?

Why do we need this?

Remove extra blank line.

Remove extra blank line.

Not clear what GENMASK is doing. What do h and l refer to. This doesn't look like a simple bit mask.