Fisheye on leahi-dialin/tests/test_uf.py https://devapps.diality.us/changelog/~br%3DLDT-261-MainTreatmentScreen-SW-DiagnosticsScreen/leahi-dialin/tests/test_uf.py Recent activity in "leahi-dialin" under directory /tests/test_uf.py LEAHI-DIALIN-LDT-2655-1: reviewers finished Mon, 30 Mar 2026 09:39:06 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 Sean Nash finished reviewing LEAHI-DIALIN-LDT-2655-1 LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module ]]> LEAHI-DIALIN-LDT-2655-1: comment by Michael Garthwaite "yeah its obsolete. This is an old branch that r..." Mon, 16 Mar 2026 10:04:25 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1/#c28052 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1/#c28052 Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LDT-2655-1

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( conductivity sensors ).

]]> LEAHI-DIALIN-LDT-2655-1: reviewers joined LEAHI-DIALIN-LDT-2655_Cannot override conductivity... Wed, 04 Mar 2026 12:46:36 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 Dara Navaei joined LEAHI-DIALIN-LDT-2655-1 LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module ]]> LEAHI-DIALIN-LDT-2655-1: reviewers removed from LEAHI-DIALIN-LDT-2655_Cannot override conductivity... Wed, 04 Mar 2026 12:46:36 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 Dara Navaei removed Michael Garthwaite from LEAHI-DIALIN-LDT-2655-1 LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module ]]> LEAHI-DIALIN-LDT-2655-1: comment by Sean Nash "Why do we have an "ro" and an "fp" folder? Is ..." Tue, 09 Dec 2025 14:26:46 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1/#c25671 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1/#c25671 Sean Nash commented on LEAHI-DIALIN-LDT-2655-1

Why do we have an "ro" and an "fp" folder? Is "ro" folder obsolete (replaced by "fp")?

]]> LEAHI-DIALIN-LDT-2655-1: started by Dara Navaei Mon, 08 Dec 2025 08:15:35 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 Dara Navaei started review LEAHI-DIALIN-LDT-2655-1 ]]> LEAHI-DIALIN-LDT-566-2: closed by Michael Garthwaite Tue, 05 Aug 2025 13:05:01 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-2 Michael Garthwaite Closed LEAHI-DIALIN-LDT-566-2 ]]> LEAHI-DIALIN-LDT-566-2: reviewers finished Tue, 05 Aug 2025 12:50:55 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-2 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DIALIN-LDT-566-2 LEAHI-DIALIN-LDT-566_Water Treatment And Degassing FP 2 ]]> LEAHI-DIALIN-LDT-566-2: comment by Sean Nash "Why so much white space?" Fri, 01 Aug 2025 15:47:05 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-2/#c23448 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-2/#c23448 Sean Nash commented on LEAHI-DIALIN-LDT-566-2

Why so much white space?

]]> LEAHI-DIALIN-LDT-566-2: comment by Sean Nash "???" Fri, 01 Aug 2025 15:44:23 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-2/#c23447 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-2/#c23447 Sean Nash commented on LEAHI-DIALIN-LDT-566-2

???

]]> LEAHI-DIALIN-LDT-566-2: comment by Sean Nash "Where is 0x5B?" Fri, 01 Aug 2025 15:40:11 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-2/#c23446 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-2/#c23446 Sean Nash commented on LEAHI-DIALIN-LDT-566-2

Where is 0x5B?

]]> LEAHI-DIALIN-LDT-566-2: started by Dara Navaei Mon, 23 Jun 2025 17:48:15 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-566-2 Dara Navaei started review LEAHI-DIALIN-LDT-566-2 ]]> LEAHI-DIALIN-LEAH-261-1: closed by Michael Garthwaite Wed, 23 Apr 2025 16:29:37 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 Michael Garthwaite Closed LEAHI-DIALIN-LEAH-261-1 ]]> LEAHI-DIALIN-LEAH-261-1: reviewers finished Wed, 23 Apr 2025 16:02:54 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 Tiffany Mejia and Sean Nash finished reviewing LEAHI-DIALIN-LEAH-261-1 LEAHI-DIALIN-LEAH-261_FW RO Flow Sensor Driver ]]> LEAHI-DIALIN-LEAH-261-1: started by Michael Garthwaite Wed, 23 Apr 2025 15:16:55 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 Michael Garthwaite started review LEAHI-DIALIN-LEAH-261-1 ]]> LEAHI-DIALIN-LEAH-261-1: comment by Michael Garthwaite "fixed. Thanks!" Wed, 23 Apr 2025 14:26:07 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1/#c21977 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1/#c21977 Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LEAH-261-1

fixed. Thanks!

]]> LEAHI-DIALIN-LEAH-261-1: comment by Sean Nash "Remove extra blank line." Mon, 24 Feb 2025 09:49:44 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1/#c21554 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1/#c21554 Sean Nash commented on LEAHI-DIALIN-LEAH-261-1

Remove extra blank line.

]]> LEAHI-DIALIN-LEAH-261-1: comment by Sean Nash "function header?" Mon, 24 Feb 2025 09:47:55 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1/#c21553 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1/#c21553 Sean Nash commented on LEAHI-DIALIN-LEAH-261-1

function header?

]]> LEAHI-DIALIN-LEAH-261-1: comment by Sean Nash "We should remove DG references throughout. If ..." Mon, 24 Feb 2025 09:44:39 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1/#c21552 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1/#c21552 Sean Nash commented on LEAHI-DIALIN-LEAH-261-1

We should remove DG references throughout. If f/w doesn't call for some of these yet, lets just remove them for now.

]]> LEAHI-DIALIN-LEAH-261-1: started by Dara Navaei Fri, 14 Feb 2025 09:26:45 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 Dara Navaei started review LEAHI-DIALIN-LEAH-261-1 ]]>