LEAHI-DIALIN-LDT-566-2 LEAHI-DIALIN-LDT-566_Water Treatment And Degassing FP 2

closed on 05 Aug

Author

Moderator

Reviewers

LEAHI-DIALIN-LDT-566_Water Treatment And Degassing FP 2

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 114

leahi-dialin 0
- Folder leahi_dialin 0
  - Folder common 0
    - File msg_defs.py 0 Remove
    - File msg_ids.py 1 Remove
  - Folder dd 0
    - Folder modules 0
      - File alarms.py 0 Remove
      - File concentrate_pump.py 0 Remove
      - File conductivity_sensors.py 0 Remove
      - File constants.py 0 Remove
      - File piston_pump.py 0 Remove
      - File temperature_sensors.py 0 Remove
      - File ultrafiltration.py 0 Remove
    - Folder proxies 0
      - File ro_proxy.py 0 Remove
    - File dialysate_delivery.py 0 Remove
  - Folder fp 0
    - Folder modules 0
      - File alarms.py 1 Remove
      - File boost_pump.py 0 Remove
      - File conductivity_sensors.py 0 Remove
      - File flow_sensors.py 0 Remove
      - File levels.py 0 Remove
      - File permeate_tank.py 0 Remove
      - File pressure_sensors.py 0 Remove
      - File ro_pump.py 1 Remove
      - File temperatures.py 0 Remove
      - File valves.py 0 Remove
      - File water_pumps.py 0 Remove
    - Folder proxies 0
      - File __init__.py 0 Remove
      - File dd_proxy.py 0 Remove
    - File filtration_purification.py 0 Remove
  - Folder protocols 0
    - File CAN.py 0 Remove
  - Folder td 0
    - Folder modules 0
      - File alarms.py 0 Remove
      - File blood_flow.py 0 Remove
      - File bubble_detector.py 0 Remove
      - File constants.py 0 Remove
      - File ejector.py 0 Remove
      - File pressure_sensors.py 0 Remove
    - Folder proxies 0
      - File ui_proxy.py 0 Remove
    - File treatment_delivery.py 0 Remove
  - Folder ui 0
    - File dd_messaging.py 0 Remove
    - File td_messaging.py 0 Remove
  - File version.py 0 Remove
- Folder tests 0
  - Folder data_capture_helpers 0
    - File __init__.py 0 Remove
    - File fp_helpers.py 0 Remove
  - Folder depreciated_tests 0
    - File dg_hd_switches_test.py 0 Remove
    - File dg_heaters_test.py 0 Remove
    - File dg_nvm_scripts.py 0 Remove
    - File dg_tests.py 0 Remove
    - File dg_valves_test.py 0 Remove
    - File hd_air_bubbles_data.py 0 Remove
    - File hd_blood_leak_data.py 0 Remove
    - File hd_fluid_leak_state.py 0 Remove
    - File hd_nvm_scripts.py 0 Remove
    - File hd_test_pumps_open_loop.py 0 Remove
    - File hd_valves_test.py 0 Remove
    - File set_accels_cal.py 0 Remove
    - File set_flow_sensors_cal.py 0 Remove
    - File test_alarms.py 0 Remove
    - File test_buttons.py 0 Remove
    - File test_can_xmit.py 0 Remove
    - File test_conductivity.py 0 Remove
    - File test_deprime.py 0 Remove
    - File test_dg_records.py 0 Remove
    - File test_dg_valves.py 0 Remove
    - File test_dialysate_flow_sensor.py 0 Remove
    - File test_flush.py 0 Remove
    - File test_hd.py 0 Remove
    - File test_hd_dg_fans.py 0 Remove
    - File test_hd_records.py 0 Remove
    - File test_hd_valves.py 0 Remove
    - File test_heparin.py 0 Remove
    - File test_heprin_bolus_target_rate.py 0 Remove
    - File test_lc.py 0 Remove
    - File test_nelson_labs_disinfect.py 0 Remove
    - File test_saline_bolus.py 0 Remove
    - File test_syringe.py 0 Remove
    - File test_tx_config_tests.py 0 Remove
    - File test_uf.py 0 Remove
    - File test_uv_reactors.py 0 Remove
    - File test_voltages.py 0 Remove
  - Folder unit_tests 0
    - File test_imports.py 0 Remove
  - File dg_hd_switches_test.py 0 Remove
  - File dg_heaters_test.py 0 Remove
  - File dg_nvm_scripts.py 0 Remove
  - File dg_tests.py 0 Remove
  - File dg_valves_test.py 0 Remove
  - File fp_dianogistic_logger.py 0 Remove
  - File hd_air_bubbles_data.py 0 Remove
  - File hd_blood_leak_data.py 0 Remove
  - File hd_fluid_leak_state.py 0 Remove
  - File hd_nvm_scripts.py 0 Remove
  - File hd_test_pumps_open_loop.py 0 Remove
  - File hd_valves_test.py 0 Remove
  - File set_accels_cal.py 0 Remove
  - File set_flow_sensors_cal.py 0 Remove
  - File test_alarms.py 0 Remove
  - File test_buttons.py 0 Remove
  - File test_can_xmit.py 0 Remove
  - File test_conductivity.py 0 Remove
  - File test_deprime.py 0 Remove
  - File test_dg_records.py 0 Remove
  - File test_dg_valves.py 0 Remove
  - File test_dialysate_flow_sensor.py 0 Remove
  - File test_flush.py 0 Remove
  - File test_hd.py 0 Remove
  - File test_hd_dg_fans.py 0 Remove
  - File test_hd_records.py 0 Remove
  - File test_hd_valves.py 0 Remove
  - File test_heparin.py 0 Remove
  - File test_heprin_bolus_target_rate.py 0 Remove
  - File test_lc.py 0 Remove
  - File test_nelson_labs_disinfect.py 0 Remove
  - File test_ro.py 0 Remove
  - File test_saline_bolus.py 0 Remove
  - File test_syringe.py 0 Remove
  - File test_tx_config_tests.py 0 Remove
  - File test_uf.py 0 Remove
  - File test_uv_reactors.py 0 Remove
  - File test_voltages.py 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Michael Garthwaite	Author & Moderator	13m
Sean Nash	Reviewer - Complete	17m	3	Why so much white space?
Dara Navaei	Reviewer - 0% reviewed
Behrouz NematiPour	Reviewer - 0% reviewed
Tiffany Mejia	Reviewer - 0% reviewed	0m
jpaguio (deleted user)	Reviewer - 0% reviewed	44m
Vinayakam Mani	Reviewer - Complete	4m
Daniel Ho	Reviewer - 0% reviewed
Total		1h 20m	3

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-DIALIN-LDT-566-2

LEAHI-DIALIN-LDT-566_Water Treatment And Degassing FP 2

LEAHI-DIALIN-LDT-566-2 3

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

LEAHI-DIALIN-LDT-566_Water Treatment And Degassing FP 2

LEAHI-DIALIN-LDT-566-2 3

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time