LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the...

Activity

LEAHI-DIALIN-LDT-2655-1 2

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator      
    Reviewer - 0% reviewed      
    Reviewer - 100% reviewed 17m 2 Why do we have an "ro" and an "fp" folder? Is "ro" folder...
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 25% reviewed 6m    
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Total   24m 2  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /leahi_dialin/common/__init__.py Changed
    Open in IDE #permalink
    /leahi_dialin/common/dd_defs.py Changed
    Open in IDE #permalink
    /leahi_dialin/common/fp_defs.py Changed
    Open in IDE #permalink
    /leahi_dialin/common/msg_ids.py Changed
    Open in IDE #permalink
    /leahi_dialin/common/td_defs.py Changed
    Open in IDE #permalink
    /leahi_dialin/dd/modules/heaters.py Changed
    /leahi_dialin/dd/modules/piston_pump.py Changed
    Open in IDE #permalink
    /leahi_dialin/.../modules/pressure_sensors.py Changed
    Open in IDE #permalink
    /leahi_dialin/.../modules/temperature_sensors.py Changed
    Open in IDE #permalink
    /leahi_dialin/dd/modules/valves.py Changed
    Open in IDE #permalink
    /leahi_dialin/dd/proxies/td_proxy.py Changed
    Open in IDE #permalink
    /leahi_dialin/dd/__init__.py Changed
    Open in IDE #permalink
    /leahi_dialin/dd/dialysate_delivery.py Changed
    Open in IDE #permalink
    /leahi_dialin/fp/modules/boost_pump.py Changed
    Open in IDE #permalink
    /leahi_dialin/fp/modules/levels.py Changed
    Open in IDE #permalink
    /leahi_dialin/.../modules/pressure_sensors.py Changed
    Open in IDE #permalink
    /leahi_dialin/fp/modules/temperatures.py Changed
    /leahi_dialin/fp/modules/valves.py Changed
    Open in IDE #permalink
    /leahi_dialin/fp/modules/water_pumps.py Changed
    Open in IDE #permalink
    /leahi_dialin/fp/__init__.py Changed
    Open in IDE #permalink
    /leahi_dialin/fp/filtration_purification.py Changed
    Open in IDE #permalink
    /leahi_dialin/fp/reverse_osmosis.py Deleted
    Open in IDE #permalink
    /leahi_dialin/protocols/CAN.py Changed
    Open in IDE #permalink
    /leahi_dialin/protocols/__init__.py Changed
    Open in IDE #permalink
    /leahi_dialin/ro/modules/boost_pump.py Changed 1
    Open in IDE #permalink
    /leahi_dialin/ro/modules/flow_sensors.py Changed
    Open in IDE #permalink
    /leahi_dialin/ro/modules/levels.py Changed
    Open in IDE #permalink
    /leahi_dialin/.../modules/pressure_sensors.py Changed
    Open in IDE #permalink
    /leahi_dialin/ro/modules/valves.py Changed
    Open in IDE #permalink
    /leahi_dialin/ro/__init__.py Deleted
    Open in IDE #permalink
    /leahi_dialin/ro/reverse_osmosis.py Changed
    Open in IDE #permalink
    /leahi_dialin/td/modules/air_trap.py Changed 1
    /leahi_dialin/td/modules/blood_flow.py Changed
    /leahi_dialin/td/__init__.py Changed
    Open in IDE #permalink
    /leahi_dialin/td/treatment_delivery.py Changed
    Open in IDE #permalink
    /leahi_dialin/ui/td_messaging.py Changed
    /leahi_dialin/utils/__init__.py Changed
    Open in IDE #permalink
    /leahi_dialin.egg-info/PKG-INFO Deleted
    Open in IDE #permalink
    /leahi_dialin.egg-info/SOURCES.txt Deleted
    Open in IDE #permalink
    /leahi_dialin.egg-info/dependency_links.txt Deleted
    Open in IDE #permalink
    /leahi_dialin.egg-info/requires.txt Deleted
    Open in IDE #permalink
    /leahi_dialin.egg-info/top_level.txt Deleted
    Open in IDE #permalink
    /tests/data_capture_helpers/fp_helpers.py Changed
    Open in IDE #permalink
    /tests/depreciated_tests/test_uf.py Added
    Open in IDE #permalink
    /tests/fp_dianogistic_logger.py Changed
    Open in IDE #permalink
    /tests/test_dd.py Added
    Open in IDE #permalink
    /tests/test_ro.py Added
    Open in IDE #permalink
    /tests/test_td.py Added
    Open in IDE #permalink
    /tests/test_uf.py Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time