· /firmware/App/Controllers/RinsePump.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.h	(-2, +2)	| History	| Source	| Diff

]]> Fri, 03 Apr 2026 09:31:01 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Vendor - TEL - Jashwant Gantyada Closed LEAHI-DD-FIRMWARE-LDT-3627-1 ]]> Fri, 03 Apr 2026 08:32:42 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3627-1 LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1 ]]> Thu, 02 Apr 2026 15:35:36 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3627-1 LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1 ]]> Thu, 02 Apr 2026 14:50:52 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/changelog/dd-firmware?cs=3bfe4dde2875490b4e7fa595f634f30e19422210 https://devapps.diality.us/changelog/dd-firmware?cs=3bfe4dde2875490b4e7fa595f634f30e19422210 Vendor - TEL - Jashwant Gantyada committed 3bfe4dd on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-2008-v2-conductivity-sensors-CLEAN and 8 more in dd-firmware LDT-3627 resolved implicit declaration for rinse pump function

· /firmware/App/Controllers/RinsePump.c	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.h	(-1, +0)	| History	| Source	| Diff

]]> Tue, 31 Mar 2026 09:36:56 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Sean Nash added Michael Garthwaite and Vinayakam Mani to LEAHI-DD-FIRMWARE-LDT-3627-1 LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1 ]]> Wed, 25 Mar 2026 04:01:46 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-13 ]]> Thu, 19 Mar 2026 15:47:06 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-11 ]]> Mon, 16 Mar 2026 13:52:13 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3627-1 ]]> Tue, 24 Feb 2026 11:55:37 -0800 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 Vendor - TEL - Jashwant Gantyada Closed LEAHI-DD-FIRMWARE-LDT-3344-1 ]]> Tue, 24 Feb 2026 10:38:34 -0800 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=046bc2b62cf942b7e846fa5bff698b94238edf24 https://devapps.diality.us/changelog/dd-firmware?cs=046bc2b62cf942b7e846fa5bff698b94238edf24 Dara Navaei committed 046bc2b on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 35 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/RinsePump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/FluidPump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/GPIO.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/GPIO.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushConcentrate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.h	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskPriority.c	(-2, +2)	| History	| Source	| Diff

]]> Tue, 24 Feb 2026 10:35:01 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 Raghu Kallala , Vinayakam Mani and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3344-1 LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates. ]]> Mon, 23 Feb 2026 13:18:40 -0800 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 Vendor - TEL - Jashwant Gantyada started review LEAHI-DD-FIRMWARE-LDT-3344-1 ]]> Fri, 20 Feb 2026 14:19:23 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1/#c27522 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1/#c27522 Vendor - TEL - Sameer Poyil replied to Raghu Kallala in LEAHI-DD-FIRMWARE-LDT-3344-1

This is total mess up . that is what I want it a clean implementation. created a ticket LDT-3563 and closing all review comments.

Removing all the review comments and created a ticket to handle it in separate ticket -LDT-3563

removed.

changed.

removed.

the 2nd if statement for beta 1.0 is an ask from systems team to raise fault alarm if user by mistake enable Beta 2.0 config when Beta1.0 is active

Noe says we can distinguish between beta 1.9 and 2.0 w/ ID (4 and 6).
We still need test configs for beta 1.0 stuff and non-fpga differences.
We can use DD fpga ID # here in this macro instead of test config.
Since this is all temporary, I'm not that concerned about how we do this so long as it works.

I think Sameer is saying that the monitor should just call one get level function in FPGA and that one function (in FpgaDD.c) would handle all of this beta 1/1.9/2.0 stuff.
I agree, but didn't comment on it because it's all temporary anyway.

Why do we need a get function to call another get function? The caller of this function should just call getFPGAGPIOStatus() and then we wouldn't need this.

Move this up to public definitions section.

readFloaterLevelStatus is higher level functions that give the data from the FPGA.
Reason why we had these get functions here is, based on the FPGA response we translate it to the user understandable enum values (low, medium, high)

This is a reset call, as the default requirement is to be on Beta 1.9 HW
The logic is checking if the user is resetting the Beta 2.0 config, if yes, we will have to fall back to the Beta 1.9 FPGA registers

Level.c is a higher level abstracted functions and should not implement the HW dependent details in this file. this details should be pushed to FPGADD. and single function should handle all the cases instead of multiple functions.

Its not required, HW should be auto detected and initialized without any user configuration.

why its checking beta 2 and then setting beta 1.9 HW ?

We don't need this complex logic . use getFPGAVersions() function

use getFPGAVersions() to check this . if Beta 1.9 , FPGA version id is 4 and 6 if beta 2.0