Fisheye on dd-firmware/firmware/App/Controllers/Valves.c https://devapps.diality.us/changelog/~br%3DLDT-3103-closed-loop-control-pressure-threshold-fix/dd-firmware/firmware/App/Controllers/Valves.c Recent activity in "dd-firmware" under directory /firmware/App/Controllers/Valves.c LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Fri, 03 Apr 2026 15:35:04 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28219 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28219 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done" Fri, 03 Apr 2026 15:34:48 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28218 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28218 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Fri, 03 Apr 2026 15:34:30 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28217 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28217 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Same comment." Fri, 03 Apr 2026 13:20:23 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28216 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28216 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

Same comment.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Having much larger P coeff is likely to cause a..." Fri, 03 Apr 2026 13:18:56 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28215 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28215 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Input is d78TempAvgC" Fri, 03 Apr 2026 13:14:56 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28214 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28214 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

Input is d78TempAvgC

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "I don't think these min/max (for control output..." Fri, 03 Apr 2026 13:11:46 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28213 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28213 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Not sure these min/max are right here either." Fri, 03 Apr 2026 13:10:36 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28212 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28212 Sean Nash replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-3352-1

Not sure these min/max are right here either.

]]> LEAHI-DD-FIRMWARE-LDT-3627-1: closed by Vendor - TEL - Jashwant Gantyada Fri, 03 Apr 2026 09:31:01 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Vendor - TEL - Jashwant Gantyada Closed LEAHI-DD-FIRMWARE-LDT-3627-1 ]]> LEAHI-DD-FIRMWARE-LDT-3627-1: reviewers finished Fri, 03 Apr 2026 08:32:42 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3627-1 LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1 ]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:43:57 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28210 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28210 Vinayakam Mani replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Just following the current style of code implem..." Thu, 02 Apr 2026 15:42:21 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28209 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28209 Vinayakam Mani replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-3352-1

Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:40:23 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28208 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28208 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:39:59 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28207 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28207 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:39:30 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28206 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28206 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3627-1: reviewers finished Thu, 02 Apr 2026 15:35:36 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3627-1 LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1 ]]> LEAHI-DD-FIRMWARE-LDT-1477-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:28:25 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28205 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28205 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1477-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-1477-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:28:17 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28204 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28204 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1477-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-1477-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:27:47 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28203 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28203 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1477-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-1477-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:27:38 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28202 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28202 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1477-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3103-1: closed by Vinayakam Mani Thu, 02 Apr 2026 10:35:27 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3103-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3103-1 Vinayakam Mani Closed LEAHI-DD-FIRMWARE-LDT-3103-1 ]]> LEAHI-DD-FIRMWARE-LDT-1477-1: reviewers added to LEAHI-DD-FIRMWARE-LDT-1477_Ultrafiltration - DD - ... Thu, 02 Apr 2026 09:04:57 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1 Sean Nash added Vendor - TEL - Jashwant Gantyada , Vendor - TEL - Praneeth Bunne and Vendor - TEL - Sameer Poyil to LEAHI-DD-FIRMWARE-LDT-1477-1 LEAHI-DD-FIRMWARE-LDT-1477_Ultrafiltration - DD - 04: DEV - Feature Implementation ]]> LEAHI-DD-FIRMWARE-LDT-1477-1: comment by Sean Nash "Reverse order of comparison" Thu, 02 Apr 2026 09:04:04 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28199 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28199 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-1477-1

Reverse order of comparison

]]> LEAHI-DD-FIRMWARE-LDT-1477-1: comment by Sean Nash "Reverse order of comparison." Thu, 02 Apr 2026 09:03:48 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28198 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28198 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-1477-1

Reverse order of comparison.

]]> LEAHI-DD-FIRMWARE-LDT-1477-1: comment by Sean Nash "Reverse order of comparison." Thu, 02 Apr 2026 09:02:34 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28197 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28197 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-1477-1

Reverse order of comparison.

]]> LEAHI-DD-FIRMWARE-LDT-1477-1: comment by Sean Nash "Reverse order of comparison." Thu, 02 Apr 2026 09:01:38 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28196 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28196 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-1477-1

Reverse order of comparison.

]]> LEAHI-DD-FIRMWARE-LDT-1477-1: comment by Vinayakam Mani "Done." Wed, 01 Apr 2026 14:36:48 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28195 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28195 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1477-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3627-1: reviewers added to LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valv... Tue, 31 Mar 2026 09:36:56 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Sean Nash added Michael Garthwaite and Vinayakam Mani to LEAHI-DD-FIRMWARE-LDT-3627-1 LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1 ]]> LEAHI-DD-FIRMWARE-LDT-3218-4: started by Dara Navaei Wed, 25 Mar 2026 11:16:55 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3218-4 ]]> LEAHI-DD-FIRMWARE-LDT-2004-13: started by Dara Navaei Wed, 25 Mar 2026 04:01:46 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-13 ]]>