Fisheye on dd-firmware/firmware/App/Controllers/BalancingChamber.c https://devapps.diality.us/changelog/~br%3DLDT-3218-update-iofp-permeate-target-flow-CLEAN/dd-firmware/firmware/App/Controllers/BalancingChamber.c Recent activity in "dd-firmware" under directory /firmware/App/Controllers/BalancingChamber.c LEAHI-DD-FIRMWARE-LDT-3978-1: reviewers resumed Fri, 24 Apr 2026 22:17:00 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Vinayakam Mani resumed reviewing LEAHI-DD-FIRMWARE-LDT-3978-1 LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid ]]> LEAHI-DD-FIRMWARE-LDT-3978-1: reviewers joined LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conduc... Thu, 23 Apr 2026 14:59:17 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Vinayakam Mani joined LEAHI-DD-FIRMWARE-LDT-3978-1 LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid ]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "instead of 0, we can use the level Enum 'LVL_ST..." Thu, 23 Apr 2026 14:56:16 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28636 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28636 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "lower? and change the D98 level sensor comment ..." Thu, 23 Apr 2026 14:49:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28635 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28635 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

lower? and change the D98 level sensor comment as well.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Remove empty line" Thu, 23 Apr 2026 14:47:11 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28634 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28634 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Remove empty line

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Space before LVL_STATE_LOW" Thu, 23 Apr 2026 14:45:56 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28633 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28633 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Space before LVL_STATE_LOW

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "space inside array index." Thu, 23 Apr 2026 14:43:35 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28632 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28632 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

space inside array index.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Space inside parenthesis." Thu, 23 Apr 2026 14:41:03 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28631 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28631 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Space inside parenthesis.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Change this to LEVEL_T enum." Thu, 23 Apr 2026 14:39:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28630 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28630 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Change this to LEVEL_T enum.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Is this macro still being used? if not, delete ..." Thu, 23 Apr 2026 14:38:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28629 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28629 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Is this macro still being used? if not, delete it.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: started by Dara Navaei Thu, 23 Apr 2026 07:47:26 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3978-1 ]]> LEAHI-DD-FIRMWARE-LDT-3963-1: started by Dara Navaei Tue, 21 Apr 2026 09:17:58 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3963-1 ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: closed by Vendor - TEL - Sameer Poyil Mon, 20 Apr 2026 08:17:53 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 Vendor - TEL - Sameer Poyil Closed LEAHI-DD-FIRMWARE-LDT-2004-9 ]]> LEAHI-DD-FIRMWARE-LDT-3352-1: closed by Vinayakam Mani Fri, 17 Apr 2026 09:54:51 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 Vinayakam Mani Closed LEAHI-DD-FIRMWARE-LDT-3352-1 ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: reviewers finished Thu, 16 Apr 2026 23:17:41 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-2004-9 LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: started by Sean Nash Thu, 16 Apr 2026 23:13:27 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 Sean Nash started review LEAHI-DD-FIRMWARE-LDT-2004-9 ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: started by Vendor - TEL - Sameer Poyil Thu, 16 Apr 2026 16:23:22 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 Vendor - TEL - Sameer Poyil started review LEAHI-DD-FIRMWARE-LDT-2004-9 ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vendor - TEL - Sameer Poyil "Its static function and not used by external AP..." Thu, 16 Apr 2026 14:28:01 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28452 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28452 Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-2004-9

Its static function and not used by external API to pass the wrong id.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vendor - TEL - Sameer Poyil "0.0F is made by Sean." Wed, 15 Apr 2026 21:33:44 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28433 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28433 Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-2004-9

0.0F is made by Sean.

]]> dd-firmware (LDT-3749-ability-to-set-operation-sub-mode-latest): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Tue, 14 Apr 2026 21:22:53 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=94789b2f2324d5901685b6ff7b6224d4af3a0276 https://devapps.diality.us/changelog/dd-firmware?cs=94789b2f2324d5901685b6ff7b6224d4af3a0276 Dara Navaei committed 94789b2 on branch LDT-2004-dialysate-composition-dosing-control--dd, LDT-3218-update-iofp-permeate-target-flow-CLEAN and 11 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BalancingChamber.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/RinsePump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Ultrafiltration.c (-1, +1) | History | Source | Diff
· /firmware/App/DDCommon.h (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeGenDialysate.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeGenDialysate.h (-2, +2) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-2, +2) | History | Source | Diff
· /firmware/App/Monitors/Temperature.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-2, +2) | History | Source | Diff
]]> LEAHI-DD-FIRMWARE-LDT-3352-1: reviewers finished Tue, 14 Apr 2026 19:47:34 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 Sean Nash and Vendor - TEL - Sameer Poyil finished reviewing LEAHI-DD-FIRMWARE-LDT-3352-1 LEAHI-DD-FIRMWARE-LDT-3352_DD - revisit D3 level control logic ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vinayakam Mani "Same comment applies here (removing resetPICont..." Tue, 14 Apr 2026 19:28:15 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28365 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28365 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Same comment applies here (removing resetPIController).

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vinayakam Mani "I think we can remove the balancing chamber fil..." Tue, 14 Apr 2026 19:17:35 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28364 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28364 Vinayakam Mani replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-2004-9

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vinayakam Mani "Maintain space after and before parenthesis acr..." Tue, 14 Apr 2026 19:14:05 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28363 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28363 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Maintain space after and before parenthesis across the file.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vinayakam Mani "Do we need to add another else statement and ad..." Tue, 14 Apr 2026 19:06:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28362 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28362 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Do we need to add another else statement and address an alarm if wrong mixId is passed? or Keep only else part instead of else if ( ACID_MIX_ID == mixID) check?? this change may be needed across the file.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vinayakam Mani "Remove this comment." Tue, 14 Apr 2026 19:02:15 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28361 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28361 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Remove this comment.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vinayakam Mani "You may use getF32OverrideValue for consistency..." Tue, 14 Apr 2026 18:57:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28360 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28360 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-2004-9

You may use getF32OverrideValue for consistency (across the file).

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vinayakam Mani "The resetPIController is already invoked in Ini..." Tue, 14 Apr 2026 18:49:34 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28359 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28359 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-2004-9

The resetPIController is already invoked in InitializePIController with the InitialControlSignal. Instead of 0.0F, pass the STD_BICARB_DOSING as initialControlSignal ( in InitializePIController)

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vinayakam Mani "This is being repeated." Tue, 14 Apr 2026 18:21:15 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28358 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28358 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-2004-9

This is being repeated.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vinayakam Mani "Please add comment. if it is not being used, de..." Tue, 14 Apr 2026 18:20:05 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28357 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28357 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Please add comment. if it is not being used, delete it.

]]>