Fisheye on leahi-dialin/leahi_dialin/dd/modules/levels.py

LEAHI-DIALIN-LDT-3984-1: reviewers finished

Sun, 26 Apr 2026 12:25:57 -0700

Sean Nash finished reviewing LEAHI-DIALIN-LDT-3984-1

LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber

LEAHI-DIALIN-LDT-3984-1: started by Dara Navaei

Dara Navaei — Thu, 23 Apr 2026 08:02:29 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-3984-1

LEAHI-DIALIN-LDT-3557-1: closed by Zoltan Miskolci

Zoltan Miskolci — Thu, 05 Mar 2026 10:46:36 -0800

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3557-1

LEAHI-DIALIN-LDT-3557-1: reviewers finished

Thu, 05 Mar 2026 10:25:20 -0800

Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3557-1

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables

LEAHI-DIALIN-LDT-3557-1: reviewers finished

Tue, 03 Mar 2026 16:58:49 -0800

Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-3557-1

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables

LEAHI-DIALIN-LDT-3557-1: comment by Zoltan Miskolci "removed"

Zoltan Miskolci — Tue, 03 Mar 2026 15:28:18 -0800

Zoltan Miskolci replied to Michael Garthwaite in LEAHI-DIALIN-LDT-3557-1

removed

LEAHI-DIALIN-LDT-3557-1: comment by Michael Garthwaite "Remove this extra line"

Michael Garthwaite — Tue, 03 Mar 2026 09:13:22 -0800

Michael Garthwaite commented on LEAHI-DIALIN-LDT-3557-1

Remove this extra line

leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): - Moved enum def class to proxy file - Added comments to module files - Removed test config TEST_CONFIG_DD_DRY_BICART_TE...

Zoltan Miskolci — Wed, 25 Feb 2026 18:57:01 -0800

Zoltan Miskolci committed 20c821b on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 24 more in leahi-dialin

- Moved enum def class to proxy file - Added comments to module files - Removed test config TEST_CONFIG_DD_DRY_BICART_TEST

· /leahi_dialin/common/__init__.py

(-3, +3)

| History

| Source

| Diff

· /leahi_dialin/common/dd_defs.py

(-49, +1)

| History

| Source

| Diff

· /leahi_dialin/common/dd_defs_proxy.py

(-0, +63)

| History

| Source

· /leahi_dialin/common/fp_defs.py

(-37, +1)

| History

| Source

| Diff

· /leahi_dialin/common/fp_defs_proxy.py

(-0, +51)

| History

| Source

· /leahi_dialin/common/td_defs.py

(-47, +1)

| History

| Source

| Diff

· /leahi_dialin/common/td_defs_proxy.py

(-0, +61)

| History

| Source

· /leahi_dialin/common/test_config_defs.py

(-2, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-46, +46)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/alarms.py

(-22, +17)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/balancing_chamber.py

(-9, +10)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-14, +14)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-3, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dd_test_configs.py

(-2, +4)

| History

| Source

| Diff

… 46 more files in changeset.

LEAHI-DIALIN-LDT-3557-1: started by Dara Navaei

Dara Navaei — Fri, 20 Feb 2026 10:46:38 -0800

Dara Navaei started review LEAHI-DIALIN-LDT-3557-1

LEAHI-DIALIN-LDT-3160-1: closed by Dara Navaei

Dara Navaei — Wed, 28 Jan 2026 09:22:32 -0800

Dara Navaei Closed LEAHI-DIALIN-LDT-3160-1

LEAHI-DIALIN-LDT-3160-1: reviewers finished

Wed, 28 Jan 2026 09:17:50 -0800

Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3160-1

LEAHI-DIALIN-LDT-3160_Beta Dialin Test Configs Needed

LEAHI-DIALIN-LDT-3160-1: comment by Zoltan Miskolci "This was made for the UI team, but it slowing d..."

Zoltan Miskolci — Wed, 28 Jan 2026 09:08:12 -0800

Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-3160-1

This was made for the UI team, but it slowing down the init process and always throwing that error, that is not an error and not affecting the SW VV and SYS teams. So removing them to fasten the init process and to not have confusing messages

LEAHI-DIALIN-LDT-3160-1: comment by Raghu Kallala "why are we passing this exception?"

Raghu Kallala — Wed, 28 Jan 2026 09:00:47 -0800

Raghu Kallala commented on LEAHI-DIALIN-LDT-3160-1

why are we passing this exception?

LEAHI-DIALIN-LDT-3160-1: reviewers finished

Tue, 27 Jan 2026 13:49:41 -0800

Vinayakam Mani finished reviewing LEAHI-DIALIN-LDT-3160-1

LEAHI-DIALIN-LDT-3160_Beta Dialin Test Configs Needed

LEAHI-DIALIN-LDT-3160-1: reviewers added to LEAHI-DIALIN-LDT-3160_Beta Dialin Test Configs Nee...

Tue, 27 Jan 2026 13:47:39 -0800

Vinayakam Mani added Raghu Kallala to LEAHI-DIALIN-LDT-3160-1

LEAHI-DIALIN-LDT-3160_Beta Dialin Test Configs Needed

LEAHI-DIALIN-LDT-3160-1: comment by Zoltan Miskolci "merged"

Zoltan Miskolci — Tue, 27 Jan 2026 13:32:27 -0800

Zoltan Miskolci replied to Vinayakam Mani in LEAHI-DIALIN-LDT-3160-1

merged

LEAHI-DIALIN-LDT-3160-1: comment by Zoltan Miskolci "renamed"

Zoltan Miskolci — Tue, 27 Jan 2026 13:32:23 -0800

Zoltan Miskolci replied to Vinayakam Mani in LEAHI-DIALIN-LDT-3160-1

renamed

LEAHI-DIALIN-LDT-3160-1: comment by Zoltan Miskolci "renamed"

Zoltan Miskolci — Tue, 27 Jan 2026 13:32:19 -0800

Zoltan Miskolci replied to Vinayakam Mani in LEAHI-DIALIN-LDT-3160-1

renamed

LEAHI-DIALIN-LDT-3160-1: comment by Zoltan Miskolci "Updated based on FW"

Zoltan Miskolci — Tue, 27 Jan 2026 13:32:15 -0800

Zoltan Miskolci replied to Vinayakam Mani in LEAHI-DIALIN-LDT-3160-1

Updated based on FW

LEAHI-DIALIN-LDT-3160-1: comment by Raghu Kallala "Here is the latest list from fw TEST_CON..."

Raghu Kallala — Tue, 27 Jan 2026 13:18:54 -0800

Raghu Kallala commented on LEAHI-DIALIN-LDT-3160-1

Here is the latest list from fw

TEST_CONFIG_DD_FP_ENABLE_BETA_1_0_HW = 0, ///< Test configuration DD & FP enable Beta 1.0 hardware
TEST_CONFIG_FIRST = TEST_CONFIG_DD_FP_ENABLE_BETA_1_0_HW, ///< Test configuration first configuration.
TEST_CONFIG_DD_DISABLE_BC_PRESSURE_ALARMS, ///< Test configuration DD disabling BC pressure alarms
TEST_CONFIG_DD_ENABLE_DRY_BICARB, ///< Test configuration DD to use dry bicarb
TEST_CONFIG_DD_ENABLE_4WIRE_RINSE_PUMP, ///< Test configuration DD enable 4-wire rinse pump.
TEST_CONFIG_FP_SKIP_PRE_GEN_FLUSH, ///< Test configuration FP skip pre-gen flush
TEST_CONFIG_DD_ENABLE_DIENER_1000_PUMP, ///< Test configuration to use diener 1000 pump for D48
TEST_CONFIG_DD_ENABLE_D79_PWM_CONTROL, ///< Test configuration to switch to PWM control for D79
TEST_CONFIG_DD_ENABLE_SPENT_CHAMBER_H_FILL, ///< Test configuration DD enable spent chamber H fill
TEST_CONFIG_DD_DISABLE_CONDUCTIVITY_ALARMS, ///< Test configuration to disable DD conductivity alarms
TEST_CONFIG_FP_DISABLE_CONDUCTIVITY_ALARMS, ///< Test configuration to disable FP conductivity alarms
TEST_CONFIG_DD_ENABLE_DOSING_OPEN_LOOP_CONTROL, ///< Test configuration to switch to open loop control for concentrate dosing
TEST_CONFIG_DD_ENABLE_UF_TEMP_COMPENSATION, ///< Test configuration for enabling UF temperature compensation
NUM_OF_TEST_CONFIGS ///< Number of test configuration.

LEAHI-DIALIN-LDT-3160-1: comment by Vinayakam Mani "Please sync all of these with Firmware order of..."

Vinayakam Mani — Tue, 27 Jan 2026 11:48:37 -0800

Vinayakam Mani commented on LEAHI-DIALIN-LDT-3160-1

Please sync all of these with Firmware order of definitions.

LEAHI-DIALIN-LDT-3160-1: comment by Vinayakam Mani "TEST_CONFIG_DD_ENABLE_UF_TEMP_COMP. by default..."

Vinayakam Mani — Tue, 27 Jan 2026 11:44:26 -0800

Vinayakam Mani commented on LEAHI-DIALIN-LDT-3160-1

TEST_CONFIG_DD_ENABLE_UF_TEMP_COMP. by default, temp compensation is disabled.

LEAHI-DIALIN-LDT-3160-1: comment by Vinayakam Mani "TEST_CONFIG_DD_ENABLE_DOSING_OPEN_LOOP_CONTROL"

Vinayakam Mani — Tue, 27 Jan 2026 11:42:45 -0800

Vinayakam Mani commented on LEAHI-DIALIN-LDT-3160-1

TEST_CONFIG_DD_ENABLE_DOSING_OPEN_LOOP_CONTROL

LEAHI-DIALIN-LDT-3160-1: comment by Vinayakam Mani "ENABLE_DRY_BICART_FILL vs ENABLE_LIQUID_BICARB ..."

Vinayakam Mani — Tue, 27 Jan 2026 11:38:35 -0800

Vinayakam Mani commented on LEAHI-DIALIN-LDT-3160-1

ENABLE_DRY_BICART_FILL vs ENABLE_LIQUID_BICARB => we can use only one of these. We can keep test config 2 ( may rename as ENABLE_DRY_BICARB) and 8 can be deleted.

LEAHI-DIALIN-LDT-3160-1: comment by Zoltan Miskolci "updated"

Zoltan Miskolci — Tue, 27 Jan 2026 11:40:21 -0800

Zoltan Miskolci replied to Vinayakam Mani in LEAHI-DIALIN-LDT-3160-1

updated

LEAHI-DIALIN-LDT-3160-1: comment by Zoltan Miskolci "updated, thanks for the confirmation"

Zoltan Miskolci — Tue, 27 Jan 2026 11:40:16 -0800

Zoltan Miskolci replied to Vinayakam Mani in LEAHI-DIALIN-LDT-3160-1

updated, thanks for the confirmation

LEAHI-DIALIN-LDT-3160-1: comment by Vinayakam Mani "TEST_CONFIG_DD_ENABLE_SPENT_CHAMBER_H_FILL"

Vinayakam Mani — Tue, 27 Jan 2026 11:37:35 -0800

Vinayakam Mani commented on LEAHI-DIALIN-LDT-3160-1

TEST_CONFIG_DD_ENABLE_SPENT_CHAMBER_H_FILL

LEAHI-DIALIN-LDT-3160-1: comment by Vinayakam Mani "TEST_CONFIG_DD_ENABLE_D79_PWM_CONTROL. On/Off ..."

Vinayakam Mani — Tue, 27 Jan 2026 11:35:24 -0800

Vinayakam Mani commented on LEAHI-DIALIN-LDT-3160-1

TEST_CONFIG_DD_ENABLE_D79_PWM_CONTROL. On/Off control is default support.

LEAHI-DIALIN-LDT-3160-1: comment by Zoltan Miskolci "renamed"

Zoltan Miskolci — Tue, 27 Jan 2026 11:34:25 -0800

Zoltan Miskolci replied to Vinayakam Mani in LEAHI-DIALIN-LDT-3160-1

renamed

LEAHI-DIALIN-LDT-3160-1: reviewers added to LEAHI-DIALIN-LDT-3160_Beta Dialin Test Configs Nee...

Tue, 27 Jan 2026 11:33:29 -0800

Zoltan Miskolci added Vendor - TEL - Varshini Nagabooshanam to LEAHI-DIALIN-LDT-3160-1

LEAHI-DIALIN-LDT-3160_Beta Dialin Test Configs Needed