LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber

Activity

LEAHI-DIALIN-LDT-3984-1 5

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 39m    
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 72% reviewed 14m 3 What's the point of this line if you overwrite the lvl_se...
    Reviewer - 7% reviewed 2m    
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 84% reviewed 14m 2 This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and F...
    Total   1h 10m 5  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /leahi_dialin/common/dd_defs.py Changed
    Open in IDE #permalink
    /leahi_dialin/common/fp_defs.py Changed 2
    Open in IDE #permalink
    /leahi_dialin/common/msg_ids.py Changed
    Open in IDE #permalink
    /leahi_dialin/dd/modules/levels.py Changed 1
    Open in IDE #permalink
    /leahi_dialin/fp/modules/levels.py Changed 2
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time