Fisheye on leahi-dialin/leahi_dialin/fp/modules/temperatures.py https://devapps.diality.us/changelog/~br%3DLDT-3287-dialin-ability-to-pull-b1.9-iof/leahi-dialin/leahi_dialin/fp/modules/temperatures.py Recent activity in "leahi-dialin" under directory /leahi_dialin/fp/modules/temperatures.py LEAHI-DIALIN-LDT-2655-1: reviewers finished Mon, 30 Mar 2026 09:39:06 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 Sean Nash finished reviewing LEAHI-DIALIN-LDT-2655-1 LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module ]]> LEAHI-DIALIN-LDT-2655-1: comment by Michael Garthwaite "yeah its obsolete. This is an old branch that r..." Mon, 16 Mar 2026 10:04:25 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1/#c28052 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1/#c28052 Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LDT-2655-1

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( conductivity sensors ).

]]> LEAHI-DIALIN-LDT-3629-1: closed by Zoltan Miskolci Thu, 12 Mar 2026 14:32:23 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1 Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3629-1 ]]> LEAHI-DIALIN-LDT-3629-1: reviewers finished Thu, 12 Mar 2026 14:12:47 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1 Michael Garthwaite and Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3629-1 LEAHI-DIALIN-LDT-3629_FP and DD valve_states_enum are one short of the full valve list ]]> LEAHI-DIALIN-LDT-3629-1: comment by Zoltan Miskolci "Fixed" Thu, 12 Mar 2026 11:50:16 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27939 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27939 Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-3629-1

Fixed

]]> LEAHI-DIALIN-LDT-3629-1: comment by Zoltan Miskolci "added Todo comment" Thu, 12 Mar 2026 11:48:59 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27938 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27938 Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-3629-1

added Todo comment

]]> LEAHI-DIALIN-LDT-3629-1: comment by Zoltan Miskolci "They were added while debugging fp_test_configs..." Thu, 12 Mar 2026 11:47:16 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27937 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27937 Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-3629-1

They were added while debugging fp_test_configs and why it's never being updated.
Removed.

]]> LEAHI-DIALIN-LDT-3629-1: comment by Michael Garthwaite "tip: use the logger and set the statement to er..." Thu, 12 Mar 2026 10:59:15 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27936 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27936 Michael Garthwaite replied to Raghu Kallala in LEAHI-DIALIN-LDT-3629-1

tip: use the logger and set the statement to error level and you can see it in runtime

]]> LEAHI-DIALIN-LDT-3629-1: comment by Raghu Kallala "pressure limit will be unsigned int not signed ..." Thu, 12 Mar 2026 09:49:11 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27913 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27913 Raghu Kallala commented on LEAHI-DIALIN-LDT-3629-1

pressure limit will be unsigned int not signed int with LDT-473..beta CR
Add a TODO to update once the 473 is ready to merge

]]> LEAHI-DIALIN-LDT-3629-1: comment by Raghu Kallala "Are these print statements add for debugging? ..." Thu, 12 Mar 2026 09:45:48 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27912 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27912 Raghu Kallala commented on LEAHI-DIALIN-LDT-3629-1

Are these print statements add for debugging?
If not, is this allowed

]]> LEAHI-DIALIN-LDT-3629-1: comment by Raghu Kallala "typo, PUMP_ON_STATE" Thu, 12 Mar 2026 09:36:55 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27910 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27910 Raghu Kallala commented on LEAHI-DIALIN-LDT-3629-1

typo, PUMP_ON_STATE

]]> LEAHI-DIALIN-LDT-3629-1: started by Dara Navaei Tue, 10 Mar 2026 11:48:46 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1 Dara Navaei started review LEAHI-DIALIN-LDT-3629-1 ]]> LEAHI-DIALIN-LDT-3557-1: closed by Zoltan Miskolci Thu, 05 Mar 2026 10:46:36 -0800 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1 Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3557-1 ]]> LEAHI-DIALIN-LDT-3557-1: reviewers finished Thu, 05 Mar 2026 10:25:20 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1 Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3557-1 LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables ]]> LEAHI-DIALIN-LDT-2655-1: reviewers joined LEAHI-DIALIN-LDT-2655_Cannot override conductivity... Wed, 04 Mar 2026 12:46:36 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 Dara Navaei joined LEAHI-DIALIN-LDT-2655-1 LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module ]]> LEAHI-DIALIN-LDT-2655-1: reviewers removed from LEAHI-DIALIN-LDT-2655_Cannot override conductivity... Wed, 04 Mar 2026 12:46:36 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 Dara Navaei removed Michael Garthwaite from LEAHI-DIALIN-LDT-2655-1 LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module ]]> LEAHI-DIALIN-LDT-3557-1: reviewers finished Tue, 03 Mar 2026 16:58:49 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1 Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-3557-1 LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables ]]> LEAHI-DIALIN-LDT-3557-1: comment by Zoltan Miskolci "removed" Tue, 03 Mar 2026 15:28:18 -0800 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1/#c27734 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1/#c27734 Zoltan Miskolci replied to Michael Garthwaite in LEAHI-DIALIN-LDT-3557-1

removed

]]> LEAHI-DIALIN-LDT-3557-1: comment by Michael Garthwaite "Remove this extra line" Tue, 03 Mar 2026 09:13:22 -0800 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1/#c27718 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1/#c27718 Michael Garthwaite commented on LEAHI-DIALIN-LDT-3557-1

Remove this extra line

]]> LEAHI-DIALIN-LDT-3557-1: started by Dara Navaei Fri, 20 Feb 2026 10:46:38 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3557-1 Dara Navaei started review LEAHI-DIALIN-LDT-3557-1 ]]> LEAHI-DIALIN-LDT-3479-1: closed by Zoltan Miskolci Thu, 12 Feb 2026 13:29:38 -0800 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3479-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3479-1 Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3479-1 ]]> LEAHI-DIALIN-LDT-3479-1: reviewers finished Thu, 12 Feb 2026 10:41:36 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3479-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3479-1 Michael Garthwaite and Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3479-1 LEAHI-DIALIN-LDT-3479_D98 is in DD conductivity module ]]> LEAHI-DIALIN-LDT-3479-1: reviewers added to LEAHI-DIALIN-LDT-3479_D98 is in DD conductivity mo... Thu, 12 Feb 2026 09:48:10 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3479-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3479-1 Zoltan Miskolci added Raghu Kallala to LEAHI-DIALIN-LDT-3479-1 LEAHI-DIALIN-LDT-3479_D98 is in DD conductivity module ]]> LEAHI-DIALIN-LDT-3479-1: comment by Zoltan Miskolci "Removed" Thu, 12 Feb 2026 09:29:12 -0800 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3479-1/#c27244 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3479-1/#c27244 Zoltan Miskolci replied to Michael Garthwaite in LEAHI-DIALIN-LDT-3479-1

Removed

]]> LEAHI-DIALIN-LDT-3479-1: comment by Michael Garthwaite "There is one more -1 that considered D98. fp.co..." Thu, 12 Feb 2026 09:22:21 -0800 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3479-1/#c27241 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3479-1/#c27241 Michael Garthwaite commented on LEAHI-DIALIN-LDT-3479-1

There is one more -1 that considered D98. fp.conductivity.cmd_conductivity_sensor_filtered_readings_override()

]]> LEAHI-DIALIN-LDT-3287-1: closed by Michael Garthwaite Wed, 11 Feb 2026 11:33:21 -0800 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3287-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3287-1 Michael Garthwaite Closed LEAHI-DIALIN-LDT-3287-1 ]]> LEAHI-DIALIN-LDT-3480-1: closed by Raghu Kallala Wed, 11 Feb 2026 11:07:58 -0800 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3480-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3480-1 Raghu Kallala Closed LEAHI-DIALIN-LDT-3480-1 ]]> LEAHI-DIALIN-LDT-3287-1: reviewers finished Wed, 11 Feb 2026 10:10:35 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3287-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3287-1 Zoltan Miskolci finished reviewing LEAHI-DIALIN-LDT-3287-1 LEAHI-DIALIN-LDT-3287_Dialin ability to pull B1.9 IOFP variable data has changed from B1.0 ]]> leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): Merge branch 'staging' into LDT-3287-dialin-ability-to-pull-b1.9-iof Wed, 11 Feb 2026 10:06:35 -0800 Michael Garthwaite https://devapps.diality.us/changelog/leahi-dialin?cs=b7c5c99c3b19c901e05566184098d427c9b9d666 https://devapps.diality.us/changelog/leahi-dialin?cs=b7c5c99c3b19c901e05566184098d427c9b9d666 Michael Garthwaite committed b7c5c99 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 28 more in leahi-dialin Merge branch 'staging' into LDT-3287-dialin-ability-to-pull-b1.9-iof

· /leahi_dialin/fp/modules/temperatures.py (-30, +19) | History | Source | Diff
]]> LEAHI-DIALIN-LDT-3480-1: reviewers finished Wed, 11 Feb 2026 10:01:38 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3480-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3480-1 Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-3480-1 LEAHI-DIALIN-LDT-3480_Improper match on IOFP temperature sensors ]]>