LEAHI-DIALIN-LDT-3629_FP and DD valve_states_enum are one short of the full...

Activity

LEAHI-DIALIN-LDT-3629-1 7

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 7m 3 Fixed
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - Complete 16m 3 pressure limit will be unsigned int not signed int with L...
    Reviewer - Complete 3m 1 tip: use the logger and set the statement to error level ...
    Total   27m 7  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /leahi_dialin/common/fp_defs.py Changed 2
    Open in IDE #permalink
    /leahi_dialin/common/fp_defs_proxy.py Changed
    Open in IDE #permalink
    /leahi_dialin/common/test_config_defs.py Changed
    Open in IDE #permalink
    /leahi_dialin/dd/modules/valves.py Changed
    Open in IDE #permalink
    /leahi_dialin/fp/modules/boost_pump.py Changed
    Open in IDE #permalink
    /leahi_dialin/.../modules/fp_test_configs.py Changed 3
    Open in IDE #permalink
    /leahi_dialin/fp/modules/ro_pump.py Changed
    Open in IDE #permalink
    /leahi_dialin/fp/modules/temperatures.py Changed
    Open in IDE #permalink
    /leahi_dialin/fp/modules/valves.py Changed
    Open in IDE #permalink
    /leahi_dialin/.../modules/pressure_sensors.py Changed 2
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time