Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

Reduced gain and testing in progress.

Reduced gain and testing in progress.

Done.

Done.

Not sure these min/max are right here either.

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

Remove extra blank lines.

Done.

Done

Done.

Same comment.

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

Input is d78TempAvgC

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

Done.

Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.

Done.

Done.

Done.

Algin "=" to be consistent with those below.

Add blank line after declarations.

Add blank line after declarations.

Align comment.

Is it time to restore?

Remove extra space after "=".

Are we going to restore this or not?

Are we going to restore this or not?

Are we going to restore this or not?