So I think this compiler will give you 64 bit if you ask for long. Did you intend it to be 64 bit? If not, you can just use the BIT_BY_POS macro above.

Removing it now. will introduce it later if required

will finalize it when ocean spray logic is tested

dryBicartState is top level state machine which is different data type. removed dryBicartSubstate

removed

This is not extra blank line its a line for TASK_GENERAL_INTERVAL )

a macro used to create a contiguous bitmask starting at bit position l (low) and ending at bit position h

nr means short form of bit 'number', unsigned long is portable, 32bit for 32-bit cpu and 64 bits for 64bit cpu whereas unsigned int is always 32 bits regardless of architecture.

Remove this blank line.

Put () around each of the 2 conditions being ANDed.

Remove blank line.

Remove blank line.

Add a blank line after declarations.

Remove blank line.

Should we remove this else if or is it going to be restored later?

Remove extra blank lines.

Shouldn't we be assigning dryBicartState instead of dryBicartSubstate in all of these cases?

Why do we need this?

Remove extra blank line.

Remove extra blank line.

Not clear what GENMASK is doing. What do h and l refer to. This doesn't look like a simple bit mask.

Is this for 64 bit unsigned integer? If not, this is redundant with BIT_BY_POS above.
What does nr stand for?

Let's remove this commented line.

I don't need to edit this file. I will check with Dara to exclude this file from code review.

only maximum 30 float data is allowed. If that is the case then I cannot broadcast the acid or bicarb control signals.
need to split it or need two message id.

Its a problem . Vinay has to decide it

Algin "=" to be consistent with those below.

Add blank line after declarations.