Fisheye on dd-firmware/firmware/App/Controllers/Heaters.c https://devapps.diality.us/changelog/~br%3DLDT-3735-non-volatile-memory/dd-firmware/firmware/App/Controllers/Heaters.c Recent activity in "dd-firmware" under directory /firmware/App/Controllers/Heaters.c LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Not sure these min/max are right here either." Mon, 06 Apr 2026 10:30:32 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28230 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28230 Sean Nash replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-3352-1

Not sure these min/max are right here either.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "So we have all temp sensors getting averaged no..." Mon, 06 Apr 2026 10:27:34 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28229 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28229 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Remove extra blank lines." Mon, 06 Apr 2026 10:24:54 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28227 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28227 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

Remove extra blank lines.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Fri, 03 Apr 2026 15:35:04 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28219 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28219 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done" Fri, 03 Apr 2026 15:34:48 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28218 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28218 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Fri, 03 Apr 2026 15:34:30 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28217 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28217 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Same comment." Fri, 03 Apr 2026 13:20:23 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28216 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28216 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

Same comment.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Having much larger P coeff is likely to cause a..." Fri, 03 Apr 2026 13:18:56 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28215 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28215 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Input is d78TempAvgC" Fri, 03 Apr 2026 13:14:56 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28214 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28214 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

Input is d78TempAvgC

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "I don't think these min/max (for control output..." Fri, 03 Apr 2026 13:11:46 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28213 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28213 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:43:57 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28210 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28210 Vinayakam Mani replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Just following the current style of code implem..." Thu, 02 Apr 2026 15:42:21 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28209 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28209 Vinayakam Mani replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-3352-1

Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:40:23 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28208 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28208 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:39:59 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28207 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28207 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:39:30 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28206 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28206 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-2008-1: reviewers added to LEAHI-DD-FIRMWARE-LDT-2008_Dialysate Composition -... Thu, 02 Apr 2026 09:37:31 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1 Dara Navaei added Vinayakam Mani to LEAHI-DD-FIRMWARE-LDT-2008-1 LEAHI-DD-FIRMWARE-LDT-2008_Dialysate Composition - DD - 04: DEV - Feature Implementation ]]> LEAHI-DD-FIRMWARE-LDT-2008-1: reviewers removed from LEAHI-DD-FIRMWARE-LDT-2008_Dialysate Composition -... Thu, 02 Apr 2026 09:37:31 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1 Dara Navaei removed Behrouz NematiPour , Michael Garthwaite and 5 others from LEAHI-DD-FIRMWARE-LDT-2008-1 LEAHI-DD-FIRMWARE-LDT-2008_Dialysate Composition - DD - 04: DEV - Feature Implementation ]]> LEAHI-DD-FIRMWARE-LDT-2008-1: started by Dara Navaei Mon, 30 Mar 2026 14:47:12 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2008-1 ]]> LEAHI-DD-FIRMWARE-LDT-3750-3: closed by Dara Navaei Mon, 30 Mar 2026 10:17:47 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3750-3 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3750-3 Dara Navaei Closed LEAHI-DD-FIRMWARE-LDT-3750-3 ]]> LEAHI-DD-FIRMWARE-LDT-3750-3: reviewers finished Mon, 30 Mar 2026 10:15:29 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3750-3 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3750-3 Vendor - TEL - Varshini Nagabooshanam and Vendor - TEL - Jashwant Gantyada finished reviewing LEAHI-DD-FIRMWARE-LDT-3750-3 LEAHI-DD-FIRMWARE-LDT-3750_DD_Staging_Rebase ]]> LEAHI-DD-FIRMWARE-LDT-3750-3: reviewers joined LEAHI-DD-FIRMWARE-LDT-3750_DD_Staging_Rebase Mon, 30 Mar 2026 10:15:19 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3750-3 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3750-3 Vendor - TEL - Varshini Nagabooshanam joined LEAHI-DD-FIRMWARE-LDT-3750-3 LEAHI-DD-FIRMWARE-LDT-3750_DD_Staging_Rebase ]]> LEAHI-DD-FIRMWARE-LDT-2004-13: started by Dara Navaei Wed, 25 Mar 2026 04:01:46 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-13 ]]> LEAHI-DD-FIRMWARE-LDT-2004-12: started by Dara Navaei Tue, 24 Mar 2026 14:31:19 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-12 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-12 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-12 ]]> LEAHI-DD-FIRMWARE-LDT-2004-11: started by Dara Navaei Thu, 19 Mar 2026 15:47:06 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-11 ]]> dd-firmware (LDT-553-water-treatment-and-degassing-baro): LDT-3750 added code from staging HEAD Wed, 18 Mar 2026 15:59:08 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=0797158d6e367debb04e043798f1aeb1fb17063b https://devapps.diality.us/changelog/dd-firmware?cs=0797158d6e367debb04e043798f1aeb1fb17063b Dara Navaei committed 0797158 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 17 more in dd-firmware LDT-3750 added code from staging HEAD

· /firmware/App/Controllers/Heaters.c (-0, +3) | History | Source | Diff
· /firmware/App/Drivers/ConductivityTeensy.c (-205, +47) | History | Source | Diff
· /firmware/App/Drivers/ConductivityTeensy.h (-18, +1) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-3, +0) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-3, +12) | History | Source | Diff
· /firmware/App/Monitors/WaterQualityMonitor.c (-1, +5) | History | Source | Diff
]]> LEAHI-DD-FIRMWARE-LDT-3750-3: reviewers added to LEAHI-DD-FIRMWARE-LDT-3750_DD_Staging_Rebase Wed, 18 Mar 2026 15:37:36 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3750-3 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3750-3 Dara Navaei added Michael Garthwaite , Raghu Kallala and 5 others to LEAHI-DD-FIRMWARE-LDT-3750-3 LEAHI-DD-FIRMWARE-LDT-3750_DD_Staging_Rebase ]]> LEAHI-DD-FIRMWARE-LDT-3750-3: started by Dara Navaei Tue, 17 Mar 2026 14:46:28 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3750-3 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3750-3 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3750-3 ]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Remove extra blank line." Fri, 13 Mar 2026 09:33:38 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28013 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28013 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

Remove extra blank line.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Should we create a structure for these moving a..." Fri, 13 Mar 2026 09:28:35 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28012 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28012 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors?
It looks kind of messy having separate handling for each sensor - can we consolidate some of this code?

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Should we maybe just have a constant array of s..." Fri, 13 Mar 2026 09:28:05 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28011 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28011 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

]]>