Remove this flag.

Remove this code.

Remove this condition to apply the speed for BC switch only as well.

Check the else portion and do the required changes.

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

I guess, all these checks should be moved to FillEndState.

after one state of BC switching completed. update the next comment as well.

Should we add a TODO to remove this one as well?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

Please update the function name : testDDFloaterLevelStateOverride

Why are we removing this TODO comment? It looks like we should keep it.

Do we need TODO comments to restore these alarms later?

What is the point of this message?

Looks like we need a TODO comment to restore these checks later.

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

· /firmware/App/Controllers/BalancingChamber.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/BalancingChamber.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFault.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePostGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeService.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-2, +2)	| History	| Source	| Diff

]]> Fri, 10 Apr 2026 11:38:33 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-1195-2 LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F) ]]> Mon, 06 Apr 2026 11:36:05 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2/#c28242 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2/#c28242 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-1195-2

Balancing chamber switching control

remove the space before false.

Remove blank line

Remove blank line.

I tried the suggested change and tested. But it did not provide the expected results.
If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without the actual request being processed and the off request was never executed.