Remove this flag.

Remove this code.

Remove this condition to apply the speed for BC switch only as well.

Check the else portion and do the required changes.

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

I guess, all these checks should be moved to FillEndState.

after one state of BC switching completed. update the next comment as well.

Should we add a TODO to remove this one as well?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

Please update the function name : testDDFloaterLevelStateOverride

Why are we removing this TODO comment? It looks like we should keep it.

Do we need TODO comments to restore these alarms later?

What is the point of this message?

Looks like we need a TODO comment to restore these checks later.

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

· /firmware/App/Controllers/RinsePump.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.h	(-2, +2)	| History	| Source	| Diff

]]> Fri, 03 Apr 2026 09:31:01 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Vendor - TEL - Jashwant Gantyada Closed LEAHI-DD-FIRMWARE-LDT-3627-1 ]]> Fri, 03 Apr 2026 08:32:42 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3627-1 LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1 ]]> Thu, 02 Apr 2026 15:35:36 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3627-1 LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1 ]]> Thu, 02 Apr 2026 14:50:52 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/changelog/dd-firmware?cs=3bfe4dde2875490b4e7fa595f634f30e19422210 https://devapps.diality.us/changelog/dd-firmware?cs=3bfe4dde2875490b4e7fa595f634f30e19422210 Vendor - TEL - Jashwant Gantyada committed 3bfe4dd on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-2008-v2-conductivity-sensors-CLEAN and 29 more in dd-firmware LDT-3627 resolved implicit declaration for rinse pump function

· /firmware/App/Controllers/RinsePump.c	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.h	(-1, +0)	| History	| Source	| Diff

]]> Tue, 31 Mar 2026 09:36:56 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Sean Nash added Michael Garthwaite and Vinayakam Mani to LEAHI-DD-FIRMWARE-LDT-3627-1 LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1 ]]> Mon, 16 Mar 2026 13:52:13 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3627-1 ]]> Tue, 24 Feb 2026 11:55:37 -0800 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 Vendor - TEL - Jashwant Gantyada Closed LEAHI-DD-FIRMWARE-LDT-3344-1 ]]> Tue, 24 Feb 2026 10:38:34 -0800 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=046bc2b62cf942b7e846fa5bff698b94238edf24 https://devapps.diality.us/changelog/dd-firmware?cs=046bc2b62cf942b7e846fa5bff698b94238edf24 Dara Navaei committed 046bc2b on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 49 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/RinsePump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/FluidPump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/GPIO.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/GPIO.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushConcentrate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.h	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskPriority.c	(-2, +2)	| History	| Source	| Diff

]]> Tue, 24 Feb 2026 10:35:01 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 Raghu Kallala , Vinayakam Mani and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3344-1 LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates. ]]> Mon, 23 Feb 2026 13:18:40 -0800 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 Vendor - TEL - Jashwant Gantyada started review LEAHI-DD-FIRMWARE-LDT-3344-1 ]]>