we don't need pragma alignment on enums, could you exclude it ?

Updated to ml/min, except for broadcast in treatment mode

What TD does with UF rate is mostly to tell DD what rate we want. DD wants mL/min. TD can keep L/hr and convert to mL/min every time it needs to send DD a message or it can keep mL/min and convert to L/hr every time it needs to send UI a message. Either way works for me.

Changed to U32

we are sending a message ack as response in the handler of this message request

Other existing set functions in TD is using UF in liter and rate in L/hr

Shall I change all of them? Which might impact how systems is sending this info(L/hr or ml/min) in their scripts

I think DD (and TD) want mL/min and UI wants L/hr. TxParams should have already calculated this rate (in mL/min) and should probably have a get function you can call from here to access it. When sending UF rate to UI, we would convert back to L/hr first, but everywhere else we would work with mL/min.

Remove extra blank line.

Remove extra space before function name.

This is not a Dialin message, so move up above all of these "test" functions.

Why is this in TDCommon? It should probably be in MessagePayloads.h or DDDefs.h so both DD and TD f/w can share this payload structure. And the common definitions should be added to appropriate doxygen group.

Do we have a return confirmation that the command is accepted by DD?

Is the UF rate unit in ml/min (instead of hr.)?

Are we assuming the sub mode return is pre-gen sub mode always?

create the getDialGoodToDeliverStatus() function and have that return true rather than have the assignment here

comment still needed?

· /firmware/App/Modes/ModeStandby.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxDialysis.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Pressures.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/DDInterface.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/DDInterface.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/TDCommon.h	(-2, +2)	| History	| Source	| Diff

]]> Wed, 29 Apr 2026 10:57:14 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 Raghu Kallala Closed LEAHI-TD-FIRMWARE-LDT-473-3 ]]> Wed, 29 Apr 2026 10:44:00 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 Vinayakam Mani finished reviewing LEAHI-TD-FIRMWARE-LDT-473-3 LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation ]]> Tue, 28 Apr 2026 18:13:22 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-473-3 LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation ]]> Tue, 28 Apr 2026 14:31:18 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28733 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28733 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

???

Do we need a parameter for confirmation?

Added to be consistent. Once institutional records are implemented will store it in there instead of a macro

DO we need bicarb conversion factor as well?

preweight can be non-zero

Add blank line after declarations.