Remove this flag.

Remove this code.

Remove this condition to apply the speed for BC switch only as well.

Check the else portion and do the required changes.

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

I guess, all these checks should be moved to FillEndState.

after one state of BC switching completed. update the next comment as well.

Should we add a TODO to remove this one as well?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

Please update the function name : testDDFloaterLevelStateOverride

Why are we removing this TODO comment? It looks like we should keep it.

Do we need TODO comments to restore these alarms later?

What is the point of this message?

Looks like we need a TODO comment to restore these checks later.

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

· /firmware/App/Controllers/BalancingChamber.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Heaters.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Heaters.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Ultrafiltration.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Drivers/TemperatureSensors.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Temperature.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Temperature.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff

]]> Tue, 14 Apr 2026 19:47:34 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 Sean Nash and Vendor - TEL - Sameer Poyil finished reviewing LEAHI-DD-FIRMWARE-LDT-3352-1 LEAHI-DD-FIRMWARE-LDT-3352_DD - revisit D3 level control logic ]]> Tue, 14 Apr 2026 16:39:54 -0700 Vinayakam Mani https://devapps.diality.us/changelog/dd-firmware?cs=4cdcb589ad34efa472c94180e6de938132cbc89b https://devapps.diality.us/changelog/dd-firmware?cs=4cdcb589ad34efa472c94180e6de938132cbc89b Vinayakam Mani committed 4cdcb58 on branch LDT-3218-update-iofp-permeate-target-flow-CLEAN, LDT-3272-software-update---dd-firmware and 22 more in dd-firmware LDT-3352 resolving merge issues

· /firmware/App/Controllers/BalancingChamber.c	(-78, +428)	| History	| Source	| Diff
· /firmware/App/Controllers/Heaters.c	(-7, +14)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.c	(-1, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Ultrafiltration.c	(-14, +29)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-6, +3)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-16, +40)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.h	(-2, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/Temperature.c	(-28, +26)	| History	| Source	| Diff
· /firmware/App/Monitors/Temperature.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-4, +5)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-25, +20)	| History	| Source	| Diff

]]> Mon, 13 Apr 2026 14:58:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28299 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28299 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

Reduced gain and testing in progress.

Reduced gain and testing in progress.

Done.

Done.