Remove this flag.

Remove this code.

Remove this condition to apply the speed for BC switch only as well.

Check the else portion and do the required changes.

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

I guess, all these checks should be moved to FillEndState.

after one state of BC switching completed. update the next comment as well.

Should we add a TODO to remove this one as well?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

Please update the function name : testDDFloaterLevelStateOverride

Why are we removing this TODO comment? It looks like we should keep it.

Do we need TODO comments to restore these alarms later?

What is the point of this message?

Looks like we need a TODO comment to restore these checks later.

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

· /firmware/App/Controllers/PermeateTank.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivitySensors.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivitySensors.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/FPOperationModes.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushFilterDefeatured.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	| History	| Source	| Diff

]]> Mon, 20 Apr 2026 09:23:14 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 Vinayakam Mani and Vendor - TEL - Jashwant Gantyada finished reviewing LEAHI-DD-FIRMWARE-LDT-3984-1 LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber ]]> Mon, 20 Apr 2026 06:52:48 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1/#c28540 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1/#c28540 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-3984-1

fixed

· /firmware/App/Drivers/ConductivitySensors.c

(-2, +2)

| History

| Source

| Diff

]]> Fri, 17 Apr 2026 18:02:29 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 Sean Nash added Vendor - TEL - Jashwant Gantyada and Vinayakam Mani to LEAHI-DD-FIRMWARE-LDT-3984-1 LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber ]]> Fri, 17 Apr 2026 17:17:01 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1/#c28539 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1/#c28539 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3984-1

Align the comments.

· /firmware/App/Controllers/PermeateTank.c	(-29, +35)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivitySensors.c	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivitySensors.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/FPOperationModes.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.c	(-1, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushFilterDefeatured.c	(-14, +21)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	| History	| Source	| Diff

]]> Thu, 16 Apr 2026 14:08:03 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=b6b17e417c14f820a81e93dd7b20aa9dd790a7c1 https://devapps.diality.us/changelog/dd-firmware?cs=b6b17e417c14f820a81e93dd7b20aa9dd790a7c1 Dara Navaei committed b6b17e4 on branch LDT-3272-software-update---dd-firmware, LDT-3749-ability-to-set-operation-sub-mode-latest and 19 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Drivers/ConductivitySensors.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivitySensors.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-1, +1)	| History	| Source	| Diff

]]>