Activity dd-firmware/

1 hr ago

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3749-2
commented on review

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we imple...

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we implemented in TD interface).

7:31 pm

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-3735-1
started review

LEAHI-DD-FIRMWARE-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation

2:13 pm

Vendor - TEL - Jashwant Gantyada

removed

2:13 pm

Vendor - TEL - Jashwant Gantyada

updated comment.

2:13 pm

Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-3103-3
resumed reviewing

2:12 pm

Vendor - TEL - Jashwant Gantyada

removed.

2:12 pm

Vendor - TEL - Jashwant Gantyada

removed and added comments.

2:12 pm

Vinayakam Mani

2:12 pm

Vendor - TEL - Jashwant Gantyada

changed.

2:12 pm

Vendor - TEL - Jashwant Gantyada

done. moved them to dosing concentrates state.

1:06 pm

Raghu Kallala

1:00 pm

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-3749-2
started review

LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem

12:55 pm

Raghu Kallala

More
37a576d
changed 1 file
LDT-3749-ability-to-set-operation-sub-mode-latest LEAHI-DD-FIRMWARE-LDT-3749-2

LDT-3749 added transition signal for DD gen dialysate applicable states

- -4
- +18
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

12:46 pm

Raghu Kallala

More
345a9b1
changed 13 files
LDT-3749-ability-to-set-operation-sub-mode-latest LEAHI-DD-FIRMWARE-LDT-3749-2

LDT-3749 initial structure for set operation sub mode request.

- -0
- +62
/firmware/App/Modes/ModeFault.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFault.c
- -0
- +3
/firmware/App/Modes/ModeFault.h
- History
- Source
- Diff
/firmware/App/Modes/ModeFault.h
- -0
- +67
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c
- -0
- +2
/firmware/App/Modes/ModeGenDialysate.h
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.h
- -0
- +56
/firmware/App/Modes/ModePostGenDialysate.c
- History
- Source
- Diff
/firmware/App/.../ModePostGenDialysate.c
- -0
- +2
/firmware/App/Modes/ModePostGenDialysate.h
- History
- Source
- Diff
/firmware/App/.../ModePostGenDialysate.h
- -0
- +61
/firmware/App/Modes/ModePreGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreGenDialysate.c
- -0
- +2
/firmware/App/Modes/ModePreGenDialysate.h
- History
- Source
- Diff
/firmware/App/Modes/ModePreGenDialysate.h
- -0
- +54
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c
- -0
- +3
/firmware/App/Modes/ModeStandby.h
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.h
- -0
- +160
/firmware/App/Modes/OperationModes.c
- History
- Source
- Diff
/firmware/App/Modes/OperationModes.c
- -0
- +1
/firmware/App/Modes/OperationModes.h
- History
- Source
- Diff
/firmware/App/Modes/OperationModes.h
- -0
- +1
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c

12:45 pm

Raghu Kallala

11:52 am

Vendor - TEL - Jashwant Gantyada and Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-1477-1
finished reviewing

11:36 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-1195-2
commented on review

Balancing chamber switching control

11:32 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-1195-2
commented on review

Can this statement be 'else if' case after BC switch only request handling (after line 1013). Just in case both requests (switch only and regular one) came together and only 'switch only' handled f...

Can this statement be 'else if' case after BC switch only request handling (after line 1013). Just in case both requests (switch only and regular one) came together and only 'switch only' handled first.

11:29 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-1195-2
commented on review

remove the space before false.

11:23 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-1195-2
commented on review

Remove blank line

11:23 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-1195-2
commented on review

Remove blank line.

11:01 am

Michael Garthwaite and Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-3676-1
finished reviewing

11:00 am

Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-1195-2
finished reviewing

11:00 am

Sean Nash

10:46 am

Vendor - TEL - Arpita Srivastava

I tried the suggested change and tested. But it did not provide the expected results. If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without...

I tried the suggested change and tested. But it did not provide the expected results.
If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without the actual request being processed and the off request was never executed.

10:30 am