To resolve the build failure with DD, haven't added all the features, instead added TODO comment

Idea is to have this in institutional records we implement it

a time out for decaying D66 pressure to 3 PSI after D65 closed

If this is const, how will user add conversions (after 3rd value)?

Remove extra blank line.

remove space after <= and add space end of function call.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

if we are not checking level, this can be removed and function name also can be updated accordingly.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

can we get 'runPIController' inside deadband control check?

Can we add sodium and bicarb overrides now, so that we don't want to come back again for this change?
Also, please get the dialin updated to reflect the new parameters additions in tdproxy and let system team be in loop to update the required system scripts?

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

· /firmware/App/Controllers/BoostPump.c	(-84, +212)	| History	| Source	| Diff
· /firmware/App/Controllers/BoostPump.h	(-3, +13)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModeGenPermeate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeate.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushConcentrate.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushFilter.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushPermeate.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateInletPressureCheck.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-1, +1)	| History	| Source	| Diff

]]> Tue, 28 Apr 2026 11:20:14 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4188-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4188-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4188-1 ]]> Tue, 28 Apr 2026 11:11:21 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28727 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28727 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Remove space after 'Supply'.

Align the value declaration indentation.

looks you are already checking this state in a line above.

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

Declare local variables at top of scope.

Add space between ( and ?

Remove blank line.

Why redeclare result?