Fisheye on dd-firmware/firmware/App/Services/Messaging.c https://devapps.diality.us/changelog/~br%3DLDT-3975-water-treatment-and-degassing--/dd-firmware/firmware/App/Services/Messaging.c Recent activity in "dd-firmware" under directory /firmware/App/Services/Messaging.c LEAHI-DD-FIRMWARE-LDT-4001-1: reviewers joined LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation... Fri, 29 May 2026 18:29:56 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 Vinayakam Mani joined LEAHI-DD-FIRMWARE-LDT-4001-1 LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4: ]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Vinayakam Mani "This needs TD source update and also dialin upd..." Fri, 29 May 2026 18:27:35 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29540 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29540 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4001-1

This needs TD source update and also dialin update, keep informed system team about this change as this would impact DD demo running.

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Vinayakam Mani "Please add HDF Pump speed register and add a mo..." Fri, 29 May 2026 18:24:35 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29539 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29539 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4001-1

Please add HDF Pump speed register and add a monitor in the substitution pump controller to compare against the target speed and if the difference is out of range, trigger an alarm.

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Vinayakam Mani "Substitution pump" Fri, 29 May 2026 18:20:06 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29538 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29538 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4001-1

Substitution pump

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Vinayakam Mani "Missing comment." Fri, 29 May 2026 14:03:18 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29526 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29526 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4001-1

Missing comment.

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Vinayakam Mani "update comment. next one as well." Fri, 29 May 2026 14:01:46 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29525 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29525 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4001-1

update comment. next one as well.

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Vinayakam Mani "blank line after the banner and maintain alphab..." Fri, 29 May 2026 13:58:59 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29524 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29524 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4001-1

blank line after the banner and maintain alphabetical order of include files.

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: started by Dara Navaei Fri, 29 May 2026 11:02:02 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4001-1 ]]> LEAHI-DD-FIRMWARE-LDT-3272-1: closed by Dara Navaei Wed, 27 May 2026 16:24:39 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1 Dara Navaei Closed LEAHI-DD-FIRMWARE-LDT-3272-1 ]]> LEAHI-DD-FIRMWARE-LDT-3272-1: reviewers finished Wed, 27 May 2026 15:38:22 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1 Vendor - TEL - Jashwant Gantyada and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3272-1 LEAHI-DD-FIRMWARE-LDT-3272_Software Update - DD ]]> LEAHI-DD-FIRMWARE-LDT-3272-1: comment by Dara Navaei "This file has been updated by HALCoGen automati..." Wed, 27 May 2026 14:08:03 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29422 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29422 Dara Navaei replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3272-1

This file has been updated by HALCoGen automatically.

]]> LEAHI-DD-FIRMWARE-LDT-3272-1: comment by Dara Navaei "This file has been updated by HALCoGen automati..." Wed, 27 May 2026 14:07:56 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29421 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29421 Dara Navaei replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3272-1

This file has been updated by HALCoGen automatically.

]]> LEAHI-DD-FIRMWARE-LDT-3272-1: comment by Dara Navaei "This file has been updated by HALCoGen automati..." Wed, 27 May 2026 14:06:09 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29419 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29419 Dara Navaei replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3272-1

This file has been updated by HALCoGen automatically.

]]> LEAHI-DD-FIRMWARE-LDT-3272-1: comment by Dara Navaei "This file has been updated by HALCoGen automati..." Wed, 27 May 2026 14:06:03 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29418 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29418 Dara Navaei replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3272-1

This file has been updated by HALCoGen automatically.

]]> LEAHI-DD-FIRMWARE-LDT-3272-1: comment by Dara Navaei "Done" Wed, 27 May 2026 14:05:40 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29417 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29417 Dara Navaei replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3272-1

Done

]]> LEAHI-DD-FIRMWARE-LDT-3272-1: comment by Dara Navaei "Done" Wed, 27 May 2026 14:05:16 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29416 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29416 Dara Navaei replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3272-1

Done

]]> LEAHI-DD-FIRMWARE-LDT-3272-1: comment by Dara Navaei "Done" Wed, 27 May 2026 13:46:56 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29410 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29410 Dara Navaei replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3272-1

Done

]]> LEAHI-DD-FIRMWARE-LDT-3272-1: comment by Sean Nash "Non-Dialin messages should be higher in this li..." Wed, 27 May 2026 10:22:41 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29380 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29380 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3272-1

Non-Dialin messages should be higher in this list than Dialin messages. Move this above all of the "test" handlers.

]]> LEAHI-DD-FIRMWARE-LDT-3272-1: comment by Sean Nash "Remove extra copyright block." Wed, 27 May 2026 10:20:51 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29377 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29377 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3272-1

Remove extra copyright block.

]]> LEAHI-DD-FIRMWARE-LDT-3272-1: comment by Sean Nash "These 2 new channels should be using message bo..." Wed, 27 May 2026 10:19:51 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29376 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29376 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3272-1

These 2 new channels should be using message boxes before Dialin channel message boxes. Align with buffers enum.

]]> LEAHI-DD-FIRMWARE-LDT-3272-1: comment by Sean Nash "This is auto generated code. How do we keep th..." Wed, 27 May 2026 10:16:59 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29375 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29375 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3272-1

This is auto generated code. How do we keep this code from re-appearing when somebody regenerates this code?

]]> LEAHI-DD-FIRMWARE-LDT-3272-1: comment by Sean Nash "Same." Wed, 27 May 2026 10:02:43 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29370 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29370 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3272-1

Same.

]]> LEAHI-DD-FIRMWARE-LDT-3272-1: comment by Sean Nash "Same" Wed, 27 May 2026 10:02:33 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29369 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29369 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3272-1

Same

]]> LEAHI-DD-FIRMWARE-LDT-3272-1: comment by Sean Nash "We shouldn't delete generated code. Add a #if ..." Wed, 27 May 2026 10:01:27 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29368 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1/#c29368 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3272-1

We shouldn't delete generated code. Add a #if 0 in this user code section and add a #endif in the user section below the coreEnableFlashEcc() call.

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: closed by Vendor - TEL - Jashwant Gantyada Fri, 22 May 2026 11:11:01 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 Vendor - TEL - Jashwant Gantyada Closed LEAHI-DD-FIRMWARE-LDT-3963-1 ]]> LEAHI-DD-FIRMWARE-LDT-3963-1: reviewers finished Fri, 22 May 2026 10:50:41 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3963-1 LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - FW Implementation - 1/3: ]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vendor - TEL - Jashwant Gantyada "restored" Thu, 21 May 2026 15:24:19 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29309 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29309 Vendor - TEL - Jashwant Gantyada replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3963-1

restored

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Not sure why Crucible is showing it this way. ..." Thu, 21 May 2026 15:23:57 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29308 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29308 Sean Nash replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-3963-1

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Should be #ifndef" Sun, 17 May 2026 23:23:10 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29158 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29158 Sean Nash replied to Vendor - TEL - Jashwant Gantyada in LEAHI-DD-FIRMWARE-LDT-3963-1

Should be #ifndef

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Should be #ifndef I think." Thu, 21 May 2026 15:13:44 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29307 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29307 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Should be #ifndef I think.

]]>