Fisheye on dd-firmware/firmware/App/Controllers/ROPump.c

dd-firmware (LDT-3749-ability-to-set-operation-sub-mode-latest): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 16 Apr 2026 08:24:53 -0700

Dara Navaei committed fd21f03 on branch LDT-2004-dialysate-composition-dosing-control--dd, LDT-3749-ability-to-set-operation-sub-mode-latest and 9 more in dd-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/PermeateTank.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaDD.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	\| History	\| Source	\| Diff

LEAHI-DD-FIRMWARE-LDT-3218-4: closed by Michael Garthwaite

Michael Garthwaite — Thu, 16 Apr 2026 08:15:43 -0700

Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-3218-4

LEAHI-DD-FIRMWARE-LDT-3218-4: reviewers finished

Wed, 15 Apr 2026 17:31:50 -0700

Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3218-4

LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)

LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "by the end of S27 we will know if we need to ke..."

Michael Garthwaite — Wed, 15 Apr 2026 16:12:48 -0700

Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-3218-4

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Vinayakam Mani "If this is the core change, can we introduce th..."

Vinayakam Mani — Wed, 15 Apr 2026 15:34:19 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3218-4

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)

LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "nope. removed."

Michael Garthwaite — Wed, 15 Apr 2026 09:52:57 -0700

Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3218-4

nope. removed.

LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "fixed"

Michael Garthwaite — Wed, 15 Apr 2026 09:52:50 -0700

Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3218-4

fixed

LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "fixed"

Michael Garthwaite — Wed, 15 Apr 2026 09:52:35 -0700

Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3218-4

fixed

LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "fixed"

Michael Garthwaite — Wed, 15 Apr 2026 09:52:20 -0700

Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3218-4

fixed

LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "fixed"

Michael Garthwaite — Wed, 15 Apr 2026 09:52:04 -0700

Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3218-4

fixed

dd-firmware (LDT-3749-ability-to-set-operation-sub-mode-latest): LDT-3218: code review comments

Michael Garthwaite — Wed, 15 Apr 2026 07:52:41 -0700

Michael Garthwaite committed 5d505b3 on branch LDT-2004-dialysate-composition-dosing-control--dd, LDT-3218-update-iofp-permeate-target-flow-CLEAN and 10 more in dd-firmware

LDT-3218: code review comments

· /firmware/App/Controllers/ROPump.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-3, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaDD.c	(-1, +1)	\| History	\| Source	\| Diff

LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash "Add blank line before return."

Sean Nash — Tue, 14 Apr 2026 14:08:22 -0700