Fisheye on dd-firmware/firmware/App/Tasks/TaskPriority.c https://devapps.diality.us/changelog/~br%3DLDT-4003-hdf-fw-implementation-4-4/dd-firmware/firmware/App/Tasks/TaskPriority.c Recent activity in "dd-firmware" under directory /firmware/App/Tasks/TaskPriority.c LEAHI-DD-FIRMWARE-LDT-4001-1: closed by Michael Garthwaite Thu, 11 Jun 2026 14:24:17 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-4001-1 ]]> LEAHI-DD-FIRMWARE-LDT-4001-1: reviewers finished Thu, 11 Jun 2026 13:27:23 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 Vinayakam Mani and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-4001-1 LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4: ]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Thu, 11 Jun 2026 10:08:28 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29802 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29802 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Sean Nash "Should we change msg ID from speed to rate?" Thu, 11 Jun 2026 10:00:00 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29801 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29801 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4001-1

Should we change msg ID from speed to rate?

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Thu, 11 Jun 2026 09:59:46 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29800 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "its a speed in rpm. updated function to convert..." Thu, 11 Jun 2026 09:59:23 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29799 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29799 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Thu, 11 Jun 2026 09:58:50 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29798 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29798 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "this is a set speed in rpm" Thu, 11 Jun 2026 09:57:48 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29797 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29797 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

this is a set speed in rpm

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "this is speed in rpm" Thu, 11 Jun 2026 09:57:38 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29796 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29796 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

this is speed in rpm

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Thu, 11 Jun 2026 09:57:26 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29795 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29795 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Thu, 11 Jun 2026 09:57:07 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29794 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29794 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Thu, 11 Jun 2026 09:57:04 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29793 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29793 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Sean Nash "Change speed to rate." Thu, 11 Jun 2026 09:43:35 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29791 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29791 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4001-1

Change speed to rate.

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Sean Nash "pumpTargetRate" Thu, 11 Jun 2026 09:43:24 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29790 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29790 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4001-1

pumpTargetRate

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Sean Nash "Change function name to say rate instead of spe..." Thu, 11 Jun 2026 09:43:09 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29789 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29789 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4001-1

Change function name to say rate instead of speed

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Sean Nash "Is this a rate too?" Thu, 11 Jun 2026 09:42:41 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29788 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29788 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4001-1

Is this a rate too?

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Sean Nash "Is this a rate too?" Thu, 11 Jun 2026 09:42:18 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29787 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29787 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4001-1

Is this a rate too?

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Sean Nash "Change speed to rate." Thu, 11 Jun 2026 09:40:51 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29786 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29786 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4001-1

Change speed to rate.

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Sean Nash "Is currentPumpSpeed actually a rate?" Thu, 11 Jun 2026 09:40:04 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29785 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29785 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4001-1

Is currentPumpSpeed actually a rate?

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Sean Nash "Is this comment correct? Seems like we're stop..." Thu, 11 Jun 2026 09:38:31 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29784 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29784 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4001-1

Is this comment correct? Seems like we're stopping pump if requested to turn off.

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Sean Nash "Is currentPumpSpeed also a rate? If not, we're..." Thu, 11 Jun 2026 09:36:25 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29783 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29783 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4001-1

Is currentPumpSpeed also a rate? If not, we're subtracting a speed from a rate which doesn't make much sense.

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Sean Nash "Align comment." Thu, 11 Jun 2026 09:34:54 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29782 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29782 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4001-1

Align comment.

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Sean Nash "Align comment. Change "speed" to "rate in comm..." Thu, 11 Jun 2026 09:33:32 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29781 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29781 Sean Nash replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

Align comment. Change "speed" to "rate in comment too.
Also, I don't see you initializing these rates.

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Thu, 11 Jun 2026 09:33:22 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29780 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29780 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Sean Nash "Change to pumpTargetRate since mL/min is a rate..." Thu, 11 Jun 2026 09:20:36 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29777 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29777 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4001-1

Change to pumpTargetRate since mL/min is a rate.

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Wed, 10 Jun 2026 13:20:25 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29758 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29758 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Wed, 10 Jun 2026 13:20:12 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29757 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29757 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Wed, 10 Jun 2026 13:20:01 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29756 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29756 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: reviewers resumed Wed, 10 Jun 2026 13:18:29 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 Vendor - TEL - Jashwant Gantyada resumed reviewing LEAHI-DD-FIRMWARE-LDT-4001-1 LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4: ]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Vendor - TEL - Sameer Poyil "Please check with TD, I have seen one of the de..." Wed, 10 Jun 2026 09:21:22 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29742 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29742 Vendor - TEL - Sameer Poyil replied to Michael Garthwaite in LEAHI-DD-FIRMWARE-LDT-4001-1

Please check with TD, I have seen one of the develop branch this populated in pre gen and gen.

]]>